0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 08:50:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Don't paint text fragments with CSS visibility:hidden

Browse source 
We *could* even skip creating a paintable for hidden nodes, but that
means that dynamic updates to the CSS visibility property would require
mutating the paint tree, so let's keep it simple for now.
This commit is contained in:
Andreas Kling 2024-08-24 13:56:06 +02:00 committed by Andreas Kling
parent 2e9aec984c
commit 349b17cc7a
Notes: github-actions[bot] 2024-08-25 01:15:24 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/349b17cc7aa
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1180
3 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Ref/inline-visibility-hidden.html Normal file
View file

@ -0,0 +1,2 @@
<link rel="match" href="reference/inline-visibility-hidden-ref.html" />
<span>hello friends<span style="visibility: hidden"> and enemies</span></span>

1
Tests/LibWeb/Ref/reference/inline-visibility-hidden-ref.html Normal file
View file

@ -0,0 +1 @@
<span>hello friends</span>

3
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -605,6 +605,9 @@ void paint_text_decoration(PaintContext& context, TextPaintable const& paintable
void paint_text_fragment(PaintContext& context, TextPaintable const& paintable, PaintableFragment const& fragment, PaintPhase phase)
{
if (!paintable.is_visible())
return;
auto& painter = context.display_list_recorder();
if (phase == PaintPhase::Foreground) {