Browse Source

LibGUI: Fix silly nullptr dereference in MessageBox::show()

Since we take the parent object as a raw pointer, we should handle the
case where it's null.
Andreas Kling 5 years ago
parent
commit
3252a6925e
1 changed files with 3 additions and 1 deletions
  1. 3 1
      Libraries/LibGUI/MessageBox.cpp

+ 3 - 1
Libraries/LibGUI/MessageBox.cpp

@@ -35,7 +35,9 @@ namespace GUI {
 
 
 int MessageBox::show(const StringView& text, const StringView& title, Type type, InputType input_type, Core::Object* parent)
 int MessageBox::show(const StringView& text, const StringView& title, Type type, InputType input_type, Core::Object* parent)
 {
 {
-    auto box = parent->add<MessageBox>(text, title, type, input_type);
+    auto box = MessageBox::construct(text, title, type, input_type);
+    if (parent)
+        parent->add_child(box);
     return box->exec();
     return box->exec();
 }
 }