Browse Source

LibC: Remove static from function local constexpr variable

Problem:
- Function local `constexpr` variables do not need to be
  `static`. This consumes memory which is unnecessary and can prevent
  some optimizations.

Solution:
- Remove `static` keyword.
Lenny Maiorani 4 years ago
parent
commit
31d24d8292
2 changed files with 2 additions and 2 deletions
  1. 1 1
      Userland/Libraries/LibC/stdlib.cpp
  2. 1 1
      Userland/Utilities/mktemp.cpp

+ 1 - 1
Userland/Libraries/LibC/stdlib.cpp

@@ -165,7 +165,7 @@ inline int generate_unique_filename(char* pattern, Callback callback)
 
 
     size_t start = length - 6;
     size_t start = length - 6;
 
 
-    static constexpr char random_characters[] = "abcdefghijklmnopqrstuvwxyz0123456789";
+    constexpr char random_characters[] = "abcdefghijklmnopqrstuvwxyz0123456789";
 
 
     for (int attempt = 0; attempt < 100; ++attempt) {
     for (int attempt = 0; attempt < 100; ++attempt) {
         for (int i = 0; i < 6; ++i)
         for (int i = 0; i < 6; ++i)

+ 1 - 1
Userland/Utilities/mktemp.cpp

@@ -21,7 +21,7 @@ static char* generate_random_filename(const char* pattern)
     char* new_filename = strdup(pattern);
     char* new_filename = strdup(pattern);
     int pattern_length = strlen(pattern);
     int pattern_length = strlen(pattern);
 
 
-    static constexpr char random_characters[] = "abcdefghijklmnopqrstuvwxyz0123456789";
+    constexpr char random_characters[] = "abcdefghijklmnopqrstuvwxyz0123456789";
     for (auto i = pattern_length - 1; i >= 0; --i) {
     for (auto i = pattern_length - 1; i >= 0; --i) {
         if (pattern[i] != 'X')
         if (pattern[i] != 'X')
             break;
             break;