Переглянути джерело

LibWebView+WebContent: Remove unused `did_get_dom_node_properties` IPC

This is never invoked. The functionality it provides is implemented by
the return value of the `inspect_dom_node` IPC.
Timothy Flynn 1 рік тому
батько
коміт
30e96749de

+ 0 - 4
Userland/Applications/Browser/Tab.cpp

@@ -580,10 +580,6 @@ Tab::Tab(BrowserWindow& window)
             m_dom_inspector_widget->set_dom_json(dom_tree);
     };
 
-    view().on_received_dom_node_properties = [this](auto node_id, auto& specified, auto& computed, auto& custom_properties, auto& node_box_sizing, auto& aria_properties_state) {
-        m_dom_inspector_widget->set_dom_node_properties_json({ node_id }, specified, computed, custom_properties, node_box_sizing, aria_properties_state);
-    };
-
     view().on_received_accessibility_tree = [this](auto& accessibility_tree) {
         if (m_dom_inspector_widget)
             m_dom_inspector_widget->set_accessibility_json(accessibility_tree);

+ 0 - 1
Userland/Libraries/LibWebView/ViewImplementation.h

@@ -141,7 +141,6 @@ public:
     Function<void()> on_request_dismiss_dialog;
     Function<void(const AK::URL&, DeprecatedString const&)> on_received_source;
     Function<void(DeprecatedString const&)> on_received_dom_tree;
-    Function<void(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_state)> on_received_dom_node_properties;
     Function<void(DeprecatedString const&)> on_received_accessibility_tree;
     Function<void(i32 message_id)> on_received_console_message;
     Function<void(i32 start_index, Vector<DeprecatedString> const& message_types, Vector<DeprecatedString> const& messages)> on_received_console_messages;

+ 0 - 6
Userland/Libraries/LibWebView/WebContentClient.cpp

@@ -208,12 +208,6 @@ void WebContentClient::did_get_dom_tree(DeprecatedString const& dom_tree)
         m_view.on_received_dom_tree(dom_tree);
 }
 
-void WebContentClient::did_get_dom_node_properties(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_state)
-{
-    if (m_view.on_received_dom_node_properties)
-        m_view.on_received_dom_node_properties(node_id, computed_style, resolved_style, custom_properties, node_box_sizing, aria_properties_state);
-}
-
 void WebContentClient::did_get_accessibility_tree(DeprecatedString const& accessibility_tree)
 {
     if (m_view.on_received_accessibility_tree)

+ 0 - 1
Userland/Libraries/LibWebView/WebContentClient.h

@@ -55,7 +55,6 @@ private:
     virtual void did_request_media_context_menu(Gfx::IntPoint, DeprecatedString const&, unsigned, Web::Page::MediaContextMenu const&) override;
     virtual void did_get_source(AK::URL const&, DeprecatedString const&) override;
     virtual void did_get_dom_tree(DeprecatedString const&) override;
-    virtual void did_get_dom_node_properties(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_stae) override;
     virtual void did_get_accessibility_tree(DeprecatedString const&) override;
     virtual void did_output_js_console_message(i32 message_index) override;
     virtual void did_get_js_console_messages(i32 start_index, Vector<DeprecatedString> const& message_types, Vector<DeprecatedString> const& messages) override;

+ 0 - 1
Userland/Services/WebContent/WebContentClient.ipc

@@ -41,7 +41,6 @@ endpoint WebContentClient
     did_request_dismiss_dialog() =|
     did_get_source(URL url, DeprecatedString source) =|
     did_get_dom_tree(DeprecatedString dom_tree) =|
-    did_get_dom_node_properties(i32 node_id, DeprecatedString computed_style, DeprecatedString resolved_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing_json, DeprecatedString aria_properties_state) =|
     did_get_accessibility_tree(DeprecatedString accessibility_tree) =|
     did_change_favicon(Gfx::ShareableBitmap favicon) =|
     did_request_all_cookies(URL url) => (Vector<Web::Cookie::Cookie> cookies)