0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Make number parts unsigned in NumberPrototype::to_string

Browse source 
Fixes #3931
This commit is contained in:
Luke 2021-05-11 17:16:58 +01:00 • committed by Linus Groh
parent ecbe17fb11
commit 2ff03ecfa8
Notes: sideshowbarker 2024-07-18 18:19:47 +09:00
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/NumberPrototype.cpp
View file

@ -80,7 +80,7 @@ JS_DEFINE_NATIVE_FUNCTION(NumberPrototype::to_string)
if (negative)
number *= -1;
int int_part = floor(number);
u32 int_part = floor(number);
double decimal_part = number - int_part;
Vector<char> backwards_characters;
@ -107,11 +107,11 @@ JS_DEFINE_NATIVE_FUNCTION(NumberPrototype::to_string)
if (decimal_part != 0.0) {
characters.append('.');
int precision = max_precision_for_radix[radix];
u8 precision = max_precision_for_radix[radix];
for (int i = 0; i < precision; ++i) {
for (u8 i = 0; i < precision; ++i) {
decimal_part *= radix;
int integral = floor(decimal_part);
u32 integral = floor(decimal_part);
characters.append(digits[integral]);
decimal_part -= integral;
}

3
Userland/Libraries/LibJS/Tests/builtins/Number/Number.prototype.toString.js
View file

@ -13,6 +13,9 @@ describe("correct behavior", () => {
[12, "12"],
[93465, "93465"],
[358000, "358000"],
// Numbers above 2 ** 31 - 1 (Issue #3931)
[2147483648, "2147483648"], // 2 ** 31
[4294967295, "4294967295"], // 2 ** 32 - 1
].forEach(testCase => {
expect(testCase[0].toString()).toBe(testCase[1]);
});