Browse Source

LibWeb: Make factory method of HTML::History fallible

Kenneth Myhra 2 years ago
parent
commit
2f4db60c08

+ 1 - 1
Userland/Libraries/LibWeb/DOM/Document.cpp

@@ -2058,7 +2058,7 @@ CSS::StyleSheetList const& Document::style_sheets() const
 JS::NonnullGCPtr<HTML::History> Document::history()
 {
     if (!m_history)
-        m_history = HTML::History::create(realm(), *this);
+        m_history = HTML::History::create(realm(), *this).release_value_but_fixme_should_propagate_errors();
     return *m_history;
 }
 

+ 2 - 2
Userland/Libraries/LibWeb/HTML/History.cpp

@@ -10,9 +10,9 @@
 
 namespace Web::HTML {
 
-JS::NonnullGCPtr<History> History::create(JS::Realm& realm, DOM::Document& document)
+WebIDL::ExceptionOr<JS::NonnullGCPtr<History>> History::create(JS::Realm& realm, DOM::Document& document)
 {
-    return realm.heap().allocate<History>(realm, realm, document).release_allocated_value_but_fixme_should_propagate_errors();
+    return MUST_OR_THROW_OOM(realm.heap().allocate<History>(realm, realm, document));
 }
 
 History::History(JS::Realm& realm, DOM::Document& document)

+ 1 - 1
Userland/Libraries/LibWeb/HTML/History.h

@@ -16,7 +16,7 @@ class History final : public Bindings::PlatformObject {
     WEB_PLATFORM_OBJECT(History, Bindings::PlatformObject);
 
 public:
-    static JS::NonnullGCPtr<History> create(JS::Realm&, DOM::Document&);
+    static WebIDL::ExceptionOr<JS::NonnullGCPtr<History>> create(JS::Realm&, DOM::Document&);
 
     virtual ~History() override;