From 2f16198bd6ca770573921d9356edf855a8bbd9ed Mon Sep 17 00:00:00 2001 From: Baitinq Date: Mon, 21 Nov 2022 00:58:32 +0100 Subject: [PATCH] LibWeb: Remove unused should_invalidate_styles_on_attribute_changes() This getter and setter were previously labelled as a "hack" and used to disable style invalidation on attribute changes during the HTML parsing phase (as it caused big sites's loading to be slow). These functions are currently not used, so they can be removed:^) --- Userland/Libraries/LibWeb/DOM/Document.h | 3 --- Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp | 2 -- 2 files changed, 5 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Document.h b/Userland/Libraries/LibWeb/DOM/Document.h index b55e7284f6f..2f43ee6ac9d 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.h +++ b/Userland/Libraries/LibWeb/DOM/Document.h @@ -100,9 +100,6 @@ public: String referrer() const; void set_referrer(String); - bool should_invalidate_styles_on_attribute_changes() const { return m_should_invalidate_styles_on_attribute_changes; } - void set_should_invalidate_styles_on_attribute_changes(bool b) { m_should_invalidate_styles_on_attribute_changes = b; } - void set_url(const AK::URL& url) { m_url = url; } AK::URL url() const { return m_url; } AK::URL fallback_base_url() const; diff --git a/Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp b/Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp index 9a23d33721f..922f88aaf1d 100644 --- a/Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp +++ b/Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp @@ -128,7 +128,6 @@ HTMLParser::HTMLParser(DOM::Document& document, StringView input, String const& { m_tokenizer.set_parser({}, *this); m_document->set_parser({}, *this); - m_document->set_should_invalidate_styles_on_attribute_changes(false); auto standardized_encoding = TextCodec::get_standardized_encoding(encoding); VERIFY(standardized_encoding.has_value()); m_document->set_encoding(standardized_encoding.value()); @@ -144,7 +143,6 @@ HTMLParser::HTMLParser(DOM::Document& document) HTMLParser::~HTMLParser() { - m_document->set_should_invalidate_styles_on_attribute_changes(true); } void HTMLParser::visit_edges(Cell::Visitor& visitor)