We use cookies to ensure you get the best experience on our website
홈 탐색 도움말
가입하기 로그인
0ct0pu5
/
ladybird
1
0
포크 0
파일 이슈 0 풀 리퀘스트 0 위키
소스 검색

LibWeb: Assign “orphaned” li elements the default ARIA role “none”

This change makes Ladybird conform to the current requirements at
https://w3c.github.io/core-aam/#roleMappingComputedRole in the “Core
Accessibility API Mappings” spec for the case of “orphaned” li elements;
that is, any li element which doesn’t have a role=list ancestor.

The core-aam spec requires that in such cases, the li element must not
be assigned the “listitem” role but instead must be treated as if it had
no role at all.
sideshowbarker 7 달 전
부모
824e91ffdb
커밋
2d638485a8
3개의 변경된 파일과 42개의 추가작업 그리고 2개의 파일을 삭제
통합 보기 변경상태 보기
  1. 15 2
      Libraries/LibWeb/HTML/HTMLLIElement.h
  2. 6 0
      Tests/LibWeb/Text/expected/wpt-import/html-aam/roles-generic.tentative.txt
  3. 21 0
      Tests/LibWeb/Text/input/wpt-import/html-aam/roles-generic.tentative.html

+ 15 - 2
Libraries/LibWeb/HTML/HTMLLIElement.h
파일 보기 

@@ -6,8 +6,10 @@
 
 
 
 #pragma once
 
 #pragma once
 
 
 
-#include <LibWeb/ARIA/Roles.h>
 
+#include <AK/GenericShorthands.h>
 
 #include <LibWeb/HTML/HTMLElement.h>
 
 #include <LibWeb/HTML/HTMLElement.h>
 
+#include <LibWeb/HTML/HTMLOListElement.h>
 
+#include <LibWeb/HTML/HTMLUListElement.h>
 
 #include <LibWeb/WebIDL/Types.h>
 
 #include <LibWeb/WebIDL/Types.h>
 
 
 
 namespace Web::HTML {
 
 namespace Web::HTML {
 
@@ -20,7 +22,18 @@ public:
 
     virtual ~HTMLLIElement() override;
 
     virtual ~HTMLLIElement() override;
 
 
 
     // https://www.w3.org/TR/html-aria/#el-li
 
     // https://www.w3.org/TR/html-aria/#el-li
 
-    virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::listitem; }
 
+    virtual Optional<ARIA::Role> default_role() const override
 
+    {
 
+        for (auto const* ancestor = parent_element(); ancestor; ancestor = ancestor->parent_element()) {
 
+            if (ancestor->role_or_default() == ARIA::Role::list)
 
+                return ARIA::Role::listitem;
 
+        }
 
+        // https://w3c.github.io/core-aam/#roleMappingComputedRole
 
+        // When an element has a role but is not contained in the required context (for example, an orphaned listitem
 
+        // without the required accessible parent of role list), User Agents MUST ignore the role token, and return the
 
+        // computedrole as if the ignored role token had not been included.
 
+        return ARIA::Role::none;
 
+    }
 
 
 
     WebIDL::Long value();
 
     WebIDL::Long value();
 
     void set_value(WebIDL::Long value)
 
     void set_value(WebIDL::Long value)

+ 6 - 0
Tests/LibWeb/Text/expected/wpt-import/html-aam/roles-generic.tentative.txt
파일 보기 

@@ -0,0 +1,6 @@
 
+Harness status: OK
 
+
 
+Found 1 tests
 
+
 
+1 Pass
 
+Pass	el-li-orphaned

+ 21 - 0
Tests/LibWeb/Text/input/wpt-import/html-aam/roles-generic.tentative.html
파일 보기 

@@ -0,0 +1,21 @@
 
+<!doctype html>
 
+<html>
 
+<head>
 
+  <title>Tentative: HTML-AAM Generic Role Verification Tests</title>
 
+  <script src="../resources/testharness.js"></script>
 
+  <script src="../resources/testharnessreport.js"></script>
 
+  <script src="../resources/testdriver.js"></script>
 
+  <script src="../resources/testdriver-vendor.js"></script>
 
+  <script src="../resources/testdriver-actions.js"></script>
 
+  <script src="../wai-aria/scripts/aria-utils.js"></script>
 
+</head>
 
+<body>
 
+
 
+<li data-testname="el-li-orphaned" class="ex-generic">x</li><!-- todo: should orphaned roles be tested in a new ./roles-orphaned.html file? -->
 
+
 
+<script>
 
+AriaUtils.verifyGenericRolesBySelector(".ex-generic");
 
+</script>
 
+
 
+</body>
 
+</html>

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5