Kaynağa Gözat

LibWeb: Toggle media playback when clicking anywhere on the control box

Feels nicer to click anywhere on the control box to toggle playback,
rather than needing to accurately click the playback button. Note this
does not affect other behavior-specific buttons; i.e. if the mute button
is pressed, we won't reach the playback toggle..
Timothy Flynn 2 yıl önce
ebeveyn
işleme
2c5c815f44

+ 2 - 1
Userland/Libraries/LibWeb/Painting/MediaPaintable.cpp

@@ -321,7 +321,8 @@ MediaPaintable::DispatchEventOfSameName MediaPaintable::handle_mouseup(Badge<Eve
             return DispatchEventOfSameName::Yes;
         }
 
-        return DispatchEventOfSameName::No;
+        if (cached_layout_boxes.timeline_rect.has_value() && cached_layout_boxes.timeline_rect->contains(position))
+            return DispatchEventOfSameName::No;
     }
 
     media_element.toggle_playback().release_value_but_fixme_should_propagate_errors();