Ver Fonte

Kernel: Minor cleanups in sendfd/recvfd

Applying some nice suggestions by @bugaevc. :^)
Andreas Kling há 5 anos atrás
pai
commit
28bfd73b68
2 ficheiros alterados com 8 adições e 8 exclusões
  1. 4 4
      Kernel/Net/LocalSocket.cpp
  2. 4 4
      Kernel/Net/LocalSocket.h

+ 4 - 4
Kernel/Net/LocalSocket.cpp

@@ -397,7 +397,7 @@ KResult LocalSocket::chown(FileDescription&, uid_t uid, gid_t gid)
     return KSuccess;
 }
 
-NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(FileDescription& description)
+NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(const FileDescription& description)
 {
     auto role = this->role(description);
     if (role == Role::Connected)
@@ -407,7 +407,7 @@ NonnullRefPtrVector<FileDescription>& LocalSocket::recvfd_queue_for(FileDescript
     ASSERT_NOT_REACHED();
 }
 
-NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(FileDescription& description)
+NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(const FileDescription& description)
 {
     auto role = this->role(description);
     if (role == Role::Connected)
@@ -417,7 +417,7 @@ NonnullRefPtrVector<FileDescription>& LocalSocket::sendfd_queue_for(FileDescript
     ASSERT_NOT_REACHED();
 }
 
-KResult LocalSocket::sendfd(FileDescription& socket_description, NonnullRefPtr<FileDescription> passing_description)
+KResult LocalSocket::sendfd(const FileDescription& socket_description, FileDescription& passing_description)
 {
     LOCKER(lock());
     auto role = this->role(socket_description);
@@ -431,7 +431,7 @@ KResult LocalSocket::sendfd(FileDescription& socket_description, NonnullRefPtr<F
     return KSuccess;
 }
 
-KResultOr<NonnullRefPtr<FileDescription>> LocalSocket::recvfd(FileDescription& socket_description)
+KResultOr<NonnullRefPtr<FileDescription>> LocalSocket::recvfd(const FileDescription& socket_description)
 {
     LOCKER(lock());
     auto role = this->role(socket_description);

+ 4 - 4
Kernel/Net/LocalSocket.h

@@ -42,8 +42,8 @@ public:
     static KResultOr<NonnullRefPtr<Socket>> create(int type);
     virtual ~LocalSocket() override;
 
-    KResult sendfd(FileDescription& socket_description, NonnullRefPtr<FileDescription> passing_description);
-    KResultOr<NonnullRefPtr<FileDescription>> recvfd(FileDescription& socket_description);
+    KResult sendfd(const FileDescription& socket_description, FileDescription& passing_description);
+    KResultOr<NonnullRefPtr<FileDescription>> recvfd(const FileDescription& socket_description);
 
     static void for_each(Function<void(const LocalSocket&)>);
 
@@ -74,8 +74,8 @@ private:
     static Lockable<InlineLinkedList<LocalSocket>>& all_sockets();
     DoubleBuffer& receive_buffer_for(FileDescription&);
     DoubleBuffer& send_buffer_for(FileDescription&);
-    NonnullRefPtrVector<FileDescription>& sendfd_queue_for(FileDescription&);
-    NonnullRefPtrVector<FileDescription>& recvfd_queue_for(FileDescription&);
+    NonnullRefPtrVector<FileDescription>& sendfd_queue_for(const FileDescription&);
+    NonnullRefPtrVector<FileDescription>& recvfd_queue_for(const FileDescription&);
 
     // An open socket file on the filesystem.
     RefPtr<FileDescription> m_file;