0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel/aarch64: Set Access Permission (writable bit) on PageTableEntry

Browse source 
This will cause page faults to be generated. Since the previous commits
introduced the handling of page faults, we can now actually correctly
handle page faults.
This commit is contained in:
Timon Kruiper 2023-01-08 13:46:31 +01:00 • committed by Andreas Kling
parent 1d58663298
commit 2896d7796d
Notes: sideshowbarker 2024-07-17 01:12:07 +09:00
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Kernel/Arch/aarch64/PageDirectory.h
View file

@ -40,6 +40,11 @@ constexpr u32 INNER_SHAREABLE = (3 << 8);
constexpr u32 NORMAL_MEMORY = (0 << 2);
constexpr u32 DEVICE_MEMORY = (1 << 2);
constexpr u32 ACCESS_PERMISSION_READWRITE = (0b00 << 6);
constexpr u32 ACCESS_PERMISSION_READWRITE_EL0 = (0b01 << 6);
constexpr u32 ACCESS_PERMISSION_READONLY = (0b10 << 6);
constexpr u32 ACCESS_PERMISSION_READONLY_EL0 = (0b11 << 6);
// Figure D5-15 of Arm Architecture Reference Manual Armv8 - page D5-2588
class PageDirectoryEntry {
public:
@ -120,18 +125,13 @@ public:
};
bool is_present() const { return (raw() & Present) == Present; }
void set_present(bool) { }
void set_present(bool b) { set_bit(Present, b); }
bool is_user_allowed() const { TODO_AARCH64(); }
void set_user_allowed(bool) { }
bool is_writable() const
{
dbgln("FIXME: PageTableEntry: Actually check if the entry is writable!");
return true;
}
void set_writable(bool) { }
bool is_writable() const { return !((raw() & ACCESS_PERMISSION_READONLY) == ACCESS_PERMISSION_READONLY); }
void set_writable(bool b) { set_bit(ACCESS_PERMISSION_READONLY, !b); }
bool is_write_through() const { TODO_AARCH64(); }
void set_write_through(bool) { }