ソースを参照

WindowServer: Cycle through menu items with the same Alt shortcut

If there are multiple items with the same Alt shortcut, cycle through
them with each keypress instead of activating immediately.
Sergiy Stupar 2 年 前
コミット
288d75fdab

+ 1 - 0
Userland/Services/WindowServer/Menu.h

@@ -105,6 +105,7 @@ public:
     void redraw(MenuItem const&);
 
     MenuItem* hovered_item() const;
+    int hovered_item_index() const { return m_hovered_item_index; };
 
     void set_hovered_index(int index, bool make_input = false);
 

+ 4 - 3
Userland/Services/WindowServer/MenuManager.cpp

@@ -68,11 +68,12 @@ void MenuManager::event(Core::Event& event)
 
             if (auto* shortcut_item_indices = m_current_menu->items_with_alt_shortcut(key_event.code_point())) {
                 VERIFY(!shortcut_item_indices->is_empty());
-                // FIXME: If there are multiple items with the same Alt shortcut, we should cycle through them
-                //        with each keypress instead of activating immediately.
-                auto index = shortcut_item_indices->at(0);
+                auto it = shortcut_item_indices->find_if([&](int const& i) { return i > m_current_menu->hovered_item_index(); });
+                auto index = shortcut_item_indices->at(it.is_end() ? 0 : it.index());
                 auto& item = m_current_menu->item(index);
                 m_current_menu->set_hovered_index(index);
+                if (shortcut_item_indices->size() > 1)
+                    return;
                 if (item.is_submenu())
                     m_current_menu->descend_into_submenu_at_hovered_item();
                 else