0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibPDF: Sketch out Lab color space

Browse source 
Same as other recent color spaces: Enough to make us not assert,
but not enough to actually produce color.

Fixes 2 asserts on the `-n 500` 0000.zip pdfa dataset.
This commit is contained in:
Nico Weber 2023-10-24 11:13:04 -07:00 committed by Andreas Kling
parent 1a4df4ffe7
commit 2878af5968
Notes: sideshowbarker 2024-07-17 01:12:07 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/2878af5968
Pull-request: https://github.com/SerenityOS/serenity/pull/21580
3 changed files with 39 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibPDF/ColorSpace.cpp
View file

@ -62,6 +62,9 @@ PDFErrorOr<NonnullRefPtr<ColorSpace>> ColorSpace::create(Document* document, Non
if (color_space_name == CommonNames::Indexed)
return Error::rendering_unsupported_error("Indexed color spaces not yet implemented");
if (color_space_name == CommonNames::Lab)
return TRY(LabColorSpace::create(document, move(parameters)));
if (color_space_name == CommonNames::Pattern)
return Error::rendering_unsupported_error("Pattern color spaces not yet implemented");
@ -382,6 +385,26 @@ Vector<float> ICCBasedColorSpace::default_decode() const
}
}
PDFErrorOr<NonnullRefPtr<LabColorSpace>> LabColorSpace::create(Document*, Vector<Value>&& parameters)
{
if (parameters.size() != 1)
return Error { Error::Type::MalformedPDF, "Lab color space expects one parameter" };
auto color_space = adopt_ref(*new LabColorSpace());
// FIXME: Implement.
return color_space;
}
PDFErrorOr<Color> LabColorSpace::color(ReadonlySpan<Value>) const
{
return Error::rendering_unsupported_error("Lab color spaces not yet implemented");
}
Vector<float> LabColorSpace::default_decode() const
{
return { 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f };
}
PDFErrorOr<NonnullRefPtr<SeparationColorSpace>> SeparationColorSpace::create(Document*, Vector<Value>&&)
{
auto color_space = adopt_ref(*new SeparationColorSpace());

15
Userland/Libraries/LibPDF/ColorSpace.h
View file

@ -144,6 +144,21 @@ private:
NonnullRefPtr<Gfx::ICC::Profile> m_profile;
};
class LabColorSpace final : public ColorSpace {
public:
static PDFErrorOr<NonnullRefPtr<LabColorSpace>> create(Document*, Vector<Value>&& parameters);
~LabColorSpace() override = default;
PDFErrorOr<Color> color(ReadonlySpan<Value> arguments) const override;
int number_of_components() const override { return 3; }
Vector<float> default_decode() const override;
ColorSpaceFamily const& family() const override { return ColorSpaceFamily::Lab; }
private:
LabColorSpace() = default;
};
class SeparationColorSpace final : public ColorSpace {
public:
static PDFErrorOr<NonnullRefPtr<SeparationColorSpace>> create(Document*, Vector<Value>&& parameters);

1
Userland/Libraries/LibPDF/CommonNames.h
View file

@ -99,6 +99,7 @@
X(LJ) \
X(LW) \
X(LZWDecode) \
X(Lab) \
X(Last) \
X(LastChar) \
X(Length) \