LibVideo: Fix string reading in Matroska

A string should never be longer than it's strlen according to the specification
Author: https://github.com/feliwir Commit: https://github.com/SerenityOS/serenity/commit/2732dd3633 Pull-request: https://github.com/SerenityOS/serenity/pull/22019 Reviewed-by: https://github.com/Zaggy1024 Reviewed-by: https://github.com/skyrising
2023-11-27 10:12:47 +01:00 · 2023-11-27 10:12:47 +01:00 · 2732dd3633 · 2024-07-17 04:01:41 +09:00
commit 2732dd3633
parent 1f55cc942d
1 changed files with 2 additions and 1 deletions
--- a/Userland/Libraries/LibVideo/Containers/Matroska/Reader.cpp
+++ b/Userland/Libraries/LibVideo/Containers/Matroska/Reader.cpp
@ -985,7 +985,8 @@ ErrorOr<DeprecatedString> Streamer::read_string()
    auto string_length = TRY(read_variable_size_integer());
    if (remaining() < string_length)
        return Error::from_string_literal("String length extends past the end of the stream");
-    auto string_value = DeprecatedString(data_as_chars(), string_length);
+    auto string_data = data_as_chars();
+    auto string_value = DeprecatedString(string_data, strnlen(string_data, string_length));
    TRY(read_raw_octets(string_length));
    return string_value;
 }