AK: Always inline StringView(const char*)

Also use strlen() instead of manually walking the string. This allows GCC to optimize away the strlen() entirely for string literals. :^)
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/268000e1664
2020-02-01 13:54:13 +01:00 · 2020-02-01 13:54:13 +01:00 · 268000e166 · 2024-07-19 09:43:56 +09:00
commit 268000e166
parent 625f6c0d86
1 changed files with 2 additions and 5 deletions
--- a/AK/StringView.h
+++ b/AK/StringView.h
@ -47,13 +47,10 @@ public:
        , m_length(length)
    {
    }
-    StringView(const char* cstring)
+    [[gnu::always_inline]] inline StringView(const char* cstring)
        : m_characters(cstring)
+        , m_length(cstring ? strlen(cstring) : 0)
    {
-        if (cstring) {
-            while (*(cstring++))
-                ++m_length;
-        }
    }

    StringView(const ByteBuffer&);