0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Revert "Kernel: Share committed COW pages between whole VMObject lineage"

Browse source 
This reverts commit 2c0df5e7e7.

This caused OOM on CI, so let's roll it back until we can figure it out.
This commit is contained in:
Andreas Kling 2021-07-30 13:49:41 +02:00
parent 5de7775d22
commit 25b76462bf
Notes: sideshowbarker 2024-07-18 07:44:48 +09:00
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
Kernel/VM/AnonymousVMObject.cpp
View file

@ -39,16 +39,17 @@ RefPtr<VMObject> AnonymousVMObject::try_clone()
if (!MM.commit_user_physical_pages(new_cow_pages_needed))
return {};
if (m_shared_committed_cow_pages) {
// We already have shared committed COW pages with another object.
// That sharing pool grows and the clone joins it.
m_shared_committed_cow_pages->m_committed_pages += new_cow_pages_needed;
} else {
m_shared_committed_cow_pages = try_create<CommittedCowPages>(new_cow_pages_needed);
if (!m_shared_committed_cow_pages) {
MM.uncommit_user_physical_pages(new_cow_pages_needed);
return {};
}
// Create or replace the committed cow pages. When cloning a previously
// cloned vmobject, we want to essentially "fork", leaving us and the
// new clone with one set of shared committed cow pages, and the original
// one would keep the one it still has. This ensures that the original
// one and this one, as well as the clone have sufficient resources
// to cow all pages as needed
m_shared_committed_cow_pages = try_create<CommittedCowPages>(new_cow_pages_needed);
if (!m_shared_committed_cow_pages) {
MM.uncommit_user_physical_pages(new_cow_pages_needed);
return {};
}
// Both original and clone become COW. So create a COW map for ourselves