0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Update document url after same-document back/forward navigation

Browse source 
Seems like a specification bug, but other browsers update url before
popstate event is fired and so should we.

Fixes back/forward navigation on GitHub.
This commit is contained in:
Aliaksandr Kalenik 2024-04-21 11:18:35 +02:00 • committed by Alexander Kalenik
parent 08aaf4fb07
commit 23d683cf6b
Notes: sideshowbarker 2024-07-17 17:49:11 +09:00
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Text/data/iframe-popstate-event.html
View file

@ -1,8 +1,10 @@
<script>
window.history.pushState({}, '', '');
window.history.pushState({}, '', window.location.href + '#test');
window.addEventListener('popstate', (e) => {
parent.postMessage('popstate event from iframe', '*');
const url = new URL(window.location.href);
const pathWithHash = url.pathname.split('/').pop() + url.hash;
parent.postMessage(`popstate event from iframe new_path=${pathWithHash}`, '*');
});
window.history.back();

2
Tests/LibWeb/Text/expected/navigation/history-popstate-event.txt
View file

@ -1 +1 @@
popstate event from iframe
popstate event from iframe new_path=iframe-popstate-event.html

3
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -4070,6 +4070,9 @@ void Document::update_for_history_step_application(JS::NonnullGCPtr<HTML::Sessio
// 5. If documentIsNew is false, then:
if (!document_is_new) {
// NOTE: Not in the spec, but otherwise document's url won't be updated in case of a same-document back/forward navigation.
set_url(entry->url());
// AD HOC: Skip this in situations the spec steps don't account for
if (update_navigation_api) {
// 1. Update the navigation API entries for a same-document navigation given navigation, entry, and "traverse".