Prechádzať zdrojové kódy

LibJS: Remove some unnecessary null checks

It's okay to add nullptr to the conservative roots set. We'll just
ignore it later on anyway.
Andreas Kling 4 rokov pred
rodič
commit
231171364d
1 zmenil súbory, kde vykonal 2 pridanie a 5 odobranie
  1. 2 5
      Libraries/LibJS/Runtime/VM.cpp

+ 2 - 5
Libraries/LibJS/Runtime/VM.cpp

@@ -105,9 +105,7 @@ void VM::gather_roots(HashTable<Cell*>& roots)
         roots.set(string);
 
     roots.set(m_scope_object_shape);
-
-    if (m_exception)
-        roots.set(m_exception);
+    roots.set(m_exception);
 
     if (m_last_value.is_cell())
         roots.set(m_last_value.as_cell());
@@ -115,8 +113,7 @@ void VM::gather_roots(HashTable<Cell*>& roots)
     for (auto& call_frame : m_call_stack) {
         if (call_frame->this_value.is_cell())
             roots.set(call_frame->this_value.as_cell());
-        if (call_frame->arguments_object)
-            roots.set(call_frame->arguments_object);
+        roots.set(call_frame->arguments_object);
         for (auto& argument : call_frame->arguments) {
             if (argument.is_cell())
                 roots.set(argument.as_cell());