Selaa lähdekoodia

LibPDF: Add two FIXMEs

Nico Weber 1 vuosi sitten
vanhempi
commit
2249e79630

+ 3 - 0
Userland/Libraries/LibPDF/Encoding.cpp

@@ -23,6 +23,9 @@ PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, No
         auto name = obj->cast<NameObject>()->name();
         if (name == "StandardEncoding")
             return standard_encoding();
+
+        // FIXME: MacExpertEncoding
+
         if (name == "MacRomanEncoding")
             return mac_encoding();
         if (name == "WinAnsiEncoding")

+ 1 - 0
Userland/Libraries/LibPDF/Fonts/CFF.cpp

@@ -388,6 +388,7 @@ PDFErrorOr<Vector<DeprecatedFlyString>> CFF::parse_charset(Reader&& reader, size
     auto resolve = [](SID sid) {
         if (sid < s_cff_builtin_names.size())
             return DeprecatedFlyString(s_cff_builtin_names[sid]);
+        // FIXME: Read from String INDEX instead.
         dbgln("Cound't find string for SID {}, going with space", sid);
         return DeprecatedFlyString("space");
     };