0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Unregister AnimationTimeline from document in finalize()

Browse source 
...instead of destructor because by the time it is executed, document
could already be destroyed.
This commit is contained in:
Aliaksandr Kalenik 2024-03-11 15:17:17 +01:00 • committed by Andreas Kling
parent bcdf4a375d
commit 2129c5d8b0
Notes: sideshowbarker 2024-07-17 02:55:44 +09:00
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Animations/AnimationTimeline.cpp
View file

@ -48,7 +48,7 @@ AnimationTimeline::AnimationTimeline(JS::Realm& realm)
{
}
AnimationTimeline::~AnimationTimeline()
void AnimationTimeline::finalize()
{
if (m_associated_document)
m_associated_document->disassociate_with_timeline(*this);

2
Userland/Libraries/LibWeb/Animations/AnimationTimeline.h
View file

@ -35,10 +35,10 @@ public:
protected:
AnimationTimeline(JS::Realm&);
virtual ~AnimationTimeline() override;
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;
// https://www.w3.org/TR/web-animations-1/#dom-animationtimeline-currenttime
Optional<double> m_current_time {};