Переглянути джерело

LibWeb: Remove FFC::cross_size_is_absolute_or_resolved_nicely()

This is now answered authoritatively by Layout::Box itself.
Andreas Kling 3 роки тому
батько
коміт
1dfb3d555c

+ 1 - 24
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp

@@ -245,30 +245,7 @@ bool FlexFormattingContext::has_cross_min_size(Box const& box) const
 
 bool FlexFormattingContext::has_definite_cross_size(Box const& box) const
 {
-    return (is_row_layout() ? box.has_definite_height() : box.has_definite_width()) && cross_size_is_absolute_or_resolved_nicely(box);
-}
-
-bool FlexFormattingContext::cross_size_is_absolute_or_resolved_nicely(NodeWithStyle const& box) const
-{
-    auto length_percentage = is_row_layout() ? box.computed_values().height() : box.computed_values().width();
-
-    if (!length_percentage.has_value())
-        return false;
-
-    // FIXME: Handle calc here.
-    if (length_percentage->is_length()) {
-        auto& length = length_percentage->length();
-        if (length.is_absolute() || length.is_relative())
-            return true;
-        if (length.is_auto())
-            return false;
-    }
-
-    if (!box.parent())
-        return false;
-    if (length_percentage->is_percentage() && cross_size_is_absolute_or_resolved_nicely(*box.parent()))
-        return true;
-    return false;
+    return is_row_layout() ? box.has_definite_height() : box.has_definite_width();
 }
 
 float FlexFormattingContext::specified_main_size_of_child_box(Box const& child_box) const

+ 0 - 1
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.h

@@ -61,7 +61,6 @@ private:
     float specified_cross_size(Box const&) const;
     bool has_main_min_size(Box const&) const;
     bool has_cross_min_size(Box const&) const;
-    bool cross_size_is_absolute_or_resolved_nicely(NodeWithStyle const&) const;
     float specified_main_max_size(Box const&) const;
     float specified_cross_max_size(Box const&) const;
     float calculated_main_size(Box const&) const;