0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibJS: Add length parameter to Array::create()

Browse source 
This is now a bit closer to the spec's 10.4.2.2 ArrayCreate - it will
throw a RangeError if the requested length exceeds 2^32 - 1, so anyone
passing in a custom value (defaults to zero for same behaviour as
before) will need an exception check at the call site.
This commit is contained in:
Linus Groh 2021-06-06 23:25:33 +01:00
parent e7bfd34ea7
commit 1c906b07a4
Notes: sideshowbarker 2024-07-18 12:43:42 +09:00
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Runtime/Array.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020-2021, Linus Groh <linusg@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -11,9 +12,17 @@
namespace JS {
Array* Array::create(GlobalObject& global_object)
// 10.4.2.2 ArrayCreate, https://tc39.es/ecma262/#sec-arraycreate
Array* Array::create(GlobalObject& global_object, size_t length)
{
return global_object.heap().allocate<Array>(global_object, *global_object.array_prototype());
if (length > NumericLimits<u32>::max()) {
auto& vm = global_object.vm();
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "array");
return nullptr;
}
auto* array = global_object.heap().allocate<Array>(global_object, *global_object.array_prototype());
array->indexed_properties().set_array_like_size(length);
return array;
}
// 7.3.17 CreateArrayFromList, https://tc39.es/ecma262/#sec-createarrayfromlist

2
Userland/Libraries/LibJS/Runtime/Array.h
View file

@ -14,7 +14,7 @@ class Array : public Object {
JS_OBJECT(Array, Object);
public:
static Array* create(GlobalObject&);
static Array* create(GlobalObject&, size_t length = 0);
static Array* create_from(GlobalObject&, const Vector<Value>&);
explicit Array(Object& prototype);