0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Don't check containing block of fragments in hit testing

Browse source 
We do not rely on existence of containing block in
`PaintableWithLines::hit_test()` so it should be safe to remove this
check.
This commit is contained in:
Aliaksandr Kalenik 2024-01-25 17:42:37 +01:00 • committed by Andreas Kling
parent 270bbf43ab
commit 1c4ce2c5f1
Notes: sideshowbarker 2024-07-16 21:39:23 +09:00
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -754,10 +754,6 @@ Optional<HitTestResult> PaintableWithLines::hit_test(CSSPixelPoint position, Hit
for (auto const& fragment : fragments()) {
if (fragment.paintable().stacking_context())
continue;
if (!fragment.paintable().containing_block()) {
dbgln("FIXME: PaintableWithLines::hit_test(): Missing containing block on {}", fragment.layout_node().debug_description());
continue;
}
auto fragment_absolute_rect = fragment.absolute_rect();
if (fragment_absolute_rect.contains(position)) {
if (auto result = fragment.paintable().hit_test(position, type); result.has_value())