瀏覽代碼

LibWeb: Allow border="0" on HTMLObjectElement

Andreas Kling 7 月之前
父節點
當前提交
1b4763f75f

+ 1 - 1
Libraries/LibWeb/HTML/HTMLObjectElement.cpp

@@ -88,7 +88,7 @@ void HTMLObjectElement::apply_presentational_hints(CSS::StyleProperties& style)
             else if (value.equals_ignoring_ascii_case("middle"sv))
                 style.set_property(CSS::PropertyID::TextAlign, CSS::CSSKeywordValue::create(CSS::Keyword::Middle));
         } else if (name == HTML::AttributeNames::border) {
-            if (auto parsed_value = parse_non_negative_integer(value); parsed_value.has_value() && *parsed_value > 0) {
+            if (auto parsed_value = parse_non_negative_integer(value); parsed_value.has_value()) {
                 auto width_style_value = CSS::LengthStyleValue::create(CSS::Length::make_px(*parsed_value));
                 style.set_property(CSS::PropertyID::BorderTopWidth, width_style_value);
                 style.set_property(CSS::PropertyID::BorderRightWidth, width_style_value);

+ 13 - 14
Tests/LibWeb/Text/expected/wpt-import/html/rendering/pixel-length-attributes.txt

@@ -6,8 +6,7 @@ Rerun
 
 Found 588 tests
 
-576 Pass
-12 Fail
+588 Pass
 Details
 Result	Test Name	MessagePass	<iframe marginwidth="200"> mapping to marginLeft	
 Pass	<iframe marginwidth="1007"> mapping to marginLeft	
@@ -435,9 +434,9 @@ Pass	<object border=" 00523 "> mapping to borderTopWidth
 Pass	<object border="200."> mapping to borderTopWidth	
 Pass	<object border="200.25"> mapping to borderTopWidth	
 Pass	<object border="200.7"> mapping to borderTopWidth	
-Fail	<object border="0"> mapping to borderTopWidth	
-Fail	<object border="-0"> mapping to borderTopWidth	
-Fail	<object border="+0"> mapping to borderTopWidth	
+Pass	<object border="0"> mapping to borderTopWidth	
+Pass	<object border="-0"> mapping to borderTopWidth	
+Pass	<object border="+0"> mapping to borderTopWidth	
 Pass	<object border="+200"> mapping to borderTopWidth	
 Pass	<object border="200in"> mapping to borderTopWidth	
 Pass	<object border="200.25in"> mapping to borderTopWidth	
@@ -456,9 +455,9 @@ Pass	<object border=" 00523 "> mapping to borderRightWidth
 Pass	<object border="200."> mapping to borderRightWidth	
 Pass	<object border="200.25"> mapping to borderRightWidth	
 Pass	<object border="200.7"> mapping to borderRightWidth	
-Fail	<object border="0"> mapping to borderRightWidth	
-Fail	<object border="-0"> mapping to borderRightWidth	
-Fail	<object border="+0"> mapping to borderRightWidth	
+Pass	<object border="0"> mapping to borderRightWidth	
+Pass	<object border="-0"> mapping to borderRightWidth	
+Pass	<object border="+0"> mapping to borderRightWidth	
 Pass	<object border="+200"> mapping to borderRightWidth	
 Pass	<object border="200in"> mapping to borderRightWidth	
 Pass	<object border="200.25in"> mapping to borderRightWidth	
@@ -477,9 +476,9 @@ Pass	<object border=" 00523 "> mapping to borderBottomWidth
 Pass	<object border="200."> mapping to borderBottomWidth	
 Pass	<object border="200.25"> mapping to borderBottomWidth	
 Pass	<object border="200.7"> mapping to borderBottomWidth	
-Fail	<object border="0"> mapping to borderBottomWidth	
-Fail	<object border="-0"> mapping to borderBottomWidth	
-Fail	<object border="+0"> mapping to borderBottomWidth	
+Pass	<object border="0"> mapping to borderBottomWidth	
+Pass	<object border="-0"> mapping to borderBottomWidth	
+Pass	<object border="+0"> mapping to borderBottomWidth	
 Pass	<object border="+200"> mapping to borderBottomWidth	
 Pass	<object border="200in"> mapping to borderBottomWidth	
 Pass	<object border="200.25in"> mapping to borderBottomWidth	
@@ -498,9 +497,9 @@ Pass	<object border=" 00523 "> mapping to borderLeftWidth
 Pass	<object border="200."> mapping to borderLeftWidth	
 Pass	<object border="200.25"> mapping to borderLeftWidth	
 Pass	<object border="200.7"> mapping to borderLeftWidth	
-Fail	<object border="0"> mapping to borderLeftWidth	
-Fail	<object border="-0"> mapping to borderLeftWidth	
-Fail	<object border="+0"> mapping to borderLeftWidth	
+Pass	<object border="0"> mapping to borderLeftWidth	
+Pass	<object border="-0"> mapping to borderLeftWidth	
+Pass	<object border="+0"> mapping to borderLeftWidth	
 Pass	<object border="+200"> mapping to borderLeftWidth	
 Pass	<object border="200in"> mapping to borderLeftWidth	
 Pass	<object border="200.25in"> mapping to borderLeftWidth