0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 05:20:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Ladybird: Add a context menu for video elements

Browse source
This commit is contained in:
Timothy Flynn 2023-05-15 12:27:10 -04:00 committed by Andreas Kling
parent a0e31bf1de
commit 1b2394d92e
Notes: sideshowbarker 2024-07-17 09:56:35 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/1b2394d92e
Pull-request: https://github.com/SerenityOS/serenity/pull/18859
3 changed files with 101 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/BrowserWindow.cpp
View file

@ -418,6 +418,8 @@ Tab& BrowserWindow::new_tab(QString const& url, Web::HTML::ActivateTab activate_
m_current_tab->view().on_tab_open_request(url, Web::HTML::ActivateTab::No);
} else if (target == "_blank") {
m_current_tab->view().on_tab_open_request(url, Web::HTML::ActivateTab::Yes);
} else {
m_current_tab->view().load(url);
}
};

87
Ladybird/Tab.cpp
View file

@ -10,9 +10,11 @@
#include "Settings.h"
#include "Utilities.h"
#include <Browser/History.h>
#include <QClipboard>
#include <QCoreApplication>
#include <QFont>
#include <QFontMetrics>
#include <QGuiApplication>
#include <QMenu>
#include <QPainter>
#include <QPlainTextEdit>
@ -194,6 +196,75 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_page_context_menu->exec(screen_position);
};
m_video_context_menu_play_icon = make<QIcon>(QString("%1/res/icons/16x16/play.png").arg(s_serenity_resource_root.characters()));
m_video_context_menu_pause_icon = make<QIcon>(QString("%1/res/icons/16x16/pause.png").arg(s_serenity_resource_root.characters()));
m_video_context_menu_play_pause_action = make<QAction>("&Play", this);
m_video_context_menu_play_pause_action->setIcon(*m_video_context_menu_play_icon);
QObject::connect(m_video_context_menu_play_pause_action, &QAction::triggered, this, [this]() {
view().toggle_video_play_state();
});
m_video_context_menu_controls_action = make<QAction>("Show &Controls", this);
m_video_context_menu_controls_action->setCheckable(true);
QObject::connect(m_video_context_menu_controls_action, &QAction::triggered, this, [this]() {
view().toggle_video_controls_state();
});
m_video_context_menu_loop_action = make<QAction>("&Loop Video", this);
m_video_context_menu_loop_action->setCheckable(true);
QObject::connect(m_video_context_menu_loop_action, &QAction::triggered, this, [this]() {
view().toggle_video_loop_state();
});
auto* open_video_action = new QAction("&Open Video", this);
open_video_action->setIcon(QIcon(QString("%1/res/icons/16x16/filetype-video.png").arg(s_serenity_resource_root.characters())));
QObject::connect(open_video_action, &QAction::triggered, this, [this]() {
open_link(m_video_context_menu_url);
});
auto* open_video_in_new_tab_action = new QAction("Open Video in New &Tab", this);
open_video_in_new_tab_action->setIcon(QIcon(QString("%1/res/icons/16x16/new-tab.png").arg(s_serenity_resource_root.characters())));
QObject::connect(open_video_in_new_tab_action, &QAction::triggered, this, [this]() {
open_link_in_new_tab(m_video_context_menu_url);
});
auto* copy_video_url_action = new QAction("Copy Video &URL", this);
copy_video_url_action->setIcon(QIcon(QString("%1/res/icons/16x16/edit-copy.png").arg(s_serenity_resource_root.characters())));
QObject::connect(copy_video_url_action, &QAction::triggered, this, [this]() {
copy_link_url(m_video_context_menu_url);
});
m_video_context_menu = make<QMenu>("Video context menu", this);
m_video_context_menu->addAction(m_video_context_menu_play_pause_action);
m_video_context_menu->addAction(m_video_context_menu_controls_action);
m_video_context_menu->addAction(m_video_context_menu_loop_action);
m_video_context_menu->addSeparator();
m_video_context_menu->addAction(open_video_action);
m_video_context_menu->addAction(open_video_in_new_tab_action);
m_video_context_menu->addSeparator();
m_video_context_menu->addAction(copy_video_url_action);
m_video_context_menu->addSeparator();
m_video_context_menu->addAction(&m_window->inspect_dom_node_action());
view().on_video_context_menu_request = [this](auto const& video_url, auto widget_position, bool is_playing, bool has_user_agent_controls, bool is_looping) {
m_video_context_menu_url = video_url;
if (is_playing) {
m_video_context_menu_play_pause_action->setIcon(*m_video_context_menu_play_icon);
m_video_context_menu_play_pause_action->setText("&Play");
} else {
m_video_context_menu_play_pause_action->setIcon(*m_video_context_menu_pause_icon);
m_video_context_menu_play_pause_action->setText("&Pause");
}
m_video_context_menu_controls_action->setChecked(has_user_agent_controls);
m_video_context_menu_loop_action->setChecked(is_looping);
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_video_context_menu->exec(screen_position);
};
}
void Tab::update_reset_zoom_button()
@ -248,6 +319,22 @@ void Tab::reload()
view().load(m_history.current().url.to_deprecated_string());
}
void Tab::open_link(URL const& url)
{
view().on_link_click(url, "", 0);
}
void Tab::open_link_in_new_tab(URL const& url)
{
view().on_link_click(url, "_blank", 0);
}
void Tab::copy_link_url(URL const& url)
{
auto* clipboard = QGuiApplication::clipboard();
clipboard->setText(qstring_from_ak_deprecated_string(url.to_deprecated_string()));
}
void Tab::location_edit_return_pressed()
{
navigate(m_location_edit->text());

12
Ladybird/Tab.h
View file

@ -56,6 +56,10 @@ private:
void rerender_toolbar_icons();
void update_hover_label();
void open_link(URL const&);
void open_link_in_new_tab(URL const&);
void copy_link_url(URL const&);
QBoxLayout* m_layout;
QToolBar* m_toolbar { nullptr };
QToolButton* m_reset_zoom_button { nullptr };
@ -69,6 +73,14 @@ private:
OwnPtr<QMenu> m_page_context_menu;
OwnPtr<QMenu> m_video_context_menu;
OwnPtr<QIcon> m_video_context_menu_play_icon;
OwnPtr<QIcon> m_video_context_menu_pause_icon;
OwnPtr<QAction> m_video_context_menu_play_pause_action;
OwnPtr<QAction> m_video_context_menu_controls_action;
OwnPtr<QAction> m_video_context_menu_loop_action;
URL m_video_context_menu_url;
int tab_index();
bool m_is_history_navigation { false };