0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Use cached absolute rect and transform in refresh_clip_state()

Browse source 
Changes compute_absolute_padding_rect_with_css_transform_applied() to
use cached absolute rect and CSS transform instead of doing expensive
containing block chain traversal.

Reduces refresh_clip_state() from 4% to 2% in Discord profiles.
This commit is contained in:
Aliaksandr Kalenik 2024-04-28 15:21:24 +02:00 • committed by Andreas Kling
parent 872b6f626e
commit 15f69ffbba
Notes: sideshowbarker 2024-07-17 10:16:43 +09:00
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -145,16 +145,11 @@ CSSPixelRect PaintableBox::compute_absolute_rect() const
CSSPixelRect PaintableBox::compute_absolute_padding_rect_with_css_transform_applied() const
{
CSSPixelRect rect { offset(), content_size() };
for (auto const* block = containing_block(); block; block = block->containing_block()) {
auto offset = block->offset();
auto affine_transform = Gfx::extract_2d_affine_transform(block->transform());
offset.translate_by(affine_transform.translation().to_type<CSSPixels>());
offset.translate_by(-block->scroll_offset());
rect.translate_by(offset);
}
auto affine_transform = Gfx::extract_2d_affine_transform(transform());
rect.translate_by(affine_transform.translation().to_type<CSSPixels>());
auto rect = absolute_rect();
auto scroll_offset = this->enclosing_scroll_frame_offset();
if (scroll_offset.has_value())
rect.translate_by(scroll_offset.value());
rect.translate_by(combined_css_transform().translation().to_type<CSSPixels>());
CSSPixelRect padding_rect;
padding_rect.set_x(rect.x() - box_model().padding.left);