瀏覽代碼

LibJS: Remove the VERIFY_NOT_REACHED in link_and_eval_module

Since the spec does not fully define the entry points of modules what
this means is kind of unclear. But it does work in most cases and can
be useful. We do print out a warning just to clarify why there could be
strange things.
davidot 3 年之前
父節點
當前提交
14d1601a76
共有 1 個文件被更改,包括 3 次插入4 次删除
  1. 3 4
      Userland/Libraries/LibJS/Runtime/VM.cpp

+ 3 - 4
Userland/Libraries/LibJS/Runtime/VM.cpp

@@ -766,10 +766,9 @@ ThrowCompletionOr<void> VM::link_and_eval_module(Module& module)
 
     if (module_or_end.is_end()) {
         dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] Warning introducing module via link_and_eval_module {}", module.filename());
-        if (m_loaded_modules.size() > 0) {
-            dbgln("Using link_and_eval module as entry point is not allowed if it is not the first module!");
-            VERIFY_NOT_REACHED();
-        }
+        if (m_loaded_modules.size() > 0)
+            dbgln("Warning: Using multiple modules as entry point can lead to unexpected results");
+
         m_loaded_modules.empend(
             &module,
             module.filename(),