瀏覽代碼

Kernel: No need to use safe_memcpy() when handling an inode fault

We're copying the inode contents from a stack buffer into a page that
we just quick-mapped, so there's no reason for this memcpy() to fail.
Andreas Kling 4 年之前
父節點
當前提交
13a2e91fc5
共有 1 個文件被更改,包括 1 次插入12 次删除
  1. 1 12
      Kernel/VM/Region.cpp

+ 1 - 12
Kernel/VM/Region.cpp

@@ -562,18 +562,7 @@ PageFaultResponse Region::handle_inode_fault(size_t page_index_in_region)
     }
 
     u8* dest_ptr = MM.quickmap_page(*vmobject_physical_page_entry);
-    {
-        void* fault_at;
-        if (!safe_memcpy(dest_ptr, page_buffer, PAGE_SIZE, fault_at)) {
-            if ((u8*)fault_at >= dest_ptr && (u8*)fault_at <= dest_ptr + PAGE_SIZE)
-                dbgln("      >> inode fault: error copying data to {}/{}, failed at {}",
-                    vmobject_physical_page_entry->paddr(),
-                    VirtualAddress(dest_ptr),
-                    VirtualAddress(fault_at));
-            else
-                VERIFY_NOT_REACHED();
-        }
-    }
+    memcpy(dest_ptr, page_buffer, PAGE_SIZE);
     MM.unquickmap_page();
 
     remap_vmobject_page(page_index_in_vmobject);