Bläddra i källkod

LibHTTP: Remove attempt to read extra line after response headers

When LibHTTP encountered the blank line between the headers and the body
in a HTTP response it made a call the m_socket->can_read_line(). This
ultimately tried to find a newline in the stream. If the response body
was small and did not contain a new line then the request would hang.

The call to m_socket->can_read_line() is removed so that the code is
able to progress into the body reading loop.
Wesley Moore 3 år sedan
förälder
incheckning
12ff5c9bfd
1 ändrade filer med 0 tillägg och 6 borttagningar
  1. 0 6
      Userland/Libraries/LibHTTP/Job.cpp

+ 0 - 6
Userland/Libraries/LibHTTP/Job.cpp

@@ -316,12 +316,6 @@ void Job::on_socket_connected()
                 if (m_code == 204)
                     return finish_up();
 
-                can_read_line = m_socket->can_read_line();
-                if (can_read_line.is_error())
-                    return deferred_invoke([this] { did_fail(Core::NetworkJob::Error::TransmissionFailed); });
-
-                if (!can_read_line.value())
-                    return;
                 break;
             }
             auto parts = line.split_view(':');