Преглед на файлове

HackStudio: Don't save file when filename is empty

When saving a new file, save_as_action will return if the filename
input was empty, but save_action would still try to save the file.
Added a guard to make sure we never try to save files with empty
filenames.
Daste преди 3 години
родител
ревизия
11c53a1944
променени са 1 файла, в които са добавени 3 реда и са изтрити 1 реда
  1. 3 1
      Userland/DevTools/HackStudio/HackStudioWidget.cpp

+ 3 - 1
Userland/DevTools/HackStudio/HackStudioWidget.cpp

@@ -695,7 +695,9 @@ NonnullRefPtr<GUI::Action> HackStudioWidget::create_save_action()
         if (active_file().is_empty())
             m_save_as_action->activate();
 
-        current_editor_wrapper().save();
+        // NOTE active_file() could still be empty after a cancelled save_as_action
+        if (!active_file().is_empty())
+            current_editor_wrapper().save();
 
         if (m_git_widget->initialized())
             m_git_widget->refresh();