ソースを参照

Libraries: Use default constructors/destructors in LibCards

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
Lenny Maiorani 3 年 前
コミット
11b28c88fc

+ 0 - 4
Userland/Libraries/LibCards/Card.cpp

@@ -139,10 +139,6 @@ Card::Card(Type type, uint8_t value)
     m_front_inverted = invert_bitmap(*m_front);
 }
 
-Card::~Card()
-{
-}
-
 void Card::draw(GUI::Painter& painter) const
 {
     VERIFY(!s_background.is_null());

+ 2 - 1
Userland/Libraries/LibCards/Card.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Till Mayer <till.mayer@web.de>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -36,7 +37,7 @@ public:
         __Count
     };
 
-    virtual ~Card() override;
+    virtual ~Card() override = default;
 
     Gfx::IntRect& rect() { return m_rect; }
     Gfx::IntPoint position() const { return m_rect.location(); }