WebContent: Return empty JSON object if element has no box model

The blank string "" does not parse as JSON, and so the InspectorWidget would fail to update the box-model information when inspecting elements with no box, (for example, `<head>`) showing stale values instead. Now, they show all 0s. You could argue that InspectorWidget should be more resilient when given invalid JSON strings, but making sure we only pass valid ones works too.
Author: https://github.com/AtkinsSJ Commit: https://github.com/SerenityOS/serenity/commit/10429e1043 Pull-request: https://github.com/SerenityOS/serenity/pull/12873
2022-03-10 11:29:09 +00:00 · 2022-03-10 11:29:09 +00:00 · 10429e1043 · 2024-07-17 17:37:24 +09:00
commit 10429e1043
parent b5ea14b884
1 changed files with 1 additions and 1 deletions
--- a/Userland/Services/WebContent/ConnectionFromClient.cpp
+++ b/Userland/Services/WebContent/ConnectionFromClient.cpp
@ -304,7 +304,7 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
        };
        auto serialize_node_box_sizing_json = [](Web::Layout::Node const* layout_node) -> String {
            if (!layout_node || !layout_node->is_box()) {
-                return "";
+                return "{}";
            }
            auto* box = static_cast<Web::Layout::Box const*>(layout_node);
            auto box_model = box->box_model();