0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

SoundPlayer: Fix file leak in M3UParser::from_file(..)

Browse source 
Found by Sonar Cloud.
This commit is contained in:
Brian Gianforcaro 2021-09-01 00:41:32 -07:00 • committed by Andreas Kling
parent afa0fb55b0
commit 0bd089b282
Notes: sideshowbarker 2024-07-18 04:56:17 +09:00
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/SoundPlayer/M3UParser.cpp
View file

@ -7,6 +7,7 @@
#include "M3UParser.h"
#include <AK/OwnPtr.h>
#include <AK/RefPtr.h>
#include <AK/ScopeGuard.h>
#include <AK/Utf8View.h>
M3UParser::M3UParser()
@ -19,6 +20,7 @@ NonnullOwnPtr<M3UParser> M3UParser::from_file(const String path)
VERIFY(!path.is_null() && !path.is_empty() && !path.is_whitespace());
parser->m_use_utf8 = path.ends_with(".m3u8", AK::CaseSensitivity::CaseInsensitive);
FILE* file = fopen(path.characters(), "r");
ScopeGuard file_guard = [&] { fclose(file); };
VERIFY(file != nullptr);
fseek(file, 0, SEEK_END);
size_t file_size = ftell(file);