0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-15 10:50:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Fix int parsing in Element::tab_index

Browse source 
We now have functions for parsing integers in a spec-compliant way. This
patch replaces the `to_int` call with a call to the spec-compliant
`Web::HTML::parse_integer` function.
This commit is contained in:
Jonatan Klemets 2023-08-30 20:43:25 +03:00 committed by Luke Wilde
parent acd46b5974
commit 0adda642a6
Notes: sideshowbarker 2024-07-17 02:29:45 +09:00 
Author: https://github.com/Jon4t4n
Commit: https://github.com/SerenityOS/serenity/commit/0adda642a6
Pull-request: https://github.com/SerenityOS/serenity/pull/20856
Reviewed-by: https://github.com/Lubrsi ✅
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -47,6 +47,7 @@
#include <LibWeb/HTML/HTMLSelectElement.h> #include <LibWeb/HTML/HTMLSelectElement.h>
#include <LibWeb/HTML/HTMLStyleElement.h> #include <LibWeb/HTML/HTMLStyleElement.h>
#include <LibWeb/HTML/HTMLTextAreaElement.h> #include <LibWeb/HTML/HTMLTextAreaElement.h>
#include <LibWeb/HTML/Numbers.h>
#include <LibWeb/HTML/Parser/HTMLParser.h> #include <LibWeb/HTML/Parser/HTMLParser.h>
#include <LibWeb/HTML/Window.h> #include <LibWeb/HTML/Window.h>
#include <LibWeb/Infra/CharacterTypes.h> #include <LibWeb/Infra/CharacterTypes.h>
@ -903,8 +904,8 @@ i32 Element::default_tab_index_value() const
// https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex // https://html.spec.whatwg.org/multipage/interaction.html#dom-tabindex
i32 Element::tab_index() const i32 Element::tab_index() const
{ {
// FIXME: I'm not sure if "to_int" exactly matches the specs "rules for parsing integers" auto maybe_table_index = Web::HTML::parse_integer(attribute(HTML::AttributeNames::tabindex));
auto maybe_table_index = attribute(HTML::AttributeNames::tabindex).to_int<i32>();
if (!maybe_table_index.has_value()) if (!maybe_table_index.has_value())
return default_tab_index_value(); return default_tab_index_value();
return maybe_table_index.value(); return maybe_table_index.value();