소스 검색

LibGUI: Convert ItemListModel's Display Role to string during search

Previously, you could get crashes when you tried to search for a font
size in the Font Picker or a screen resolution in Display Settings.

This is because their list models aren't made of strings
and Variant::as_string() only accepts strings.
Karol Kosek 3 년 전
부모
커밋
097902bd06
1개의 변경된 파일2개의 추가작업 그리고 2개의 파일을 삭제
  1. 2 2
      Userland/Libraries/LibGUI/ItemListModel.h

+ 2 - 2
Userland/Libraries/LibGUI/ItemListModel.h

@@ -85,7 +85,7 @@ public:
             for (auto it = m_data.begin(); it != m_data.end(); ++it) {
                 for (auto it2d = (*it).begin(); it2d != (*it).end(); ++it2d) {
                     GUI::ModelIndex index = this->index(it.index(), it2d.index());
-                    if (!string_matches(data(index, ModelRole::Display).as_string(), searching, flags))
+                    if (!string_matches(data(index, ModelRole::Display).to_string(), searching, flags))
                         continue;
 
                     found_indices.append(index);
@@ -96,7 +96,7 @@ public:
         } else {
             for (auto it = m_data.begin(); it != m_data.end(); ++it) {
                 GUI::ModelIndex index = this->index(it.index());
-                if (!string_matches(data(index, ModelRole::Display).as_string(), searching, flags))
+                if (!string_matches(data(index, ModelRole::Display).to_string(), searching, flags))
                     continue;
 
                 found_indices.append(index);