We use cookies to ensure you get the best experience on our website
Trang chủ Khám phá Trợ giúp
Đăng ký Đăng nhập
0ct0pu5
/
ladybird
1
0
Fork 0
Các tập tin Các vấn đề 0 Yêu cầu kéo về 0 Wiki
Browse Source

LibWeb: Fix inline-block percentage height calculation

If an inline-block has a percentage height that relies on the auto
height of the containing block, it should always resolve to the
automatic height of the box, regardless of the percentage value. This
change may seem confusing, but it aligns with the behavior of other
engines.
Aliaksandr Kalenik 2 năm trước cách đây
mục cha
4e911cb40e
commit
07f451044b
3 tập tin đã thay đổi với 24 bổ sung và 1 xóa
View chưa được định nghĩa Hiển thị tình trạng sai khác
  1. 11 0
      Tests/LibWeb/Layout/expected/block-and-inline/inline-block-with-percentage-height-and-auto-height-of-containing-block.txt
  2. 12 0
      Tests/LibWeb/Layout/input/block-and-inline/inline-block-with-percentage-height-and-auto-height-of-containing-block.html
  3. 1 1
      Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp

+ 11 - 0
Tests/LibWeb/Layout/expected/block-and-inline/inline-block-with-percentage-height-and-auto-height-of-containing-block.txt
Xem Tập Tin 

@@ -0,0 +1,11 @@
 
+Viewport <#document> at (0,0) content-size 800x600 children: not-inline
 
+  BlockContainer <html> at (0,0) content-size 800x33.46875 [BFC] children: not-inline
 
+    BlockContainer <body> at (8,8) content-size 784x17.46875 children: not-inline
 
+      BlockContainer <div.pure-menu-list> at (8,8) content-size 784x17.46875 children: inline
 
+        line 0 width: 36.453125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
 
+          frag 0 from BlockContainer start: 0, length: 0, rect: [8,8 36.453125x17.46875]
 
+        BlockContainer <div.pure-menu-item> at (8,8) content-size 36.453125x17.46875 inline-block [BFC] children: inline
 
+          line 0 width: 36.453125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
 
+            frag 0 from TextNode start: 0, length: 4, rect: [8,8 36.453125x17.46875]
 
+              "docs"
 
+          TextNode <#text>

+ 12 - 0
Tests/LibWeb/Layout/input/block-and-inline/inline-block-with-percentage-height-and-auto-height-of-containing-block.html
Xem Tập Tin 

@@ -0,0 +1,12 @@
 
+<!DOCTYPE html>
 
+<style>
 
+    .pure-menu-list {
 
+        background-color: blueviolet;
 
+    }
 
+    .pure-menu-item {
 
+        display: inline-block;
 
+        background-color: chartreuse;
 
+        height: 5%;
 
+    }
 
+</style>
 
+<div class="pure-menu-list"><div class="pure-menu-item">docs</div></div>

+ 1 - 1
Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp
Xem Tập Tin 

@@ -165,7 +165,7 @@ void InlineFormattingContext::dimension_box_on_line(Box const& box, LayoutMode l
 
     auto independent_formatting_context = layout_inside(box, layout_mode, box_state.available_inner_space_or_constraints_from(*m_available_space));
 
     auto independent_formatting_context = layout_inside(box, layout_mode, box_state.available_inner_space_or_constraints_from(*m_available_space));
 
 
 
     auto const& height_value = box.computed_values().height();
 
     auto const& height_value = box.computed_values().height();
 
-    if (height_value.is_auto()) {
 
+    if (should_treat_height_as_auto(box, *m_available_space)) {
 
         // FIXME: (10.6.6) If 'height' is 'auto', the height depends on the element's descendants per 10.6.7.
 
         // FIXME: (10.6.6) If 'height' is 'auto', the height depends on the element's descendants per 10.6.7.
 
         parent().compute_height(box, AvailableSpace(AvailableSize::make_indefinite(), AvailableSize::make_indefinite()));
 
         parent().compute_height(box, AvailableSpace(AvailableSize::make_indefinite(), AvailableSize::make_indefinite()));
 
     } else {
 
     } else {

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5