0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibWeb: Handle cases with <template> on the HTML parsing stack

Browse source 
This appears to have been a bug in the spec which was later corrected -
so to fix the crash we can simply remove this assertion.

Fixes: #868
This commit is contained in:
Shannon Booth 2024-08-17 04:55:02 +12:00 • committed by Tim Ledbetter
parent 0d63269cb7
commit 07940a89ca
Notes: github-actions[bot] 2024-08-16 21:39:13 +00:00
3 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibWeb/Layout/expected/crash-tests/html-with-only-a-template-tag.txt Normal file
View file

@ -0,0 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x16]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0]

2
Tests/LibWeb/Layout/input/crash-tests/html-with-only-a-template-tag.html Normal file
View file

@ -0,0 +1,2 @@
<!DOCTYPE html>
<template><body>

4
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -1748,11 +1748,11 @@ void HTMLParser::handle_in_body(HTMLToken& token)
log_parse_error();
// If the stack of open elements has only one node on it, if the second element on the stack of open elements is not a body element,
// or if there is a template element on the stack of open elements, then ignore the token. (fragment case)
// or if there is a template element on the stack of open elements, then ignore the token.
// (fragment case or there is a template element on the stack)
if (m_stack_of_open_elements.elements().size() == 1
|| m_stack_of_open_elements.elements().at(1)->local_name() != HTML::TagNames::body
|| m_stack_of_open_elements.contains(HTML::TagNames::template_)) {
VERIFY(m_parsing_fragment);
return;
}