0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Kernel: Return EPIPE when trying to write to an unconnected socket

Browse source 
When attempting to write to a socket that is not connected or - for
connection-less protocols - doesn't have a peer address set we should
return EPIPE instead of blocking the thread.
This commit is contained in:
Gunnar Beutner 2021-06-05 13:03:06 +02:00 • committed by Andreas Kling
parent 51c2c69357
commit 0625342382
Notes: sideshowbarker 2024-07-18 22:57:59 +09:00
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Net/IPv4Socket.cpp
View file

@ -170,7 +170,7 @@ bool IPv4Socket::can_read(const FileDescription&, size_t) const
bool IPv4Socket::can_write(const FileDescription&, size_t) const bool IPv4Socket::can_write(const FileDescription&, size_t) const
{ {
return is_connected(); return true;
} }
PortAllocationResult IPv4Socket::allocate_local_port_if_needed() PortAllocationResult IPv4Socket::allocate_local_port_if_needed()
@ -206,6 +206,9 @@ KResultOr<size_t> IPv4Socket::sendto(FileDescription&, const UserOrKernelBuffer&
m_peer_port = ntohs(ia.sin_port); m_peer_port = ntohs(ia.sin_port);
} }
if (!is_connected() && m_peer_address.is_zero())
return EPIPE;
auto routing_decision = route_to(m_peer_address, m_local_address, bound_interface()); auto routing_decision = route_to(m_peer_address, m_local_address, bound_interface());
if (routing_decision.is_zero()) if (routing_decision.is_zero())
return EHOSTUNREACH; return EHOSTUNREACH;