0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-11 08:50:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

GMLCompiler: Allow generating enum constants from strings

Browse source 
As with other special cases, this depends on the property name.

The UIDimension code is kept separate since it can handle both integers
and strings, and the string names for special dimensions don't match
with the enum names.
This commit is contained in:
kleines Filmröllchen 2023-05-26 12:41:54 +02:00 committed by Andrew Kaster
parent cc6b9d5873
commit 04a4f6a2e8
Notes: sideshowbarker 2024-07-17 04:34:25 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/04a4f6a2e8
Pull-request: https://github.com/SerenityOS/serenity/pull/20523
Reviewed-by: https://github.com/ADKaster
1 changed files with 27 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Meta/Lagom/Tools/CodeGenerators/GMLCompiler/main.cpp
View file

@ -154,12 +154,37 @@ static ErrorOr<String> escape_string(JsonValue to_escape)
return string;
}
// This function assumes that the string is already the same as its enum constant's name.
// Therefore, it does not handle UI dimensions.
static ErrorOr<Optional<String>> generate_enum_initializer_for(StringView property_name, JsonValue value)
{
// The value is the enum's type name.
static HashMap<StringView, StringView> enum_properties = {
{ "text_alignment"sv, "Gfx::TextAlignment"sv },
{ "focus_policy"sv, "GUI::FocusPolicy"sv },
{ "foreground_role"sv, "Gfx::ColorRole"sv },
{ "text_wrapping"sv, "Gfx::TextWrapping"sv },
};
auto const& enum_type_name = enum_properties.get(property_name);
if (!enum_type_name.has_value())
return Optional<String> {};
return String::formatted("{}::{}", *enum_type_name, value.as_string());
}
// FIXME: In case of error, propagate the precise array+property that triggered the error.
static ErrorOr<String> generate_initializer_for(Optional<StringView> property_name, JsonValue value)
{
if (value.is_string()) {
if (property_name.has_value() && takes_deprecated_string(*property_name))
return String::formatted(R"~~~("{}"sv)~~~", TRY(escape_string(value)));
if (property_name.has_value()) {
if (takes_deprecated_string(*property_name))
return String::formatted(R"~~~("{}"sv)~~~", TRY(escape_string(value)));
if (auto const enum_value = TRY(generate_enum_initializer_for(*property_name, value)); enum_value.has_value())
return String::formatted("{}", *enum_value);
}
return String::formatted(R"~~~("{}"_string)~~~", TRY(escape_string(value)));
}
// No need to handle the smaller integer types separately.