0ct0pu5/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

LibC: Use dbgln() in strerror() and strsignal()

Browse source 
Printing error messages to stdout can have unintended side effects
depending on what the program is doing.
This commit is contained in:
Gunnar Beutner 2021-04-12 18:29:36 +02:00 • committed by Andreas Kling
parent 44486e8818
commit 0497986572
Notes: sideshowbarker 2024-07-18 20:27:59 +09:00
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibC/string.cpp
View file

@ -24,6 +24,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include <AK/Format.h>
#include <AK/MemMem.h> #include <AK/MemMem.h>
#include <AK/Platform.h> #include <AK/Platform.h>
#include <AK/StdLibExtras.h> #include <AK/StdLibExtras.h>
@ -376,7 +377,7 @@ int sys_nerr = EMAXERRNO;
char* strerror(int errnum) char* strerror(int errnum)
{ {
if (errnum < 0 || errnum >= EMAXERRNO) { if (errnum < 0 || errnum >= EMAXERRNO) {
printf("strerror() missing string for errnum=%d\n", errnum); dbgln("strerror() missing string for errnum={}", errnum);
return const_cast<char*>("Unknown error"); return const_cast<char*>("Unknown error");
} }
return const_cast<char*>(sys_errlist[errnum]); return const_cast<char*>(sys_errlist[errnum]);
@ -385,7 +386,7 @@ char* strerror(int errnum)
char* strsignal(int signum) char* strsignal(int signum)
{ {
if (signum >= NSIG) { if (signum >= NSIG) {
printf("strsignal() missing string for signum=%d\n", signum); dbgln("strsignal() missing string for signum={}", signum);
return const_cast<char*>("Unknown signal"); return const_cast<char*>("Unknown signal");
} }
return const_cast<char*>(sys_siglist[signum]); return const_cast<char*>(sys_siglist[signum]);