瀏覽代碼

LibSQL: Remove superfluous `VERIFY`s for `Vector` accessing

Remove some `[]` operators' out-of-bounds checks which are already
performed by the underlying `Vector`.
Jelle Raaijmakers 2 年之前
父節點
當前提交
0460a654d4

+ 1 - 1
Userland/Libraries/LibSQL/BTree.h

@@ -67,7 +67,7 @@ public:
     [[nodiscard]] TreeNode* down_node(size_t);
     [[nodiscard]] bool is_leaf() const { return m_is_leaf; }
 
-    Key const& operator[](size_t) const;
+    Key const& operator[](size_t index) const { return m_entries[index]; }
     bool insert(Key const&);
     bool update_key_pointer(Key const&);
     TreeNode* node_for(Key const&);

+ 0 - 8
Userland/Libraries/LibSQL/TreeNode.cpp

@@ -197,21 +197,13 @@ bool TreeNode::insert_in_leaf(Key const& key)
     return true;
 }
 
-Key const& TreeNode::operator[](size_t ix) const
-{
-    VERIFY(ix < size());
-    return m_entries[ix];
-}
-
 u32 TreeNode::down_pointer(size_t ix) const
 {
-    VERIFY(ix < m_down.size());
     return m_down[ix].pointer();
 }
 
 TreeNode* TreeNode::down_node(size_t ix)
 {
-    VERIFY(ix < m_down.size());
     return m_down[ix].node();
 }
 

+ 0 - 12
Userland/Libraries/LibSQL/Tuple.cpp

@@ -91,18 +91,6 @@ Optional<size_t> Tuple::index_of(String name) const
     return {};
 }
 
-Value const& Tuple::operator[](size_t ix) const
-{
-    VERIFY(ix < m_data.size());
-    return m_data[ix];
-}
-
-Value& Tuple::operator[](size_t ix)
-{
-    VERIFY(ix < m_data.size());
-    return m_data[ix];
-}
-
 Value const& Tuple::operator[](String const& name) const
 {
     auto index = index_of(name);

+ 2 - 2
Userland/Libraries/LibSQL/Tuple.h

@@ -49,8 +49,8 @@ public:
     [[nodiscard]] bool is_null() const { return m_data.is_empty(); }
     [[nodiscard]] bool has(String const& name) const { return index_of(name).has_value(); }
 
-    Value const& operator[](size_t ix) const;
-    Value& operator[](size_t ix);
+    Value const& operator[](size_t ix) const { return m_data[ix]; }
+    Value& operator[](size_t ix) { return m_data[ix]; }
     Value const& operator[](String const& name) const;
     Value& operator[](String const& name);
     void append(Value const&);