LibWebView: Use the download directory facility for saving files

Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/03f99150549
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1219

Userland/Libraries/LibWebView/InspectorClient.cpp

@@ -12,9 +12,9 @@
 #include <LibCore/Directory.h>
 #include <LibCore/File.h>
 #include <LibCore/Resource.h>
-#include <LibCore/StandardPaths.h>
 #include <LibJS/MarkupGenerator.h>
 #include <LibWeb/Infra/Strings.h>
+#include <LibWebView/Application.h>
 #include <LibWebView/InspectorClient.h>
 #include <LibWebView/SourceHighlighter.h>
 
@@ -220,9 +220,16 @@ InspectorClient::InspectorClient(ViewImplementation& content_web_view, ViewImple
     };
 
     m_inspector_web_view.on_inspector_exported_inspector_html = [this](String const& html) {
-        auto inspector_path = LexicalPath::join(Core::StandardPaths::downloads_directory(), "inspector"sv);
+        auto maybe_inspector_path = Application::the().path_for_downloaded_file("inspector"sv);
 
-        if (auto result = Core::Directory::create(inspector_path, Core::Directory::CreateDirectories::Yes); result.is_error()) {
+        if (maybe_inspector_path.is_error()) {
+            append_console_warning(MUST(String::formatted("Unable to select a download location: {}", maybe_inspector_path.error())));
+            return;
+        }
+
+        auto inspector_path = maybe_inspector_path.release_value();
+
+        if (auto result = Core::Directory::create(inspector_path.string(), Core::Directory::CreateDirectories::Yes); result.is_error()) {
             append_console_warning(MUST(String::formatted("Unable to create {}: {}", inspector_path, result.error())));
             return;
         }

Userland/Libraries/LibWebView/ViewImplementation.cpp

@@ -11,6 +11,7 @@
 #include <LibCore/Timer.h>
 #include <LibGfx/ImageFormats/PNGWriter.h>
 #include <LibWeb/Infra/Strings.h>
+#include <LibWebView/Application.h>
 #include <LibWebView/ViewImplementation.h>
 
 #ifdef AK_OS_MACOS
@@ -510,8 +511,8 @@ static ErrorOr<LexicalPath> save_screenshot(Gfx::ShareableBitmap const& bitmap)
     if (!bitmap.is_valid())
         return Error::from_string_view("Failed to take a screenshot"sv);
 
-    LexicalPath path { Core::StandardPaths::downloads_directory() };
-    path = path.append(TRY(Core::DateTime::now().to_string("screenshot-%Y-%m-%d-%H-%M-%S.png"sv)));
+    auto file = Core::DateTime::now().to_byte_string("screenshot-%Y-%m-%d-%H-%M-%S.png"sv);
+    auto path = TRY(Application::the().path_for_downloaded_file(file));
 
     auto encoded = TRY(Gfx::PNGWriter::encode(*bitmap.bitmap()));