Kernel: Make Process::procfs_get_pledge_stats OOM-fallible

We can completely avoid the string allocation by using string_view().
Author: https://github.com/IdanHo Commit: https://github.com/SerenityOS/serenity/commit/0218c62be4 Pull-request: https://github.com/SerenityOS/serenity/pull/12564 Reviewed-by: https://github.com/MaxWipfli
2022-02-15 20:56:51 +02:00 · 2022-02-15 20:56:51 +02:00 · 0218c62be4 · 2024-07-17 18:41:15 +09:00
commit 0218c62be4
parent 7f44e54ad6
1 changed files with 6 additions and 6 deletions
--- a/Kernel/ProcessSpecificExposed.cpp
+++ b/Kernel/ProcessSpecificExposed.cpp
@ -126,16 +126,16 @@ ErrorOr<NonnullRefPtr<Inode>> Process::lookup_file_descriptions_directory(const
 ErrorOr<void> Process::procfs_get_pledge_stats(KBufferBuilder& builder) const
 {
    JsonObjectSerializer obj { builder };
-#define __ENUMERATE_PLEDGE_PROMISE(x) \
-    if (has_promised(Pledge::x)) {    \
-        if (!builder.is_empty())      \
-            builder.append(' ');      \
-        builder.append(#x);           \
+#define __ENUMERATE_PLEDGE_PROMISE(x)     \
+    if (has_promised(Pledge::x)) {        \
+        if (!builder.is_empty())          \
+            TRY(builder.try_append(' ')); \
+        TRY(builder.try_append(#x));      \
    }
    if (has_promises()) {
        StringBuilder builder;
        ENUMERATE_PLEDGE_PROMISES
-        obj.add("promises", builder.build());
+        obj.add("promises", builder.string_view());
    }
 #undef __ENUMERATE_PLEDGE_PROMISE
    obj.finish();