Browse Source

WebDriver: Do not throw an error when closing an inactive session

The spec states to only try to close the session *if* it exists. This
situation can occur when closing a session after a Close Window command,
as the session will be closed automatically if it was the last window.
Timothy Flynn 2 years ago
parent
commit
010be9b7c2
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Userland/Services/WebDriver/Client.cpp

+ 2 - 2
Userland/Services/WebDriver/Client.cpp

@@ -184,8 +184,8 @@ Web::WebDriver::Response Client::delete_session(Web::WebDriver::Parameters param
     dbgln_if(WEBDRIVER_DEBUG, "Handling DELETE /session/<session_id>");
 
     // 1. If the current session is an active session, try to close the session.
-    auto session = TRY(find_session_with_id(parameters[0]));
-    TRY(session->stop());
+    if (auto session = find_session_with_id(parameters[0]); !session.is_error())
+        TRY(session.value()->stop());
 
     // 2. Return success with data null.
     return JsonValue {};