We use cookies to ensure you get the best experience on our website
Sākums Izpētīt Palīdzība
Reģistrēties Pierakstīties
0ct0pu5
/
ladybird
1
0
Atdalīts 0
Faili Problēmas 0 Izmaiņu pieprasījumi 0 Vikivietne
Pārlūkot izejas kodu

LibWeb: Fix drawing axis-aligned lines

Previously, these were clipped by the RecordingPainter, which used the
path's bounding box (which in this case is zero width or height). The
fix is to expand the bounding box by the stroke width.

Fixes #22661

Note: This is unrelated to any recent LibGfx changes :^)
MacDue 1 gadu atpakaļ
vecāks
fc41c282ec
revīzija
00b24a55b1
4 mainītis faili ar 24 papildinājumiem un 0 dzēšanām
Apvienotais skats Rādīt salīdzināšanas statistiku
  1. BIN
      Tests/LibWeb/Ref/reference/images/svg-axis-aligned-lines-ref.png
  2. 9 0
      Tests/LibWeb/Ref/reference/svg-axis-aligned-lines-ref.html
  3. 11 0
      Tests/LibWeb/Ref/svg-axis-aligned-lines.html
  4. 4 0
      Userland/Libraries/LibWeb/Painting/RecordingPainter.cpp

BIN
Tests/LibWeb/Ref/reference/images/svg-axis-aligned-lines-ref.png
Parādīt failu


+ 9 - 0
Tests/LibWeb/Ref/reference/svg-axis-aligned-lines-ref.html
Parādīt failu 

@@ -0,0 +1,9 @@
 
+<style>
 
+* {
 
+    margin: 0;
 
+}
 
+body {
 
+    background-color: white;
 
+}
 
+</style>
 
+<img src="./images/svg-axis-aligned-lines-ref.png">

+ 11 - 0
Tests/LibWeb/Ref/svg-axis-aligned-lines.html
Parādīt failu 

@@ -0,0 +1,11 @@
 
+<!doctype html>
 
+<style>
 
+  body {
 
+    background-color: white;
 
+  }
 
+</style>
 
+<link rel="match" href="reference/svg-axis-aligned-lines-ref.html" />
 
+<svg width="100" height="100" viewBox="0 0 24 24" stroke="black" stroke-width="5">
 
+<line x1="12" y1="0" x2="12" y2="24"></line>
 
+<line x1="0" y1="12" x2="24" y2="12"></line>
 
+</svg>

+ 4 - 0
Userland/Libraries/LibWeb/Painting/RecordingPainter.cpp
Parādīt failu 

@@ -97,6 +97,8 @@ void RecordingPainter::stroke_path(StrokePathUsingColorParams params)
 
 {
 
 {
 
     auto aa_translation = state().translation.map(params.translation.value_or(Gfx::FloatPoint {}));
 
     auto aa_translation = state().translation.map(params.translation.value_or(Gfx::FloatPoint {}));
 
     auto path_bounding_rect = params.path.bounding_box().translated(aa_translation).to_type<int>();
 
     auto path_bounding_rect = params.path.bounding_box().translated(aa_translation).to_type<int>();
 
+    // Increase path bounding box by `thickness` to account for stroke.
 
+    path_bounding_rect.inflate(params.thickness, params.thickness);
 
     push_command(StrokePathUsingColor {
 
     push_command(StrokePathUsingColor {
 
         .path_bounding_rect = path_bounding_rect,
 
         .path_bounding_rect = path_bounding_rect,
 
         .path = params.path,
 
         .path = params.path,
 
@@ -110,6 +112,8 @@ void RecordingPainter::stroke_path(StrokePathUsingPaintStyleParams params)
 
 {
 
 {
 
     auto aa_translation = state().translation.map(params.translation.value_or(Gfx::FloatPoint {}));
 
     auto aa_translation = state().translation.map(params.translation.value_or(Gfx::FloatPoint {}));
 
     auto path_bounding_rect = params.path.bounding_box().translated(aa_translation).to_type<int>();
 
     auto path_bounding_rect = params.path.bounding_box().translated(aa_translation).to_type<int>();
 
+    // Increase path bounding box by `thickness` to account for stroke.
 
+    path_bounding_rect.inflate(params.thickness, params.thickness);
 
     push_command(StrokePathUsingPaintStyle {
 
     push_command(StrokePathUsingPaintStyle {
 
         .path_bounding_rect = path_bounding_rect,
 
         .path_bounding_rect = path_bounding_rect,
 
         .path = params.path,
 
         .path = params.path,

Contact | Legal | Takedown | Status
Self-hosted public services - About
NibbleSpot by 0ct0pu5