0ct0pu5/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-04 13:30:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
ladybird/Meta/lint-ci.sh

49 lines
1.2 KiB
Bash
Raw Normal View History

Meta: Get building on NixOS (#5005)
2021-01-22 16:44:05 +00:00
#!/usr/bin/env bash
Meta: Add script that runs all lints
2020-11-03 19:11:48 +00:00
set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 17:13:24 +00:00
RED='\033[0;31m'
GREEN='\033[0;32m'
NC='\033[0m' # No Color
FAILURES=0
set +e
Meta: Add script that runs all lints
2020-11-03 19:11:48 +00:00
for cmd in \
Meta: Verify all AK test files are listed in CMake Problem: - It is possible for a new test file to be added to the `AK/Tests` directory without being added to the corresponding `CMakeLists.txt`. This results in the tests not being run. Solution: - As part of CI linting, verify that all the `AK/Tests/Test*.cpp` files are mentioned in the `CMakeLists.txt`.
2020-12-24 16:39:37 +00:00
Meta/check-ak-test-files.sh \
Meta: Always check completeness of ALL_THE_DEBUG_MACROS
2020-11-28 17:16:38 +00:00
Meta/check-debug-flags.sh \
Meta: Rewrite the check-newlines-at-eof script in python The bash version takes around 15 seconds to run; that is way too slow. This python3 version should take less than one second to run. :^) Also, the script will now also check .py files and .txt CMake files.
2021-01-03 18:31:44 +00:00
Meta/check-newlines-at-eof.py \
Meta: Add script that runs all lints
2020-11-03 19:11:48 +00:00
Meta/check-style.sh \
Meta/lint-executable-resources.sh \
Meta/lint-ipc-ids.sh \
Meta: Add script that checks consistency of keymaps
2021-01-30 07:39:45 +00:00
Meta/lint-keymaps.py \
Meta: Run lint-prettier.sh on CI
2020-12-27 14:36:40 +00:00
Meta/lint-shell-scripts.sh \
Meta: Lint AvailablePorts.md As requested by popular demand ;) https://github.com/SerenityOS/serenity/pull/5325#discussion_r575657614
2021-02-13 12:51:52 +00:00
Meta/lint-ports.py \
Meta: Add flake8 to lint python files
2021-01-04 02:08:26 +00:00
Meta/lint-prettier.sh \
Meta/lint-python.sh; do
Meta: Update lint-{clang-format,shell-scripts}.sh to take a list of files This should speed up pre-commit a bit as only files that are staged will be processed, and clang-format and shellcheck are only invoked once, not for every file. When no arguments are given (e.g. on CI), it still uses 'git ls-files'.
2020-12-27 14:34:06 +00:00
echo "Running ${cmd}... "
if "${cmd}" "$@"; then
echo -e "[${GREEN}OK${NC}]: ${cmd}"
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 17:13:24 +00:00
else
Meta: Update lint-{clang-format,shell-scripts}.sh to take a list of files This should speed up pre-commit a bit as only files that are staged will be processed, and clang-format and shellcheck are only invoked once, not for every file. When no arguments are given (e.g. on CI), it still uses 'git ls-files'.
2020-12-27 14:34:06 +00:00
echo -e "[${RED}FAIL${NC}]: ${cmd}"
((FAILURES+=1))
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 17:13:24 +00:00
fi
Meta: Add script that runs all lints
2020-11-03 19:11:48 +00:00
done
echo "Running Meta/lint-clang-format.sh"
Meta: Update lint-{clang-format,shell-scripts}.sh to take a list of files This should speed up pre-commit a bit as only files that are staged will be processed, and clang-format and shellcheck are only invoked once, not for every file. When no arguments are given (e.g. on CI), it still uses 'git ls-files'.
2020-12-27 14:34:06 +00:00
if Meta/lint-clang-format.sh --overwrite-inplace "$@" && git diff --exit-code; then
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 17:13:24 +00:00
echo -e "[${GREEN}OK${NC}]: Meta/lint-clang-format.sh"
else
echo -e "[${RED}FAIL${NC}]: Meta/lint-clang-format.sh"
((FAILURES+=1))
fi
Meta: Add script that runs all lints
2020-11-03 19:11:48 +00:00
echo "(Not running lint-missing-resources.sh due to high false-positive rate.)"
echo "(Also look out for check-symbols.sh, which can only be executed after the build!)"
Meta: Run all lint checks and report failures together Problem: - The first lint check that fails results in all subsequent checks not being run. Solution: - Run all the lint checks aggregating the number of failures. - Return a non-0 exit code if any have failed.
2020-12-24 17:13:24 +00:00
Meta: Make lint-shell-scripts.sh happy `${FAILURES}` -> `"${FAILURES}"`
2020-12-26 08:26:32 +00:00
exit "${FAILURES}"
Reference in a new issue Copy permalink