0ct0pu5/kafka-ui
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

In Sync Replicas metric displays correct information (#1920)

Browse source 
Co-authored-by: Smbat Siradeghyan
Co-authored-by: Oleg Shur <workshur@gmail.com>
This commit is contained in:
Smbat Siradeghyan 2022-05-11 12:37:07 +04:00 • committed by GitHub
parent e597f14b8d
commit ee102aa87e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kafka-ui-react-app/src/components/Brokers/Brokers.tsx
View file

@ -30,7 +30,7 @@ const Brokers: React.FC = () => {
items,
} = useAppSelector(selectStats);
const replicas = inSyncReplicasCount ?? 0 + (outOfSyncReplicasCount ?? 0);
const replicas = (inSyncReplicasCount ?? 0) + (outOfSyncReplicasCount ?? 0);
const areAllInSync = inSyncReplicasCount && replicas === inSyncReplicasCount;
const partitionIsOffline = offlinePartitionCount && offlinePartitionCount > 0;
React.useEffect(() => {

52
kafka-ui-react-app/src/components/Brokers/__test__/Brokers.spec.tsx
View file

@ -11,6 +11,10 @@ describe('Brokers Component', () => {
afterEach(() => fetchMock.reset());
const clusterName = 'local';
const testInSyncReplicasCount = 798;
const testOutOfSyncReplicasCount = 1;
const renderComponent = () =>
render(
<Route path={clusterBrokersPath(':clusterName')}>
@ -48,7 +52,6 @@ describe('Brokers Component', () => {
const rows = screen.getAllByRole('row');
expect(rows.length).toEqual(3);
});
it('shows warning when offlinePartitionCount > 0', async () => {
const fetchStatsMock = fetchMock.getOnce(fetchStatsUrl, {
...clusterStatsPayload,
@ -67,5 +70,52 @@ describe('Brokers Component', () => {
expect(onlineWidget).toBeInTheDocument();
expect(onlineWidget).toHaveStyle({ color: '#E51A1A' });
});
it('shows right count when offlinePartitionCount > 0', async () => {
const fetchStatsMock = fetchMock.getOnce(fetchStatsUrl, {
...clusterStatsPayload,
inSyncReplicasCount: testInSyncReplicasCount,
outOfSyncReplicasCount: testOutOfSyncReplicasCount,
});
renderComponent();
await waitFor(() => {
expect(fetchStatsMock.called()).toBeTruthy();
});
const onlineWidgetDef = screen.getByText(testInSyncReplicasCount);
const onlineWidget = screen.getByText(
`of ${testInSyncReplicasCount + testOutOfSyncReplicasCount}`
);
expect(onlineWidgetDef).toBeInTheDocument();
expect(onlineWidget).toBeInTheDocument();
});
it('shows right count when inSyncReplicasCount: undefined outOfSyncReplicasCount: 1', async () => {
const fetchStatsMock = fetchMock.getOnce(fetchStatsUrl, {
...clusterStatsPayload,
inSyncReplicasCount: undefined,
outOfSyncReplicasCount: testOutOfSyncReplicasCount,
});
renderComponent();
await waitFor(() => {
expect(fetchStatsMock.called()).toBeTruthy();
});
const onlineWidget = screen.getByText(`of ${testOutOfSyncReplicasCount}`);
expect(onlineWidget).toBeInTheDocument();
});
it(`shows right count when inSyncReplicasCount: ${testInSyncReplicasCount} outOfSyncReplicasCount: undefined`, async () => {
const fetchStatsMock = fetchMock.getOnce(fetchStatsUrl, {
...clusterStatsPayload,
inSyncReplicasCount: testInSyncReplicasCount,
outOfSyncReplicasCount: undefined,
});
renderComponent();
await waitFor(() => {
expect(fetchStatsMock.called()).toBeTruthy();
});
const onlineWidgetDef = screen.getByText(testInSyncReplicasCount);
const onlineWidget = screen.getByText(`of ${testInSyncReplicasCount}`);
expect(onlineWidgetDef).toBeInTheDocument();
expect(onlineWidget).toBeInTheDocument();
});
});
});