From e24423e61304aec0c61612b462a44a776cc7a50a Mon Sep 17 00:00:00 2001
From: Oleg Shuralev <workshur@gmail.com>
Date: Fri, 17 Jan 2020 22:35:19 +0300
Subject: [PATCH] [UI] Topic Creation Page

---
 frontend/src/components/Topics/List/List.tsx  |  42 ++--
 .../components/Topics/List/ListContainer.ts   |  15 +-
 frontend/src/components/Topics/New/New.tsx    | 218 ++++++++++++++++++
 .../src/components/Topics/New/NewContainer.ts |  19 ++
 frontend/src/components/Topics/Topics.tsx     |   4 +-
 frontend/src/lib/constants.ts                 |   4 +
 frontend/src/lib/paths.ts                     |   1 +
 frontend/src/theme/bulma_overrides.scss       |   4 +
 frontend/src/types/topic.ts                   |  17 ++
 9 files changed, 307 insertions(+), 17 deletions(-)
 create mode 100644 frontend/src/components/Topics/New/New.tsx
 create mode 100644 frontend/src/components/Topics/New/NewContainer.ts

diff --git a/frontend/src/components/Topics/List/List.tsx b/frontend/src/components/Topics/List/List.tsx
index 9b3b0ac5a7..d193b077f4 100644
--- a/frontend/src/components/Topics/List/List.tsx
+++ b/frontend/src/components/Topics/List/List.tsx
@@ -1,14 +1,18 @@
 import React from 'react';
-import { TopicWithDetailedInfo } from 'types';
+import { TopicWithDetailedInfo, ClusterId } from 'types';
 import ListItem from './ListItem';
 import Breadcrumb from 'components/common/Breadcrumb/Breadcrumb';
+import { NavLink } from 'react-router-dom';
+import { clusterTopicNewPath } from 'lib/paths';
 
 interface Props {
+  clusterId: ClusterId;
   topics: (TopicWithDetailedInfo)[];
   externalTopics: (TopicWithDetailedInfo)[];
 }
 
 const List: React.FC<Props> = ({
+  clusterId,
   topics,
   externalTopics,
 }) => {
@@ -23,18 +27,30 @@ const List: React.FC<Props> = ({
       <Breadcrumb>All Topics</Breadcrumb>
 
       <div className="box">
-        <div className="field">
-          <input
-            id="switchRoundedDefault"
-            type="checkbox"
-            name="switchRoundedDefault"
-            className="switch is-rounded"
-            checked={showInternal}
-            onChange={handleSwitch}
-          />
-          <label htmlFor="switchRoundedDefault">
-            Show Internal Topics
-          </label>
+        <div className="level">
+          <div className="level-item level-left">
+            <div className="field">
+              <input
+                id="switchRoundedDefault"
+                type="checkbox"
+                name="switchRoundedDefault"
+                className="switch is-rounded"
+                checked={showInternal}
+                onChange={handleSwitch}
+              />
+              <label htmlFor="switchRoundedDefault">
+                Show Internal Topics
+              </label>
+            </div>
+          </div>
+          <div className="level-item level-right">
+            <NavLink
+              className="button is-primary"
+              to={clusterTopicNewPath(clusterId)}
+            >
+              Add a Topic
+            </NavLink>
+          </div>
         </div>
       </div>
       <div className="box">
diff --git a/frontend/src/components/Topics/List/ListContainer.ts b/frontend/src/components/Topics/List/ListContainer.ts
index 81be3a36bd..6efbef3a59 100644
--- a/frontend/src/components/Topics/List/ListContainer.ts
+++ b/frontend/src/components/Topics/List/ListContainer.ts
@@ -2,11 +2,20 @@ import { connect } from 'react-redux';
 import { RootState } from 'types';
 import { getTopicList, getExternalTopicList } from 'redux/reducers/topics/selectors';
 import List from './List';
+import { withRouter, RouteComponentProps } from 'react-router-dom';
 
-const mapStateToProps = (state: RootState) => ({
+interface RouteProps {
+  clusterId: string;
+}
+
+interface OwnProps extends RouteComponentProps<RouteProps> { }
+
+const mapStateToProps = (state: RootState, { match: { params: { clusterId } } }: OwnProps) => ({
+  clusterId,
   topics: getTopicList(state),
   externalTopics: getExternalTopicList(state),
 });
 
-
-export default connect(mapStateToProps)(List);
+export default withRouter(
+  connect(mapStateToProps)(List)
+);
diff --git a/frontend/src/components/Topics/New/New.tsx b/frontend/src/components/Topics/New/New.tsx
new file mode 100644
index 0000000000..c89bd8f031
--- /dev/null
+++ b/frontend/src/components/Topics/New/New.tsx
@@ -0,0 +1,218 @@
+import React from 'react';
+import { ClusterId, CleanupPolicy, TopicFormData } from 'types';
+import Breadcrumb from 'components/common/Breadcrumb/Breadcrumb';
+import { clusterTopicsPath } from 'lib/paths';
+import { useForm, ErrorMessage } from 'react-hook-form';
+import {
+  TOPIC_NAME_VALIDATION_PATTERN,
+  MILLISECONDS_IN_DAY,
+  BYTES_IN_GB,
+} from 'lib/constants';
+
+interface Props {
+  clusterId: ClusterId;
+}
+
+const New: React.FC<Props> = ({
+  clusterId,
+}) => {
+  const { register, handleSubmit, errors } = useForm<TopicFormData>(); // initialise the hook
+
+  const onSubmit = (data: TopicFormData) => {
+    console.log(data);
+  };
+
+  return (
+    <div className="section">
+      <div className="level">
+        <div className="level-item level-left">
+          <Breadcrumb links={[
+            { href: clusterTopicsPath(clusterId), label: 'All Topics' },
+          ]}>
+            New Topic
+          </Breadcrumb>
+        </div>
+      </div>
+
+      <div className="box">
+        <form onSubmit={handleSubmit(onSubmit)}>
+          <div className="columns">
+
+            <div className="column is-three-quarters">
+              <label className="label">
+                Topic Name *
+              </label>
+              <input
+                className="input"
+                placeholder="Topic Name"
+                ref={register({
+                  required: 'Topic Name is required.',
+                  pattern: {
+                    value: TOPIC_NAME_VALIDATION_PATTERN,
+                    message: 'Only alphanumeric, _, -, and . allowed',
+                  },
+                })}
+                name="name"
+                autoComplete="off"
+              />
+              <p className="help is-danger">
+                <ErrorMessage errors={errors} name="name" />
+              </p>
+            </div>
+
+            <div className="column">
+              <label className="label">
+                Number of partitions *
+              </label>
+              <input
+                className="input"
+                type="number"
+                placeholder="Number of partitions"
+                defaultValue="1"
+                ref={register({ required: 'Number of partitions is required.' })}
+                name="partitions"
+              />
+              <p className="help is-danger">
+                <ErrorMessage errors={errors} name="partitions" />
+              </p>
+            </div>
+          </div>
+
+          <div className="columns">
+            <div className="column">
+              <label className="label">
+                Replication Factor *
+              </label>
+              <input
+                className="input"
+                type="number"
+                placeholder="Replication Factor"
+                defaultValue="1"
+                ref={register({ required: 'Replication Factor is required.' })}
+                name="replicationFactor"
+              />
+              <p className="help is-danger">
+                <ErrorMessage errors={errors} name="replicationFactor" />
+              </p>
+            </div>
+
+            <div className="column">
+              <label className="label">
+                Min In Sync Replicas *
+              </label>
+              <input
+                className="input"
+                type="number"
+                placeholder="Replication Factor"
+                defaultValue="1"
+                ref={register({ required: 'Min In Sync Replicas is required.' })}
+                name="minInSyncReplicas"
+              />
+              <p className="help is-danger">
+                <ErrorMessage errors={errors} name="minInSyncReplicas" />
+              </p>
+            </div>
+          </div>
+
+          <div className="columns">
+            <div className="column is-one-third">
+              <label className="label">
+                Cleanup policy
+              </label>
+              <div className="select is-block">
+                <select defaultValue={CleanupPolicy.Delete} name="cleanupPolicy">
+                  <option value={CleanupPolicy.Delete}>
+                    Delete
+                  </option>
+                  <option value={CleanupPolicy.Compact}>
+                    Compact
+                  </option>
+                </select>
+              </div>
+            </div>
+
+            <div className="column is-one-third">
+              <label className="label">
+                Time to retain data
+              </label>
+              <div className="select is-block">
+                <select
+                  defaultValue={MILLISECONDS_IN_DAY * 7}
+                  name="retentionMs"
+                  ref={register}
+                >
+                  <option value={MILLISECONDS_IN_DAY / 2 }>
+                    12 hours
+                  </option>
+                  <option value={MILLISECONDS_IN_DAY}>
+                    1 day
+                  </option>
+                  <option value={MILLISECONDS_IN_DAY * 2}>
+                    2 days
+                  </option>
+                  <option value={MILLISECONDS_IN_DAY * 7}>
+                    1 week
+                  </option>
+                  <option value={MILLISECONDS_IN_DAY * 7 * 4}>
+                    4 weeks
+                  </option>
+                </select>
+              </div>
+            </div>
+
+            <div className="column is-one-third">
+              <label className="label">
+                Max size on disk in GB
+              </label>
+              <div className="select is-block">
+                <select
+                  defaultValue={-1}
+                  name="retentionBytes"
+                  ref={register}
+                >
+                  <option value={-1}>
+                    Not Set
+                  </option>
+                  <option value={BYTES_IN_GB}>
+                    1 GB
+                  </option>
+                  <option value={BYTES_IN_GB * 10}>
+                    10 GB
+                  </option>
+                  <option value={BYTES_IN_GB * 20}>
+                    20 GB
+                  </option>
+                  <option value={BYTES_IN_GB * 50}>
+                    50 GB
+                  </option>
+                </select>
+              </div>
+            </div>
+          </div>
+
+          <div className="columns">
+            <div className="column">
+              <label className="label">
+                Maximum message size in bytes *
+              </label>
+              <input
+                className="input"
+                type="number"
+                defaultValue="1000012"
+                ref={register({ required: 'Maximum message size in bytes is required' })}
+                name="maxMessageBytes"
+              />
+              <p className="help is-danger">
+                <ErrorMessage errors={errors} name="maxMessageBytes" />
+              </p>
+            </div>
+          </div>
+
+          <input type="submit" className="button is-primary"/>
+        </form>
+      </div>
+    </div>
+  );
+}
+
+export default New;
diff --git a/frontend/src/components/Topics/New/NewContainer.ts b/frontend/src/components/Topics/New/NewContainer.ts
new file mode 100644
index 0000000000..9dadbc0ee3
--- /dev/null
+++ b/frontend/src/components/Topics/New/NewContainer.ts
@@ -0,0 +1,19 @@
+import { connect } from 'react-redux';
+import { RootState } from 'types';
+import New from './New';
+import { withRouter, RouteComponentProps } from 'react-router-dom';
+
+interface RouteProps {
+  clusterId: string;
+}
+
+interface OwnProps extends RouteComponentProps<RouteProps> { }
+
+const mapStateToProps = (state: RootState, { match: { params: { clusterId } } }: OwnProps) => ({
+  clusterId,
+});
+
+
+export default withRouter(
+  connect(mapStateToProps)(New)
+);
diff --git a/frontend/src/components/Topics/Topics.tsx b/frontend/src/components/Topics/Topics.tsx
index e67c14b22f..50d4c48b60 100644
--- a/frontend/src/components/Topics/Topics.tsx
+++ b/frontend/src/components/Topics/Topics.tsx
@@ -1,4 +1,5 @@
 import React from 'react';
+import { ClusterId } from 'types';
 import {
   Switch,
   Route,
@@ -6,7 +7,7 @@ import {
 import ListContainer from './List/ListContainer';
 import DetailsContainer from './Details/DetailsContainer';
 import PageLoader from 'components/common/PageLoader/PageLoader';
-import { ClusterId } from 'types';
+import NewContainer from './New/NewContainer';
 
 interface Props {
   clusterId: string;
@@ -26,6 +27,7 @@ const Topics: React.FC<Props> = ({
     return (
       <Switch>
         <Route exact path="/clusters/:clusterId/topics" component={ListContainer} />
+        <Route exact path="/clusters/:clusterId/topics/new" component={NewContainer} />
         <Route path="/clusters/:clusterId/topics/:topicName" component={DetailsContainer} />
       </Switch>
     );
diff --git a/frontend/src/lib/constants.ts b/frontend/src/lib/constants.ts
index 56e9cfd1f8..e2812085eb 100644
--- a/frontend/src/lib/constants.ts
+++ b/frontend/src/lib/constants.ts
@@ -7,3 +7,7 @@ export const BASE_PARAMS: RequestInit = {
 };
 
 export const BASE_URL = 'http://localhost:3004';
+
+export const TOPIC_NAME_VALIDATION_PATTERN = RegExp(/^[.,A-Za-z0-9_-]+$/);
+export const MILLISECONDS_IN_DAY = 86_400_000;
+export const BYTES_IN_GB = 1_073_741_824;
diff --git a/frontend/src/lib/paths.ts b/frontend/src/lib/paths.ts
index 26106947b8..787e5de7a2 100644
--- a/frontend/src/lib/paths.ts
+++ b/frontend/src/lib/paths.ts
@@ -5,6 +5,7 @@ const clusterPath = (clusterId: ClusterId) => `/clusters/${clusterId}`;
 export const clusterBrokersPath = (clusterId: ClusterId) => `${clusterPath(clusterId)}/brokers`;
 
 export const clusterTopicsPath = (clusterId: ClusterId) => `${clusterPath(clusterId)}/topics`;
+export const clusterTopicNewPath = (clusterId: ClusterId) => `${clusterPath(clusterId)}/topics/new`;
 
 export const clusterTopicPath = (clusterId: ClusterId, topicName: TopicName) => `${clusterTopicsPath(clusterId)}/${topicName}`;
 export const clusterTopicSettingsPath = (clusterId: ClusterId, topicName: TopicName) => `${clusterTopicsPath(clusterId)}/${topicName}/settings`;
diff --git a/frontend/src/theme/bulma_overrides.scss b/frontend/src/theme/bulma_overrides.scss
index 5bd74bb8d4..db34f13ba5 100644
--- a/frontend/src/theme/bulma_overrides.scss
+++ b/frontend/src/theme/bulma_overrides.scss
@@ -28,6 +28,10 @@
   animation: fadein .5s;
 }
 
+.select.is-block select {
+  width: 100%;
+}
+
 @keyframes fadein {
   from { opacity: 0; }
   to   { opacity: 1; }
diff --git a/frontend/src/types/topic.ts b/frontend/src/types/topic.ts
index 875fb0aeaa..47c381b2d7 100644
--- a/frontend/src/types/topic.ts
+++ b/frontend/src/types/topic.ts
@@ -1,4 +1,10 @@
 export type TopicName = string;
+
+export enum CleanupPolicy {
+  Delete = 'delete',
+  Compact = 'compact',
+}
+
 export interface TopicConfig {
   name: string;
   value: string;
@@ -41,3 +47,14 @@ export interface TopicsState {
   byName: { [topicName: string]: TopicWithDetailedInfo },
   allNames: TopicName[],
 }
+
+export interface TopicFormData {
+  name: string;
+  partitions: number;
+  replicationFactor: number;
+  minInSyncReplicas: number;
+  cleanupPolicy: string;
+  retentionMs: number;
+  retentionBytes: number;
+  maxMessageBytes: number;
+};