Merge branch 'master' into issues/checkShowStreamsRequestExecution2
This commit is contained in:
commit
db117f4e42
60 changed files with 969 additions and 631 deletions
92
.github/ISSUE_TEMPLATE/bug.yml
vendored
Normal file
92
.github/ISSUE_TEMPLATE/bug.yml
vendored
Normal file
|
@ -0,0 +1,92 @@
|
||||||
|
name: "\U0001F41E Bug report"
|
||||||
|
description: File a bug report
|
||||||
|
labels: ["status/triage", "type/bug"]
|
||||||
|
assignees: []
|
||||||
|
|
||||||
|
body:
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: |
|
||||||
|
Hi, thanks for raising the issue(-s), all contributions really matter!
|
||||||
|
Please, note that we'll close the issue without further explanation if you don't follow
|
||||||
|
this template and don't provide the information requested within this template.
|
||||||
|
|
||||||
|
- type: checkboxes
|
||||||
|
id: terms
|
||||||
|
attributes:
|
||||||
|
label: Issue submitter TODO list
|
||||||
|
description: By you checking these checkboxes we can be sure you've done the essential things.
|
||||||
|
options:
|
||||||
|
- label: I've looked up my issue in [FAQ](https://docs.kafka-ui.provectus.io/faq/common-problems)
|
||||||
|
required: true
|
||||||
|
- label: I've searched for an already existing issues [here](https://github.com/provectus/kafka-ui/issues)
|
||||||
|
required: true
|
||||||
|
- label: I've tried running `master`-labeled docker image and the issue still persists there
|
||||||
|
required: true
|
||||||
|
- label: I'm running a supported version of the application which is listed [here](https://github.com/provectus/kafka-ui/blob/master/SECURITY.md)
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Describe the bug (actual behavior)
|
||||||
|
description: A clear and concise description of what the bug is. Use a list, if there is more than one problem
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Expected behavior
|
||||||
|
description: A clear and concise description of what you expected to happen
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Your installation details
|
||||||
|
description: |
|
||||||
|
How do you run the app? Please provide as much info as possible:
|
||||||
|
1. App version (commit hash in the top left corner of the UI)
|
||||||
|
2. Helm chart version, if you use one
|
||||||
|
3. Your application config. Please remove the sensitive info like passwords or API keys.
|
||||||
|
4. Any IAAC configs
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Steps to reproduce
|
||||||
|
description: |
|
||||||
|
Please write down the order of the actions required to reproduce the issue.
|
||||||
|
For the advanced setups/complicated issue, we might need you to provide
|
||||||
|
a minimal [reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Screenshots
|
||||||
|
description: |
|
||||||
|
If applicable, add screenshots to help explain your problem
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Logs
|
||||||
|
description: |
|
||||||
|
If applicable, *upload* screenshots to help explain your problem
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Additional context
|
||||||
|
description: |
|
||||||
|
Add any other context about the problem here. E.G.:
|
||||||
|
1. Are there any alternative scenarios (different data/methods/configuration/setup) you have tried?
|
||||||
|
Were they successful or the same issue occurred? Please provide steps as well.
|
||||||
|
2. Related issues (if there are any).
|
||||||
|
3. Logs (if available)
|
||||||
|
4. Is there any serious impact or behaviour on the end-user because of this issue, that can be overlooked?
|
||||||
|
validations:
|
||||||
|
required: false
|
64
.github/ISSUE_TEMPLATE/bug_report.md
vendored
64
.github/ISSUE_TEMPLATE/bug_report.md
vendored
|
@ -1,64 +0,0 @@
|
||||||
---
|
|
||||||
name: "\U0001F41E Bug report"
|
|
||||||
about: Create a bug report
|
|
||||||
title: ''
|
|
||||||
labels: status/triage, type/bug
|
|
||||||
assignees: ''
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
<!--
|
|
||||||
|
|
||||||
We will close the issue without further explanation if you don't follow this template and don't provide the information requested within this template.
|
|
||||||
|
|
||||||
Don't forget to check for existing issues/discussions regarding your proposal. We might already have it.
|
|
||||||
https://github.com/provectus/kafka-ui/issues
|
|
||||||
https://github.com/provectus/kafka-ui/discussions
|
|
||||||
|
|
||||||
-->
|
|
||||||
|
|
||||||
<!--
|
|
||||||
Please follow the naming conventions for bugs:
|
|
||||||
<Feature/Area/Scope> : <Compact, but specific problem summary>
|
|
||||||
Avoid generic titles, like “Topics: incorrect layout of message sorting drop-down list”. Better use something like: “Topics: Message sorting drop-down list overlaps the "Submit" button”.
|
|
||||||
|
|
||||||
-->
|
|
||||||
|
|
||||||
**Describe the bug** (Actual behavior)
|
|
||||||
<!--(A clear and concise description of what the bug is.Use a list, if there is more than one problem)-->
|
|
||||||
|
|
||||||
**Expected behavior**
|
|
||||||
<!--(A clear and concise description of what you expected to happen.)-->
|
|
||||||
|
|
||||||
**Set up**
|
|
||||||
<!--
|
|
||||||
WE MIGHT CLOSE THE ISSUE without further explanation IF YOU DON'T PROVIDE THIS INFORMATION.
|
|
||||||
|
|
||||||
How do you run the app? Please provide as much info as possible:
|
|
||||||
1. App version (docker image version or check commit hash in the top left corner in UI)
|
|
||||||
2. Helm chart version, if you use one
|
|
||||||
3. Any IAAC configs
|
|
||||||
-->
|
|
||||||
|
|
||||||
|
|
||||||
**Steps to Reproduce**
|
|
||||||
<!-- We'd like you to provide an example setup (via docker-compose, helm, etc.)
|
|
||||||
to reproduce the problem, especially with a complex setups. -->
|
|
||||||
|
|
||||||
1.
|
|
||||||
|
|
||||||
**Screenshots**
|
|
||||||
<!--
|
|
||||||
(If applicable, add screenshots to help explain your problem)
|
|
||||||
-->
|
|
||||||
|
|
||||||
|
|
||||||
**Additional context**
|
|
||||||
<!--
|
|
||||||
Add any other context about the problem here. E.g.:
|
|
||||||
1. Are there any alternative scenarios (different data/methods/configuration/setup) you have tried?
|
|
||||||
Were they successfull or same issue occured? Please provide steps as well.
|
|
||||||
2. Related issues (if there are any).
|
|
||||||
3. Logs (if available)
|
|
||||||
4. Is there any serious impact or behaviour on the end-user because of this issue, that can be overlooked?
|
|
||||||
-->
|
|
66
.github/ISSUE_TEMPLATE/feature.yml
vendored
Normal file
66
.github/ISSUE_TEMPLATE/feature.yml
vendored
Normal file
|
@ -0,0 +1,66 @@
|
||||||
|
name: "\U0001F680 Feature request"
|
||||||
|
description: Propose a new feature
|
||||||
|
labels: ["status/triage", "type/feature"]
|
||||||
|
assignees: []
|
||||||
|
|
||||||
|
body:
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: |
|
||||||
|
Hi, thanks for raising the issue(-s), all contributions really matter!
|
||||||
|
Please, note that we'll close the issue without further explanation if you don't follow
|
||||||
|
this template and don't provide the information requested within this template.
|
||||||
|
|
||||||
|
- type: checkboxes
|
||||||
|
id: terms
|
||||||
|
attributes:
|
||||||
|
label: Issue submitter TODO list
|
||||||
|
description: By you checking these checkboxes we can be sure you've done the essential things.
|
||||||
|
options:
|
||||||
|
- label: I've searched for an already existing issues [here](https://github.com/provectus/kafka-ui/issues)
|
||||||
|
required: true
|
||||||
|
- label: I'm running a supported version of the application which is listed [here](https://github.com/provectus/kafka-ui/blob/master/SECURITY.md) and the feature is not present there
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Is your proposal related to a problem?
|
||||||
|
description: |
|
||||||
|
Provide a clear and concise description of what the problem is.
|
||||||
|
For example, "I'm always frustrated when..."
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Describe the feature you're interested in
|
||||||
|
description: |
|
||||||
|
Provide a clear and concise description of what you want to happen.
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Describe alternatives you've considered
|
||||||
|
description: |
|
||||||
|
Let us know about other solutions you've tried or researched.
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: input
|
||||||
|
attributes:
|
||||||
|
label: Version you're running
|
||||||
|
description: |
|
||||||
|
Please provide the app version you're currently running:
|
||||||
|
1. App version (commit hash in the top left corner of the UI)
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Additional context
|
||||||
|
description: |
|
||||||
|
Is there anything else you can add about the proposal?
|
||||||
|
You might want to link to related issues here, if you haven't already.
|
||||||
|
validations:
|
||||||
|
required: false
|
46
.github/ISSUE_TEMPLATE/feature_request.md
vendored
46
.github/ISSUE_TEMPLATE/feature_request.md
vendored
|
@ -1,46 +0,0 @@
|
||||||
---
|
|
||||||
name: "\U0001F680 Feature request"
|
|
||||||
about: Propose a new feature
|
|
||||||
title: ''
|
|
||||||
labels: status/triage, type/feature
|
|
||||||
assignees: ''
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
<!--
|
|
||||||
|
|
||||||
Don't forget to check for existing issues/discussions regarding your proposal. We might already have it.
|
|
||||||
https://github.com/provectus/kafka-ui/issues
|
|
||||||
https://github.com/provectus/kafka-ui/discussions
|
|
||||||
|
|
||||||
-->
|
|
||||||
|
|
||||||
### Which version of the app are you running?
|
|
||||||
<!-- Please provide docker image version or check commit hash in the top left corner in UI) -->
|
|
||||||
|
|
||||||
### Is your proposal related to a problem?
|
|
||||||
|
|
||||||
<!--
|
|
||||||
Provide a clear and concise description of what the problem is.
|
|
||||||
For example, "I'm always frustrated when..."
|
|
||||||
-->
|
|
||||||
|
|
||||||
### Describe the solution you'd like
|
|
||||||
|
|
||||||
<!--
|
|
||||||
Provide a clear and concise description of what you want to happen.
|
|
||||||
-->
|
|
||||||
|
|
||||||
### Describe alternatives you've considered
|
|
||||||
|
|
||||||
<!--
|
|
||||||
Let us know about other solutions you've tried or researched.
|
|
||||||
-->
|
|
||||||
|
|
||||||
### Additional context
|
|
||||||
|
|
||||||
<!--
|
|
||||||
Is there anything else you can add about the proposal?
|
|
||||||
You might want to link to related issues here, if you haven't already.
|
|
||||||
-->
|
|
||||||
|
|
92
.github/ISSUE_TEMPLATE/helm.yml
vendored
Normal file
92
.github/ISSUE_TEMPLATE/helm.yml
vendored
Normal file
|
@ -0,0 +1,92 @@
|
||||||
|
name: "⎈ K8s/Helm problem report"
|
||||||
|
description: "Report a problem with k8s/helm charts/etc"
|
||||||
|
labels: ["status/triage", "scope/k8s"]
|
||||||
|
assignees: []
|
||||||
|
|
||||||
|
body:
|
||||||
|
- type: markdown
|
||||||
|
attributes:
|
||||||
|
value: |
|
||||||
|
Hi, thanks for raising the issue(-s), all contributions really matter!
|
||||||
|
Please, note that we'll close the issue without further explanation if you don't follow
|
||||||
|
this template and don't provide the information requested within this template.
|
||||||
|
|
||||||
|
- type: checkboxes
|
||||||
|
id: terms
|
||||||
|
attributes:
|
||||||
|
label: Issue submitter TODO list
|
||||||
|
description: By you checking these checkboxes we can be sure you've done the essential things.
|
||||||
|
options:
|
||||||
|
- label: I've looked up my issue in [FAQ](https://docs.kafka-ui.provectus.io/faq/common-problems)
|
||||||
|
required: true
|
||||||
|
- label: I've searched for an already existing issues [here](https://github.com/provectus/kafka-ui/issues)
|
||||||
|
required: true
|
||||||
|
- label: I've tried running `master`-labeled docker image and the issue still persists there
|
||||||
|
required: true
|
||||||
|
- label: I'm running a supported version of the application which is listed [here](https://github.com/provectus/kafka-ui/blob/master/SECURITY.md)
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Describe the bug (actual behavior)
|
||||||
|
description: A clear and concise description of what the bug is. Use a list, if there is more than one problem
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Expected behavior
|
||||||
|
description: A clear and concise description of what you expected to happen
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Your installation details
|
||||||
|
description: |
|
||||||
|
How do you run the app? Please provide as much info as possible:
|
||||||
|
1. App version (commit hash in the top left corner of the UI)
|
||||||
|
2. Helm chart version
|
||||||
|
3. Your application config. Please remove the sensitive info like passwords or API keys.
|
||||||
|
4. Any IAAC configs
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Steps to reproduce
|
||||||
|
description: |
|
||||||
|
Please write down the order of the actions required to reproduce the issue.
|
||||||
|
For the advanced setups/complicated issue, we might need you to provide
|
||||||
|
a minimal [reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
|
||||||
|
validations:
|
||||||
|
required: true
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Screenshots
|
||||||
|
description: |
|
||||||
|
If applicable, add screenshots to help explain your problem
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Logs
|
||||||
|
description: |
|
||||||
|
If applicable, *upload* screenshots to help explain your problem
|
||||||
|
validations:
|
||||||
|
required: false
|
||||||
|
|
||||||
|
- type: textarea
|
||||||
|
attributes:
|
||||||
|
label: Additional context
|
||||||
|
description: |
|
||||||
|
Add any other context about the problem here. E.G.:
|
||||||
|
1. Are there any alternative scenarios (different data/methods/configuration/setup) you have tried?
|
||||||
|
Were they successful or the same issue occurred? Please provide steps as well.
|
||||||
|
2. Related issues (if there are any).
|
||||||
|
3. Logs (if available)
|
||||||
|
4. Is there any serious impact or behaviour on the end-user because of this issue, that can be overlooked?
|
||||||
|
validations:
|
||||||
|
required: false
|
52
.github/ISSUE_TEMPLATE/k8s.md
vendored
52
.github/ISSUE_TEMPLATE/k8s.md
vendored
|
@ -1,52 +0,0 @@
|
||||||
---
|
|
||||||
name: "⎈ K8s/Helm problem report"
|
|
||||||
about: Report a problem with k8s/helm charts/etc
|
|
||||||
title: ''
|
|
||||||
labels: scope/k8s, status/triage
|
|
||||||
assignees: azatsafin
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
<!--
|
|
||||||
|
|
||||||
Don't forget to check for existing issues/discussions regarding your proposal. We might already have it.
|
|
||||||
https://github.com/provectus/kafka-ui/issues
|
|
||||||
https://github.com/provectus/kafka-ui/discussions
|
|
||||||
|
|
||||||
-->
|
|
||||||
|
|
||||||
**Describe the bug**
|
|
||||||
<!--(A clear and concise description of what the bug is.)-->
|
|
||||||
|
|
||||||
|
|
||||||
**Set up**
|
|
||||||
<!--
|
|
||||||
How do you run the app? Please provide as much info as possible:
|
|
||||||
1. App version (docker image version or check commit hash in the top left corner in UI)
|
|
||||||
2. Helm chart version, if you use one
|
|
||||||
3. Any IAAC configs
|
|
||||||
|
|
||||||
We might close the issue without further explanation if you don't provide such information.
|
|
||||||
-->
|
|
||||||
|
|
||||||
|
|
||||||
**Steps to Reproduce**
|
|
||||||
Steps to reproduce the behavior:
|
|
||||||
|
|
||||||
1.
|
|
||||||
|
|
||||||
**Expected behavior**
|
|
||||||
<!--
|
|
||||||
(A clear and concise description of what you expected to happen)
|
|
||||||
-->
|
|
||||||
|
|
||||||
**Screenshots**
|
|
||||||
<!--
|
|
||||||
(If applicable, add screenshots to help explain your problem)
|
|
||||||
-->
|
|
||||||
|
|
||||||
|
|
||||||
**Additional context**
|
|
||||||
<!--
|
|
||||||
(Add any other context about the problem here)
|
|
||||||
-->
|
|
4
.github/dependabot.yml
vendored
4
.github/dependabot.yml
vendored
|
@ -8,8 +8,6 @@ updates:
|
||||||
timezone: Europe/Moscow
|
timezone: Europe/Moscow
|
||||||
reviewers:
|
reviewers:
|
||||||
- "Haarolean"
|
- "Haarolean"
|
||||||
assignees:
|
|
||||||
- "Haarolean"
|
|
||||||
labels:
|
labels:
|
||||||
- "scope/backend"
|
- "scope/backend"
|
||||||
- "type/dependencies"
|
- "type/dependencies"
|
||||||
|
@ -99,8 +97,6 @@ updates:
|
||||||
timezone: Europe/Moscow
|
timezone: Europe/Moscow
|
||||||
reviewers:
|
reviewers:
|
||||||
- "Haarolean"
|
- "Haarolean"
|
||||||
assignees:
|
|
||||||
- "Haarolean"
|
|
||||||
labels:
|
labels:
|
||||||
- "scope/infrastructure"
|
- "scope/infrastructure"
|
||||||
- "type/dependencies"
|
- "type/dependencies"
|
||||||
|
|
|
@ -21,6 +21,12 @@
|
||||||
</properties>
|
</properties>
|
||||||
|
|
||||||
<dependencies>
|
<dependencies>
|
||||||
|
<dependency>
|
||||||
|
<!--TODO: remove, when spring-boot fixed dependency to 6.0.8+ (6.0.7 has CVE) -->
|
||||||
|
<groupId>org.springframework</groupId>
|
||||||
|
<artifactId>spring-core</artifactId>
|
||||||
|
<version>6.0.8</version>
|
||||||
|
</dependency>
|
||||||
<dependency>
|
<dependency>
|
||||||
<groupId>org.springframework.boot</groupId>
|
<groupId>org.springframework.boot</groupId>
|
||||||
<artifactId>spring-boot-starter-webflux</artifactId>
|
<artifactId>spring-boot-starter-webflux</artifactId>
|
||||||
|
@ -109,6 +115,12 @@
|
||||||
<groupId>io.projectreactor.addons</groupId>
|
<groupId>io.projectreactor.addons</groupId>
|
||||||
<artifactId>reactor-extra</artifactId>
|
<artifactId>reactor-extra</artifactId>
|
||||||
</dependency>
|
</dependency>
|
||||||
|
<!-- https://github.com/provectus/kafka-ui/pull/3693 -->
|
||||||
|
<dependency>
|
||||||
|
<groupId>org.json</groupId>
|
||||||
|
<artifactId>json</artifactId>
|
||||||
|
<version>${org.json.version}</version>
|
||||||
|
</dependency>
|
||||||
|
|
||||||
<dependency>
|
<dependency>
|
||||||
<groupId>org.springframework.boot</groupId>
|
<groupId>org.springframework.boot</groupId>
|
||||||
|
|
|
@ -131,8 +131,9 @@ public class ClustersProperties {
|
||||||
@Data
|
@Data
|
||||||
public static class Masking {
|
public static class Masking {
|
||||||
Type type;
|
Type type;
|
||||||
List<String> fields; //if null or empty list - policy will be applied to all fields
|
List<String> fields;
|
||||||
List<String> pattern; //used when type=MASK
|
String fieldsNamePattern;
|
||||||
|
List<String> maskingCharsReplacement; //used when type=MASK
|
||||||
String replacement; //used when type=REPLACE
|
String replacement; //used when type=REPLACE
|
||||||
String topicKeysPattern;
|
String topicKeysPattern;
|
||||||
String topicValuesPattern;
|
String topicValuesPattern;
|
||||||
|
|
|
@ -0,0 +1,26 @@
|
||||||
|
package com.provectus.kafka.ui.config.auth;
|
||||||
|
|
||||||
|
import lombok.Data;
|
||||||
|
import org.springframework.beans.factory.annotation.Value;
|
||||||
|
import org.springframework.boot.context.properties.ConfigurationProperties;
|
||||||
|
|
||||||
|
@ConfigurationProperties("spring.ldap")
|
||||||
|
@Data
|
||||||
|
public class LdapProperties {
|
||||||
|
|
||||||
|
private String urls;
|
||||||
|
private String base;
|
||||||
|
private String adminUser;
|
||||||
|
private String adminPassword;
|
||||||
|
private String userFilterSearchBase;
|
||||||
|
private String userFilterSearchFilter;
|
||||||
|
|
||||||
|
@Value("${oauth2.ldap.activeDirectory:false}")
|
||||||
|
private boolean isActiveDirectory;
|
||||||
|
@Value("${oauth2.ldap.aсtiveDirectory.domain:@null}")
|
||||||
|
private String activeDirectoryDomain;
|
||||||
|
|
||||||
|
@Value("${oauth2.ldap.groupRoleAttribute:cn}")
|
||||||
|
private String groupRoleAttribute;
|
||||||
|
|
||||||
|
}
|
|
@ -1,13 +1,23 @@
|
||||||
package com.provectus.kafka.ui.config.auth;
|
package com.provectus.kafka.ui.config.auth;
|
||||||
|
|
||||||
|
import static com.provectus.kafka.ui.config.auth.AbstractAuthSecurityConfig.AUTH_WHITELIST;
|
||||||
|
|
||||||
|
import com.provectus.kafka.ui.service.rbac.AccessControlService;
|
||||||
|
import com.provectus.kafka.ui.service.rbac.extractor.RbacLdapAuthoritiesExtractor;
|
||||||
|
import java.util.Collection;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
|
import javax.annotation.Nullable;
|
||||||
|
import lombok.RequiredArgsConstructor;
|
||||||
import lombok.extern.slf4j.Slf4j;
|
import lombok.extern.slf4j.Slf4j;
|
||||||
import org.springframework.beans.factory.annotation.Value;
|
|
||||||
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
||||||
import org.springframework.boot.autoconfigure.ldap.LdapAutoConfiguration;
|
import org.springframework.boot.autoconfigure.ldap.LdapAutoConfiguration;
|
||||||
|
import org.springframework.boot.context.properties.EnableConfigurationProperties;
|
||||||
|
import org.springframework.context.ApplicationContext;
|
||||||
import org.springframework.context.annotation.Bean;
|
import org.springframework.context.annotation.Bean;
|
||||||
import org.springframework.context.annotation.Configuration;
|
import org.springframework.context.annotation.Configuration;
|
||||||
import org.springframework.context.annotation.Import;
|
import org.springframework.context.annotation.Import;
|
||||||
|
import org.springframework.context.annotation.Primary;
|
||||||
|
import org.springframework.ldap.core.DirContextOperations;
|
||||||
import org.springframework.ldap.core.support.BaseLdapPathContextSource;
|
import org.springframework.ldap.core.support.BaseLdapPathContextSource;
|
||||||
import org.springframework.ldap.core.support.LdapContextSource;
|
import org.springframework.ldap.core.support.LdapContextSource;
|
||||||
import org.springframework.security.authentication.AuthenticationManager;
|
import org.springframework.security.authentication.AuthenticationManager;
|
||||||
|
@ -16,70 +26,71 @@ import org.springframework.security.authentication.ReactiveAuthenticationManager
|
||||||
import org.springframework.security.authentication.ReactiveAuthenticationManagerAdapter;
|
import org.springframework.security.authentication.ReactiveAuthenticationManagerAdapter;
|
||||||
import org.springframework.security.config.annotation.web.reactive.EnableWebFluxSecurity;
|
import org.springframework.security.config.annotation.web.reactive.EnableWebFluxSecurity;
|
||||||
import org.springframework.security.config.web.server.ServerHttpSecurity;
|
import org.springframework.security.config.web.server.ServerHttpSecurity;
|
||||||
|
import org.springframework.security.core.GrantedAuthority;
|
||||||
|
import org.springframework.security.core.userdetails.UserDetails;
|
||||||
import org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider;
|
import org.springframework.security.ldap.authentication.AbstractLdapAuthenticationProvider;
|
||||||
import org.springframework.security.ldap.authentication.BindAuthenticator;
|
import org.springframework.security.ldap.authentication.BindAuthenticator;
|
||||||
import org.springframework.security.ldap.authentication.LdapAuthenticationProvider;
|
import org.springframework.security.ldap.authentication.LdapAuthenticationProvider;
|
||||||
import org.springframework.security.ldap.authentication.ad.ActiveDirectoryLdapAuthenticationProvider;
|
import org.springframework.security.ldap.authentication.ad.ActiveDirectoryLdapAuthenticationProvider;
|
||||||
import org.springframework.security.ldap.search.FilterBasedLdapUserSearch;
|
import org.springframework.security.ldap.search.FilterBasedLdapUserSearch;
|
||||||
import org.springframework.security.ldap.search.LdapUserSearch;
|
import org.springframework.security.ldap.search.LdapUserSearch;
|
||||||
|
import org.springframework.security.ldap.userdetails.LdapUserDetailsMapper;
|
||||||
import org.springframework.security.web.server.SecurityWebFilterChain;
|
import org.springframework.security.web.server.SecurityWebFilterChain;
|
||||||
|
|
||||||
@Configuration
|
@Configuration
|
||||||
@EnableWebFluxSecurity
|
@EnableWebFluxSecurity
|
||||||
@ConditionalOnProperty(value = "auth.type", havingValue = "LDAP")
|
@ConditionalOnProperty(value = "auth.type", havingValue = "LDAP")
|
||||||
@Import(LdapAutoConfiguration.class)
|
@Import(LdapAutoConfiguration.class)
|
||||||
|
@EnableConfigurationProperties(LdapProperties.class)
|
||||||
|
@RequiredArgsConstructor
|
||||||
@Slf4j
|
@Slf4j
|
||||||
public class LdapSecurityConfig extends AbstractAuthSecurityConfig {
|
public class LdapSecurityConfig {
|
||||||
|
|
||||||
@Value("${spring.ldap.urls}")
|
private final LdapProperties props;
|
||||||
private String ldapUrls;
|
|
||||||
@Value("${spring.ldap.dn.pattern:#{null}}")
|
|
||||||
private String ldapUserDnPattern;
|
|
||||||
@Value("${spring.ldap.adminUser:#{null}}")
|
|
||||||
private String adminUser;
|
|
||||||
@Value("${spring.ldap.adminPassword:#{null}}")
|
|
||||||
private String adminPassword;
|
|
||||||
@Value("${spring.ldap.userFilter.searchBase:#{null}}")
|
|
||||||
private String userFilterSearchBase;
|
|
||||||
@Value("${spring.ldap.userFilter.searchFilter:#{null}}")
|
|
||||||
private String userFilterSearchFilter;
|
|
||||||
|
|
||||||
@Value("${oauth2.ldap.activeDirectory:false}")
|
|
||||||
private boolean isActiveDirectory;
|
|
||||||
@Value("${oauth2.ldap.aсtiveDirectory.domain:#{null}}")
|
|
||||||
private String activeDirectoryDomain;
|
|
||||||
|
|
||||||
@Bean
|
@Bean
|
||||||
public ReactiveAuthenticationManager authenticationManager(BaseLdapPathContextSource contextSource) {
|
public ReactiveAuthenticationManager authenticationManager(BaseLdapPathContextSource contextSource,
|
||||||
|
ApplicationContext context,
|
||||||
|
@Nullable AccessControlService acs) {
|
||||||
|
var rbacEnabled = acs != null && acs.isRbacEnabled();
|
||||||
BindAuthenticator ba = new BindAuthenticator(contextSource);
|
BindAuthenticator ba = new BindAuthenticator(contextSource);
|
||||||
if (ldapUserDnPattern != null) {
|
if (props.getBase() != null) {
|
||||||
ba.setUserDnPatterns(new String[] {ldapUserDnPattern});
|
ba.setUserDnPatterns(new String[] {props.getBase()});
|
||||||
}
|
}
|
||||||
if (userFilterSearchFilter != null) {
|
if (props.getUserFilterSearchFilter() != null) {
|
||||||
LdapUserSearch userSearch =
|
LdapUserSearch userSearch =
|
||||||
new FilterBasedLdapUserSearch(userFilterSearchBase, userFilterSearchFilter, contextSource);
|
new FilterBasedLdapUserSearch(props.getUserFilterSearchBase(), props.getUserFilterSearchFilter(),
|
||||||
|
contextSource);
|
||||||
ba.setUserSearch(userSearch);
|
ba.setUserSearch(userSearch);
|
||||||
}
|
}
|
||||||
|
|
||||||
AbstractLdapAuthenticationProvider authenticationProvider;
|
AbstractLdapAuthenticationProvider authenticationProvider;
|
||||||
if (!isActiveDirectory) {
|
if (!props.isActiveDirectory()) {
|
||||||
authenticationProvider = new LdapAuthenticationProvider(ba);
|
authenticationProvider = rbacEnabled
|
||||||
|
? new LdapAuthenticationProvider(ba, new RbacLdapAuthoritiesExtractor(context))
|
||||||
|
: new LdapAuthenticationProvider(ba);
|
||||||
} else {
|
} else {
|
||||||
authenticationProvider = new ActiveDirectoryLdapAuthenticationProvider(activeDirectoryDomain, ldapUrls);
|
authenticationProvider = new ActiveDirectoryLdapAuthenticationProvider(props.getActiveDirectoryDomain(),
|
||||||
|
props.getUrls()); // TODO Issue #3741
|
||||||
authenticationProvider.setUseAuthenticationRequestCredentials(true);
|
authenticationProvider.setUseAuthenticationRequestCredentials(true);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (rbacEnabled) {
|
||||||
|
authenticationProvider.setUserDetailsContextMapper(new UserDetailsMapper());
|
||||||
|
}
|
||||||
|
|
||||||
AuthenticationManager am = new ProviderManager(List.of(authenticationProvider));
|
AuthenticationManager am = new ProviderManager(List.of(authenticationProvider));
|
||||||
|
|
||||||
return new ReactiveAuthenticationManagerAdapter(am);
|
return new ReactiveAuthenticationManagerAdapter(am);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Bean
|
@Bean
|
||||||
|
@Primary
|
||||||
public BaseLdapPathContextSource contextSource() {
|
public BaseLdapPathContextSource contextSource() {
|
||||||
LdapContextSource ctx = new LdapContextSource();
|
LdapContextSource ctx = new LdapContextSource();
|
||||||
ctx.setUrl(ldapUrls);
|
ctx.setUrl(props.getUrls());
|
||||||
ctx.setUserDn(adminUser);
|
ctx.setUserDn(props.getAdminUser());
|
||||||
ctx.setPassword(adminPassword);
|
ctx.setPassword(props.getAdminPassword());
|
||||||
ctx.afterPropertiesSet();
|
ctx.afterPropertiesSet();
|
||||||
return ctx;
|
return ctx;
|
||||||
}
|
}
|
||||||
|
@ -87,20 +98,35 @@ public class LdapSecurityConfig extends AbstractAuthSecurityConfig {
|
||||||
@Bean
|
@Bean
|
||||||
public SecurityWebFilterChain configureLdap(ServerHttpSecurity http) {
|
public SecurityWebFilterChain configureLdap(ServerHttpSecurity http) {
|
||||||
log.info("Configuring LDAP authentication.");
|
log.info("Configuring LDAP authentication.");
|
||||||
if (isActiveDirectory) {
|
if (props.isActiveDirectory()) {
|
||||||
log.info("Active Directory support for LDAP has been enabled.");
|
log.info("Active Directory support for LDAP has been enabled.");
|
||||||
}
|
}
|
||||||
|
|
||||||
http
|
return http
|
||||||
.authorizeExchange()
|
.authorizeExchange()
|
||||||
.pathMatchers(AUTH_WHITELIST)
|
.pathMatchers(AUTH_WHITELIST)
|
||||||
.permitAll()
|
.permitAll()
|
||||||
.anyExchange()
|
.anyExchange()
|
||||||
.authenticated()
|
.authenticated()
|
||||||
|
|
||||||
.and()
|
.and()
|
||||||
.httpBasic();
|
.formLogin()
|
||||||
|
|
||||||
return http.csrf().disable().build();
|
.and()
|
||||||
|
.logout()
|
||||||
|
|
||||||
|
.and()
|
||||||
|
.csrf().disable()
|
||||||
|
.build();
|
||||||
|
}
|
||||||
|
|
||||||
|
private static class UserDetailsMapper extends LdapUserDetailsMapper {
|
||||||
|
@Override
|
||||||
|
public UserDetails mapUserFromContext(DirContextOperations ctx, String username,
|
||||||
|
Collection<? extends GrantedAuthority> authorities) {
|
||||||
|
UserDetails userDetails = super.mapUserFromContext(ctx, username, authorities);
|
||||||
|
return new RbacLdapUser(userDetails);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -115,7 +115,7 @@ public class OAuthSecurityConfig extends AbstractAuthSecurityConfig {
|
||||||
@Nullable
|
@Nullable
|
||||||
private ProviderAuthorityExtractor getExtractor(final String providerId, AccessControlService acs) {
|
private ProviderAuthorityExtractor getExtractor(final String providerId, AccessControlService acs) {
|
||||||
final String provider = getProviderByProviderId(providerId);
|
final String provider = getProviderByProviderId(providerId);
|
||||||
Optional<ProviderAuthorityExtractor> extractor = acs.getExtractors()
|
Optional<ProviderAuthorityExtractor> extractor = acs.getOauthExtractors()
|
||||||
.stream()
|
.stream()
|
||||||
.filter(e -> e.isApplicable(provider))
|
.filter(e -> e.isApplicable(provider))
|
||||||
.findFirst();
|
.findFirst();
|
||||||
|
|
|
@ -0,0 +1,60 @@
|
||||||
|
package com.provectus.kafka.ui.config.auth;
|
||||||
|
|
||||||
|
import java.util.Collection;
|
||||||
|
import java.util.stream.Collectors;
|
||||||
|
import org.springframework.security.core.GrantedAuthority;
|
||||||
|
import org.springframework.security.core.userdetails.UserDetails;
|
||||||
|
|
||||||
|
public class RbacLdapUser implements UserDetails, RbacUser {
|
||||||
|
|
||||||
|
private final UserDetails userDetails;
|
||||||
|
|
||||||
|
public RbacLdapUser(UserDetails userDetails) {
|
||||||
|
this.userDetails = userDetails;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String name() {
|
||||||
|
return userDetails.getUsername();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Collection<String> groups() {
|
||||||
|
return userDetails.getAuthorities().stream().map(GrantedAuthority::getAuthority).collect(Collectors.toSet());
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Collection<? extends GrantedAuthority> getAuthorities() {
|
||||||
|
return userDetails.getAuthorities();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getPassword() {
|
||||||
|
return userDetails.getPassword();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getUsername() {
|
||||||
|
return userDetails.getUsername();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public boolean isAccountNonExpired() {
|
||||||
|
return userDetails.isAccountNonExpired();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public boolean isAccountNonLocked() {
|
||||||
|
return userDetails.isAccountNonLocked();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public boolean isCredentialsNonExpired() {
|
||||||
|
return userDetails.isCredentialsNonExpired();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public boolean isEnabled() {
|
||||||
|
return userDetails.isEnabled();
|
||||||
|
}
|
||||||
|
}
|
|
@ -0,0 +1,21 @@
|
||||||
|
package com.provectus.kafka.ui.config.auth.condition;
|
||||||
|
|
||||||
|
import org.springframework.boot.autoconfigure.condition.AllNestedConditions;
|
||||||
|
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
|
||||||
|
|
||||||
|
public class ActiveDirectoryCondition extends AllNestedConditions {
|
||||||
|
|
||||||
|
public ActiveDirectoryCondition() {
|
||||||
|
super(ConfigurationPhase.PARSE_CONFIGURATION);
|
||||||
|
}
|
||||||
|
|
||||||
|
@ConditionalOnProperty(value = "auth.type", havingValue = "LDAP")
|
||||||
|
public static class OnAuthType {
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
@ConditionalOnProperty(value = "${oauth2.ldap.activeDirectory}:false", havingValue = "true", matchIfMissing = false)
|
||||||
|
public static class OnActiveDirectory {
|
||||||
|
|
||||||
|
}
|
||||||
|
}
|
|
@ -123,11 +123,11 @@ public class ConsumerRecordDeserializer {
|
||||||
}
|
}
|
||||||
|
|
||||||
private static Long getKeySize(ConsumerRecord<Bytes, Bytes> consumerRecord) {
|
private static Long getKeySize(ConsumerRecord<Bytes, Bytes> consumerRecord) {
|
||||||
return consumerRecord.key() != null ? (long) consumerRecord.key().get().length : null;
|
return consumerRecord.key() != null ? (long) consumerRecord.serializedKeySize() : null;
|
||||||
}
|
}
|
||||||
|
|
||||||
private static Long getValueSize(ConsumerRecord<Bytes, Bytes> consumerRecord) {
|
private static Long getValueSize(ConsumerRecord<Bytes, Bytes> consumerRecord) {
|
||||||
return consumerRecord.value() != null ? (long) consumerRecord.value().get().length : null;
|
return consumerRecord.value() != null ? (long) consumerRecord.serializedValueSize() : null;
|
||||||
}
|
}
|
||||||
|
|
||||||
private static int headerSize(Header header) {
|
private static int headerSize(Header header) {
|
||||||
|
|
|
@ -122,8 +122,6 @@ public class SerdesInitializer {
|
||||||
registeredSerdes,
|
registeredSerdes,
|
||||||
Optional.ofNullable(clusterProperties.getDefaultKeySerde())
|
Optional.ofNullable(clusterProperties.getDefaultKeySerde())
|
||||||
.map(name -> Preconditions.checkNotNull(registeredSerdes.get(name), "Default key serde not found"))
|
.map(name -> Preconditions.checkNotNull(registeredSerdes.get(name), "Default key serde not found"))
|
||||||
.or(() -> Optional.ofNullable(registeredSerdes.get(SchemaRegistrySerde.name())))
|
|
||||||
.or(() -> Optional.ofNullable(registeredSerdes.get(ProtobufFileSerde.name())))
|
|
||||||
.orElse(null),
|
.orElse(null),
|
||||||
Optional.ofNullable(clusterProperties.getDefaultValueSerde())
|
Optional.ofNullable(clusterProperties.getDefaultValueSerde())
|
||||||
.map(name -> Preconditions.checkNotNull(registeredSerdes.get(name), "Default value serde not found"))
|
.map(name -> Preconditions.checkNotNull(registeredSerdes.get(name), "Default value serde not found"))
|
||||||
|
|
|
@ -109,6 +109,7 @@ public class KafkaConnectService {
|
||||||
private Stream<String> getStringsForSearch(FullConnectorInfoDTO fullConnectorInfo) {
|
private Stream<String> getStringsForSearch(FullConnectorInfoDTO fullConnectorInfo) {
|
||||||
return Stream.of(
|
return Stream.of(
|
||||||
fullConnectorInfo.getName(),
|
fullConnectorInfo.getName(),
|
||||||
|
fullConnectorInfo.getConnect(),
|
||||||
fullConnectorInfo.getStatus().getState().getValue(),
|
fullConnectorInfo.getStatus().getState().getValue(),
|
||||||
fullConnectorInfo.getType().getValue());
|
fullConnectorInfo.getType().getValue());
|
||||||
}
|
}
|
||||||
|
|
|
@ -43,8 +43,7 @@ class TopicAnalysisStats {
|
||||||
Long max;
|
Long max;
|
||||||
final UpdateDoublesSketch sizeSketch = DoublesSketch.builder().build();
|
final UpdateDoublesSketch sizeSketch = DoublesSketch.builder().build();
|
||||||
|
|
||||||
void apply(byte[] bytes) {
|
void apply(int len) {
|
||||||
int len = bytes.length;
|
|
||||||
sum += len;
|
sum += len;
|
||||||
min = minNullable(min, len);
|
min = minNullable(min, len);
|
||||||
max = maxNullable(max, len);
|
max = maxNullable(max, len);
|
||||||
|
@ -98,7 +97,7 @@ class TopicAnalysisStats {
|
||||||
|
|
||||||
if (rec.key() != null) {
|
if (rec.key() != null) {
|
||||||
byte[] keyBytes = rec.key().get();
|
byte[] keyBytes = rec.key().get();
|
||||||
keysSize.apply(keyBytes);
|
keysSize.apply(rec.serializedKeySize());
|
||||||
uniqKeys.update(keyBytes);
|
uniqKeys.update(keyBytes);
|
||||||
} else {
|
} else {
|
||||||
nullKeys++;
|
nullKeys++;
|
||||||
|
@ -106,7 +105,7 @@ class TopicAnalysisStats {
|
||||||
|
|
||||||
if (rec.value() != null) {
|
if (rec.value() != null) {
|
||||||
byte[] valueBytes = rec.value().get();
|
byte[] valueBytes = rec.value().get();
|
||||||
valuesSize.apply(valueBytes);
|
valuesSize.apply(rec.serializedValueSize());
|
||||||
uniqValues.update(valueBytes);
|
uniqValues.update(valueBytes);
|
||||||
} else {
|
} else {
|
||||||
nullValues++;
|
nullValues++;
|
||||||
|
|
|
@ -44,7 +44,7 @@ public class DataMasking {
|
||||||
public static DataMasking create(@Nullable List<ClustersProperties.Masking> config) {
|
public static DataMasking create(@Nullable List<ClustersProperties.Masking> config) {
|
||||||
return new DataMasking(
|
return new DataMasking(
|
||||||
Optional.ofNullable(config).orElse(List.of()).stream().map(property -> {
|
Optional.ofNullable(config).orElse(List.of()).stream().map(property -> {
|
||||||
Preconditions.checkNotNull(property.getType(), "masking type not specifed");
|
Preconditions.checkNotNull(property.getType(), "masking type not specified");
|
||||||
Preconditions.checkArgument(
|
Preconditions.checkArgument(
|
||||||
StringUtils.isNotEmpty(property.getTopicKeysPattern())
|
StringUtils.isNotEmpty(property.getTopicKeysPattern())
|
||||||
|| StringUtils.isNotEmpty(property.getTopicValuesPattern()),
|
|| StringUtils.isNotEmpty(property.getTopicValuesPattern()),
|
||||||
|
|
|
@ -0,0 +1,28 @@
|
||||||
|
package com.provectus.kafka.ui.service.masking.policies;
|
||||||
|
|
||||||
|
import com.provectus.kafka.ui.config.ClustersProperties;
|
||||||
|
import com.provectus.kafka.ui.exception.ValidationException;
|
||||||
|
import java.util.regex.Pattern;
|
||||||
|
import org.springframework.util.CollectionUtils;
|
||||||
|
import org.springframework.util.StringUtils;
|
||||||
|
|
||||||
|
interface FieldsSelector {
|
||||||
|
|
||||||
|
static FieldsSelector create(ClustersProperties.Masking property) {
|
||||||
|
if (StringUtils.hasText(property.getFieldsNamePattern()) && !CollectionUtils.isEmpty(property.getFields())) {
|
||||||
|
throw new ValidationException("You can't provide both fieldNames & fieldsNamePattern for masking");
|
||||||
|
}
|
||||||
|
if (StringUtils.hasText(property.getFieldsNamePattern())) {
|
||||||
|
Pattern pattern = Pattern.compile(property.getFieldsNamePattern());
|
||||||
|
return f -> pattern.matcher(f).matches();
|
||||||
|
}
|
||||||
|
if (!CollectionUtils.isEmpty(property.getFields())) {
|
||||||
|
return f -> property.getFields().contains(f);
|
||||||
|
}
|
||||||
|
//no pattern, no field names - mean all fields should be masked
|
||||||
|
return fieldName -> true;
|
||||||
|
}
|
||||||
|
|
||||||
|
boolean shouldBeMasked(String fieldName);
|
||||||
|
|
||||||
|
}
|
|
@ -15,8 +15,8 @@ class Mask extends MaskingPolicy {
|
||||||
|
|
||||||
private final UnaryOperator<String> masker;
|
private final UnaryOperator<String> masker;
|
||||||
|
|
||||||
Mask(List<String> fieldNames, List<String> maskingChars) {
|
Mask(FieldsSelector fieldsSelector, List<String> maskingChars) {
|
||||||
super(fieldNames);
|
super(fieldsSelector);
|
||||||
this.masker = createMasker(maskingChars);
|
this.masker = createMasker(maskingChars);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -38,22 +38,13 @@ class Mask extends MaskingPolicy {
|
||||||
for (int i = 0; i < input.length(); i++) {
|
for (int i = 0; i < input.length(); i++) {
|
||||||
int cp = input.codePointAt(i);
|
int cp = input.codePointAt(i);
|
||||||
switch (Character.getType(cp)) {
|
switch (Character.getType(cp)) {
|
||||||
case Character.SPACE_SEPARATOR:
|
case Character.SPACE_SEPARATOR,
|
||||||
case Character.LINE_SEPARATOR:
|
Character.LINE_SEPARATOR,
|
||||||
case Character.PARAGRAPH_SEPARATOR:
|
Character.PARAGRAPH_SEPARATOR -> sb.appendCodePoint(cp); // keeping separators as-is
|
||||||
sb.appendCodePoint(cp); // keeping separators as-is
|
case Character.UPPERCASE_LETTER -> sb.append(maskingChars.get(0));
|
||||||
break;
|
case Character.LOWERCASE_LETTER -> sb.append(maskingChars.get(1));
|
||||||
case Character.UPPERCASE_LETTER:
|
case Character.DECIMAL_DIGIT_NUMBER -> sb.append(maskingChars.get(2));
|
||||||
sb.append(maskingChars.get(0));
|
default -> sb.append(maskingChars.get(3));
|
||||||
break;
|
|
||||||
case Character.LOWERCASE_LETTER:
|
|
||||||
sb.append(maskingChars.get(1));
|
|
||||||
break;
|
|
||||||
case Character.DECIMAL_DIGIT_NUMBER:
|
|
||||||
sb.append(maskingChars.get(2));
|
|
||||||
break;
|
|
||||||
default:
|
|
||||||
sb.append(maskingChars.get(3));
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return sb.toString();
|
return sb.toString();
|
||||||
|
|
|
@ -2,46 +2,36 @@ package com.provectus.kafka.ui.service.masking.policies;
|
||||||
|
|
||||||
import com.fasterxml.jackson.databind.node.ContainerNode;
|
import com.fasterxml.jackson.databind.node.ContainerNode;
|
||||||
import com.provectus.kafka.ui.config.ClustersProperties;
|
import com.provectus.kafka.ui.config.ClustersProperties;
|
||||||
import java.util.List;
|
|
||||||
import lombok.RequiredArgsConstructor;
|
import lombok.RequiredArgsConstructor;
|
||||||
|
|
||||||
@RequiredArgsConstructor
|
@RequiredArgsConstructor
|
||||||
public abstract class MaskingPolicy {
|
public abstract class MaskingPolicy {
|
||||||
|
|
||||||
|
|
||||||
public static MaskingPolicy create(ClustersProperties.Masking property) {
|
public static MaskingPolicy create(ClustersProperties.Masking property) {
|
||||||
List<String> fields = property.getFields() == null
|
FieldsSelector fieldsSelector = FieldsSelector.create(property);
|
||||||
? List.of() // empty list means that policy will be applied to all fields
|
return switch (property.getType()) {
|
||||||
: property.getFields();
|
case REMOVE -> new Remove(fieldsSelector);
|
||||||
switch (property.getType()) {
|
case REPLACE -> new Replace(
|
||||||
case REMOVE:
|
fieldsSelector,
|
||||||
return new Remove(fields);
|
|
||||||
case REPLACE:
|
|
||||||
return new Replace(
|
|
||||||
fields,
|
|
||||||
property.getReplacement() == null
|
property.getReplacement() == null
|
||||||
? Replace.DEFAULT_REPLACEMENT
|
? Replace.DEFAULT_REPLACEMENT
|
||||||
: property.getReplacement()
|
: property.getReplacement()
|
||||||
);
|
);
|
||||||
case MASK:
|
case MASK -> new Mask(
|
||||||
return new Mask(
|
fieldsSelector,
|
||||||
fields,
|
property.getMaskingCharsReplacement() == null
|
||||||
property.getPattern() == null
|
|
||||||
? Mask.DEFAULT_PATTERN
|
? Mask.DEFAULT_PATTERN
|
||||||
: property.getPattern()
|
: property.getMaskingCharsReplacement()
|
||||||
);
|
);
|
||||||
default:
|
};
|
||||||
throw new IllegalStateException("Unknown policy type: " + property.getType());
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
//----------------------------------------------------------------
|
//----------------------------------------------------------------
|
||||||
|
|
||||||
// empty list means policy will be applied to all fields
|
private final FieldsSelector fieldsSelector;
|
||||||
private final List<String> fieldNames;
|
|
||||||
|
|
||||||
protected boolean fieldShouldBeMasked(String fieldName) {
|
protected boolean fieldShouldBeMasked(String fieldName) {
|
||||||
return fieldNames.isEmpty() || fieldNames.contains(fieldName);
|
return fieldsSelector.shouldBeMasked(fieldName);
|
||||||
}
|
}
|
||||||
|
|
||||||
public abstract ContainerNode<?> applyToJsonContainer(ContainerNode<?> node);
|
public abstract ContainerNode<?> applyToJsonContainer(ContainerNode<?> node);
|
||||||
|
|
|
@ -4,12 +4,12 @@ import com.fasterxml.jackson.databind.JsonNode;
|
||||||
import com.fasterxml.jackson.databind.node.ArrayNode;
|
import com.fasterxml.jackson.databind.node.ArrayNode;
|
||||||
import com.fasterxml.jackson.databind.node.ContainerNode;
|
import com.fasterxml.jackson.databind.node.ContainerNode;
|
||||||
import com.fasterxml.jackson.databind.node.ObjectNode;
|
import com.fasterxml.jackson.databind.node.ObjectNode;
|
||||||
import java.util.List;
|
|
||||||
|
|
||||||
class Remove extends MaskingPolicy {
|
class Remove extends MaskingPolicy {
|
||||||
|
|
||||||
Remove(List<String> fieldNames) {
|
Remove(FieldsSelector fieldsSelector) {
|
||||||
super(fieldNames);
|
super(fieldsSelector);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|
|
@ -6,7 +6,6 @@ import com.fasterxml.jackson.databind.node.ContainerNode;
|
||||||
import com.fasterxml.jackson.databind.node.ObjectNode;
|
import com.fasterxml.jackson.databind.node.ObjectNode;
|
||||||
import com.fasterxml.jackson.databind.node.TextNode;
|
import com.fasterxml.jackson.databind.node.TextNode;
|
||||||
import com.google.common.base.Preconditions;
|
import com.google.common.base.Preconditions;
|
||||||
import java.util.List;
|
|
||||||
|
|
||||||
class Replace extends MaskingPolicy {
|
class Replace extends MaskingPolicy {
|
||||||
|
|
||||||
|
@ -14,8 +13,8 @@ class Replace extends MaskingPolicy {
|
||||||
|
|
||||||
private final String replacement;
|
private final String replacement;
|
||||||
|
|
||||||
Replace(List<String> fieldNames, String replacementString) {
|
Replace(FieldsSelector fieldsSelector, String replacementString) {
|
||||||
super(fieldNames);
|
super(fieldsSelector);
|
||||||
this.replacement = Preconditions.checkNotNull(replacementString);
|
this.replacement = Preconditions.checkNotNull(replacementString);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -12,6 +12,7 @@ import com.provectus.kafka.ui.model.rbac.AccessContext;
|
||||||
import com.provectus.kafka.ui.model.rbac.Permission;
|
import com.provectus.kafka.ui.model.rbac.Permission;
|
||||||
import com.provectus.kafka.ui.model.rbac.Resource;
|
import com.provectus.kafka.ui.model.rbac.Resource;
|
||||||
import com.provectus.kafka.ui.model.rbac.Role;
|
import com.provectus.kafka.ui.model.rbac.Role;
|
||||||
|
import com.provectus.kafka.ui.model.rbac.Subject;
|
||||||
import com.provectus.kafka.ui.model.rbac.permission.ConnectAction;
|
import com.provectus.kafka.ui.model.rbac.permission.ConnectAction;
|
||||||
import com.provectus.kafka.ui.model.rbac.permission.ConsumerGroupAction;
|
import com.provectus.kafka.ui.model.rbac.permission.ConsumerGroupAction;
|
||||||
import com.provectus.kafka.ui.model.rbac.permission.SchemaAction;
|
import com.provectus.kafka.ui.model.rbac.permission.SchemaAction;
|
||||||
|
@ -19,11 +20,11 @@ import com.provectus.kafka.ui.model.rbac.permission.TopicAction;
|
||||||
import com.provectus.kafka.ui.service.rbac.extractor.CognitoAuthorityExtractor;
|
import com.provectus.kafka.ui.service.rbac.extractor.CognitoAuthorityExtractor;
|
||||||
import com.provectus.kafka.ui.service.rbac.extractor.GithubAuthorityExtractor;
|
import com.provectus.kafka.ui.service.rbac.extractor.GithubAuthorityExtractor;
|
||||||
import com.provectus.kafka.ui.service.rbac.extractor.GoogleAuthorityExtractor;
|
import com.provectus.kafka.ui.service.rbac.extractor.GoogleAuthorityExtractor;
|
||||||
import com.provectus.kafka.ui.service.rbac.extractor.LdapAuthorityExtractor;
|
|
||||||
import com.provectus.kafka.ui.service.rbac.extractor.ProviderAuthorityExtractor;
|
import com.provectus.kafka.ui.service.rbac.extractor.ProviderAuthorityExtractor;
|
||||||
import jakarta.annotation.PostConstruct;
|
import jakarta.annotation.PostConstruct;
|
||||||
import java.util.Collections;
|
import java.util.Collections;
|
||||||
import java.util.List;
|
import java.util.List;
|
||||||
|
import java.util.Objects;
|
||||||
import java.util.Set;
|
import java.util.Set;
|
||||||
import java.util.function.Predicate;
|
import java.util.function.Predicate;
|
||||||
import java.util.regex.Pattern;
|
import java.util.regex.Pattern;
|
||||||
|
@ -34,6 +35,7 @@ import lombok.extern.slf4j.Slf4j;
|
||||||
import org.apache.commons.collections.CollectionUtils;
|
import org.apache.commons.collections.CollectionUtils;
|
||||||
import org.apache.commons.lang3.StringUtils;
|
import org.apache.commons.lang3.StringUtils;
|
||||||
import org.springframework.boot.context.properties.EnableConfigurationProperties;
|
import org.springframework.boot.context.properties.EnableConfigurationProperties;
|
||||||
|
import org.springframework.core.env.Environment;
|
||||||
import org.springframework.security.access.AccessDeniedException;
|
import org.springframework.security.access.AccessDeniedException;
|
||||||
import org.springframework.security.core.context.ReactiveSecurityContextHolder;
|
import org.springframework.security.core.context.ReactiveSecurityContextHolder;
|
||||||
import org.springframework.security.core.context.SecurityContext;
|
import org.springframework.security.core.context.SecurityContext;
|
||||||
|
@ -50,10 +52,11 @@ public class AccessControlService {
|
||||||
|
|
||||||
@Nullable
|
@Nullable
|
||||||
private final InMemoryReactiveClientRegistrationRepository clientRegistrationRepository;
|
private final InMemoryReactiveClientRegistrationRepository clientRegistrationRepository;
|
||||||
|
private final RoleBasedAccessControlProperties properties;
|
||||||
|
private final Environment environment;
|
||||||
|
|
||||||
private boolean rbacEnabled = false;
|
private boolean rbacEnabled = false;
|
||||||
private Set<ProviderAuthorityExtractor> extractors = Collections.emptySet();
|
private Set<ProviderAuthorityExtractor> oauthExtractors = Collections.emptySet();
|
||||||
private final RoleBasedAccessControlProperties properties;
|
|
||||||
|
|
||||||
@PostConstruct
|
@PostConstruct
|
||||||
public void init() {
|
public void init() {
|
||||||
|
@ -63,21 +66,26 @@ public class AccessControlService {
|
||||||
}
|
}
|
||||||
rbacEnabled = true;
|
rbacEnabled = true;
|
||||||
|
|
||||||
this.extractors = properties.getRoles()
|
this.oauthExtractors = properties.getRoles()
|
||||||
.stream()
|
.stream()
|
||||||
.map(role -> role.getSubjects()
|
.map(role -> role.getSubjects()
|
||||||
.stream()
|
.stream()
|
||||||
.map(provider -> switch (provider.getProvider()) {
|
.map(Subject::getProvider)
|
||||||
|
.distinct()
|
||||||
|
.map(provider -> switch (provider) {
|
||||||
case OAUTH_COGNITO -> new CognitoAuthorityExtractor();
|
case OAUTH_COGNITO -> new CognitoAuthorityExtractor();
|
||||||
case OAUTH_GOOGLE -> new GoogleAuthorityExtractor();
|
case OAUTH_GOOGLE -> new GoogleAuthorityExtractor();
|
||||||
case OAUTH_GITHUB -> new GithubAuthorityExtractor();
|
case OAUTH_GITHUB -> new GithubAuthorityExtractor();
|
||||||
case LDAP, LDAP_AD -> new LdapAuthorityExtractor();
|
default -> null;
|
||||||
}).collect(Collectors.toSet()))
|
})
|
||||||
|
.filter(Objects::nonNull)
|
||||||
|
.collect(Collectors.toSet()))
|
||||||
.flatMap(Set::stream)
|
.flatMap(Set::stream)
|
||||||
.collect(Collectors.toSet());
|
.collect(Collectors.toSet());
|
||||||
|
|
||||||
if ((clientRegistrationRepository == null || !clientRegistrationRepository.iterator().hasNext())
|
if (!properties.getRoles().isEmpty()
|
||||||
&& !properties.getRoles().isEmpty()) {
|
&& "oauth2".equalsIgnoreCase(environment.getProperty("auth.type"))
|
||||||
|
&& (clientRegistrationRepository == null || !clientRegistrationRepository.iterator().hasNext())) {
|
||||||
log.error("Roles are configured but no authentication methods are present. Authentication might fail.");
|
log.error("Roles are configured but no authentication methods are present. Authentication might fail.");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -354,8 +362,8 @@ public class AccessControlService {
|
||||||
return isAccessible(Resource.KSQL, null, user, context, requiredActions);
|
return isAccessible(Resource.KSQL, null, user, context, requiredActions);
|
||||||
}
|
}
|
||||||
|
|
||||||
public Set<ProviderAuthorityExtractor> getExtractors() {
|
public Set<ProviderAuthorityExtractor> getOauthExtractors() {
|
||||||
return extractors;
|
return oauthExtractors;
|
||||||
}
|
}
|
||||||
|
|
||||||
public List<Role> getRoles() {
|
public List<Role> getRoles() {
|
||||||
|
|
|
@ -1,23 +0,0 @@
|
||||||
package com.provectus.kafka.ui.service.rbac.extractor;
|
|
||||||
|
|
||||||
import com.provectus.kafka.ui.service.rbac.AccessControlService;
|
|
||||||
import java.util.Collections;
|
|
||||||
import java.util.Map;
|
|
||||||
import java.util.Set;
|
|
||||||
import lombok.extern.slf4j.Slf4j;
|
|
||||||
import reactor.core.publisher.Mono;
|
|
||||||
|
|
||||||
@Slf4j
|
|
||||||
public class LdapAuthorityExtractor implements ProviderAuthorityExtractor {
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public boolean isApplicable(String provider) {
|
|
||||||
return false; // TODO #2752
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public Mono<Set<String>> extract(AccessControlService acs, Object value, Map<String, Object> additionalParams) {
|
|
||||||
return Mono.just(Collections.emptySet()); // TODO #2752
|
|
||||||
}
|
|
||||||
|
|
||||||
}
|
|
|
@ -0,0 +1,70 @@
|
||||||
|
package com.provectus.kafka.ui.service.rbac.extractor;
|
||||||
|
|
||||||
|
import com.provectus.kafka.ui.config.auth.LdapProperties;
|
||||||
|
import com.provectus.kafka.ui.model.rbac.Role;
|
||||||
|
import com.provectus.kafka.ui.model.rbac.provider.Provider;
|
||||||
|
import com.provectus.kafka.ui.service.rbac.AccessControlService;
|
||||||
|
import java.util.List;
|
||||||
|
import java.util.Map;
|
||||||
|
import java.util.Set;
|
||||||
|
import java.util.function.Function;
|
||||||
|
import java.util.stream.Collectors;
|
||||||
|
import lombok.extern.slf4j.Slf4j;
|
||||||
|
import org.springframework.context.ApplicationContext;
|
||||||
|
import org.springframework.ldap.core.DirContextOperations;
|
||||||
|
import org.springframework.ldap.core.support.BaseLdapPathContextSource;
|
||||||
|
import org.springframework.security.core.GrantedAuthority;
|
||||||
|
import org.springframework.security.core.authority.SimpleGrantedAuthority;
|
||||||
|
import org.springframework.security.ldap.userdetails.DefaultLdapAuthoritiesPopulator;
|
||||||
|
import org.springframework.util.Assert;
|
||||||
|
|
||||||
|
@Slf4j
|
||||||
|
public class RbacLdapAuthoritiesExtractor extends DefaultLdapAuthoritiesPopulator {
|
||||||
|
|
||||||
|
private final AccessControlService acs;
|
||||||
|
private final LdapProperties props;
|
||||||
|
|
||||||
|
private final Function<Map<String, List<String>>, GrantedAuthority> authorityMapper = (record) -> {
|
||||||
|
String role = record.get(getGroupRoleAttribute()).get(0);
|
||||||
|
return new SimpleGrantedAuthority(role);
|
||||||
|
};
|
||||||
|
|
||||||
|
public RbacLdapAuthoritiesExtractor(ApplicationContext context) {
|
||||||
|
super(context.getBean(BaseLdapPathContextSource.class), null);
|
||||||
|
this.acs = context.getBean(AccessControlService.class);
|
||||||
|
this.props = context.getBean(LdapProperties.class);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public Set<GrantedAuthority> getAdditionalRoles(DirContextOperations user, String username) {
|
||||||
|
return acs.getRoles()
|
||||||
|
.stream()
|
||||||
|
.map(Role::getSubjects)
|
||||||
|
.flatMap(List::stream)
|
||||||
|
.filter(s -> s.getProvider().equals(Provider.LDAP))
|
||||||
|
.filter(s -> s.getType().equals("group"))
|
||||||
|
.flatMap(subject -> getRoles(subject.getValue(), user.getNameInNamespace(), username).stream())
|
||||||
|
.collect(Collectors.toSet());
|
||||||
|
}
|
||||||
|
|
||||||
|
private Set<GrantedAuthority> getRoles(String groupSearchBase, String userDn, String username) {
|
||||||
|
Assert.notNull(groupSearchBase, "groupSearchBase is empty");
|
||||||
|
|
||||||
|
log.trace(
|
||||||
|
"Searching for roles for user [{}] with DN [{}], groupRoleAttribute [{}] and filter [{}] in search base [{}]",
|
||||||
|
username, userDn, props.getGroupRoleAttribute(), getGroupSearchFilter(), groupSearchBase);
|
||||||
|
|
||||||
|
var ldapTemplate = getLdapTemplate();
|
||||||
|
ldapTemplate.setIgnoreNameNotFoundException(true);
|
||||||
|
|
||||||
|
Set<Map<String, List<String>>> userRoles = ldapTemplate.searchForMultipleAttributeValues(
|
||||||
|
groupSearchBase, getGroupSearchFilter(), new String[] {userDn, username},
|
||||||
|
new String[] {props.getGroupRoleAttribute()});
|
||||||
|
|
||||||
|
return userRoles.stream()
|
||||||
|
.map(authorityMapper)
|
||||||
|
.peek(a -> log.debug("Mapped role [{}] for user [{}]", a, username))
|
||||||
|
.collect(Collectors.toSet());
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
|
@ -0,0 +1,53 @@
|
||||||
|
package com.provectus.kafka.ui.service.masking.policies;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
import static org.assertj.core.api.Assertions.assertThatThrownBy;
|
||||||
|
|
||||||
|
import com.provectus.kafka.ui.config.ClustersProperties;
|
||||||
|
import com.provectus.kafka.ui.exception.ValidationException;
|
||||||
|
import java.util.List;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
|
||||||
|
class FieldsSelectorTest {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void selectsFieldsDueToProvidedPattern() {
|
||||||
|
var properties = new ClustersProperties.Masking();
|
||||||
|
properties.setFieldsNamePattern("f1|f2");
|
||||||
|
|
||||||
|
var selector = FieldsSelector.create(properties);
|
||||||
|
assertThat(selector.shouldBeMasked("f1")).isTrue();
|
||||||
|
assertThat(selector.shouldBeMasked("f2")).isTrue();
|
||||||
|
assertThat(selector.shouldBeMasked("doesNotMatchPattern")).isFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void selectsFieldsDueToProvidedFieldNames() {
|
||||||
|
var properties = new ClustersProperties.Masking();
|
||||||
|
properties.setFields(List.of("f1", "f2"));
|
||||||
|
|
||||||
|
var selector = FieldsSelector.create(properties);
|
||||||
|
assertThat(selector.shouldBeMasked("f1")).isTrue();
|
||||||
|
assertThat(selector.shouldBeMasked("f2")).isTrue();
|
||||||
|
assertThat(selector.shouldBeMasked("notInAList")).isFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void selectAllFieldsIfNoPatternAndNoNamesProvided() {
|
||||||
|
var properties = new ClustersProperties.Masking();
|
||||||
|
|
||||||
|
var selector = FieldsSelector.create(properties);
|
||||||
|
assertThat(selector.shouldBeMasked("anyPropertyName")).isTrue();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void throwsExceptionIfBothFieldListAndPatternProvided() {
|
||||||
|
var properties = new ClustersProperties.Masking();
|
||||||
|
properties.setFieldsNamePattern("f1|f2");
|
||||||
|
properties.setFields(List.of("f3", "f4"));
|
||||||
|
|
||||||
|
assertThatThrownBy(() -> FieldsSelector.create(properties))
|
||||||
|
.isInstanceOf(ValidationException.class);
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
|
@ -15,35 +15,35 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||||
|
|
||||||
class MaskTest {
|
class MaskTest {
|
||||||
|
|
||||||
private static final List<String> TARGET_FIELDS = List.of("id", "name");
|
private static final FieldsSelector FIELDS_SELECTOR = fieldName -> List.of("id", "name").contains(fieldName);
|
||||||
private static final List<String> PATTERN = List.of("X", "x", "n", "-");
|
private static final List<String> PATTERN = List.of("X", "x", "n", "-");
|
||||||
|
|
||||||
@ParameterizedTest
|
@ParameterizedTest
|
||||||
@MethodSource
|
@MethodSource
|
||||||
void testApplyToJsonContainer(List<String> fields, ContainerNode<?> original, ContainerNode<?> expected) {
|
void testApplyToJsonContainer(FieldsSelector selector, ContainerNode<?> original, ContainerNode<?> expected) {
|
||||||
Mask policy = new Mask(fields, PATTERN);
|
Mask policy = new Mask(selector, PATTERN);
|
||||||
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static Stream<Arguments> testApplyToJsonContainer() {
|
private static Stream<Arguments> testApplyToJsonContainer() {
|
||||||
return Stream.of(
|
return Stream.of(
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
||||||
parse("{ \"id\": \"nnn\", \"name\": { \"first\": \"Xxxxx\", \"surname\": \"Xxxxnnn-\"}}")
|
parse("{ \"id\": \"nnn\", \"name\": { \"first\": \"Xxxxx\", \"surname\": \"Xxxxnnn-\"}}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
||||||
parse("[{ \"id\": \"nnn\", \"f2\": 234}, { \"name\": \"n-n\", \"f2\": 345} ]")
|
parse("[{ \"id\": \"nnn\", \"f2\": 234}, { \"name\": \"n-n\", \"f2\": 345} ]")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Xxxxnnn-\"}}")
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Xxxxnnn-\"}}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
List.of(),
|
(FieldsSelector) (fieldName -> true),
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
||||||
parse("{ \"outer\": { \"f1\": \"Xxxxx\", \"name\": \"Xxxxnnn-\"}}")
|
parse("{ \"outer\": { \"f1\": \"Xxxxx\", \"name\": \"Xxxxnnn-\"}}")
|
||||||
)
|
)
|
||||||
|
@ -57,7 +57,7 @@ class MaskTest {
|
||||||
"null, xxxx"
|
"null, xxxx"
|
||||||
})
|
})
|
||||||
void testApplyToString(String original, String expected) {
|
void testApplyToString(String original, String expected) {
|
||||||
Mask policy = new Mask(List.of(), PATTERN);
|
Mask policy = new Mask(fieldName -> true, PATTERN);
|
||||||
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -15,39 +15,39 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||||
|
|
||||||
class RemoveTest {
|
class RemoveTest {
|
||||||
|
|
||||||
private static final List<String> TARGET_FIELDS = List.of("id", "name");
|
private static final FieldsSelector FIELDS_SELECTOR = fieldName -> List.of("id", "name").contains(fieldName);
|
||||||
|
|
||||||
@ParameterizedTest
|
@ParameterizedTest
|
||||||
@MethodSource
|
@MethodSource
|
||||||
void testApplyToJsonContainer(List<String> fields, ContainerNode<?> original, ContainerNode<?> expected) {
|
void testApplyToJsonContainer(FieldsSelector fieldsSelector, ContainerNode<?> original, ContainerNode<?> expected) {
|
||||||
var policy = new Remove(fields);
|
var policy = new Remove(fieldsSelector);
|
||||||
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static Stream<Arguments> testApplyToJsonContainer() {
|
private static Stream<Arguments> testApplyToJsonContainer() {
|
||||||
return Stream.of(
|
return Stream.of(
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
||||||
parse("{}")
|
parse("{}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
||||||
parse("[{ \"f2\": 234}, { \"f2\": 345} ]")
|
parse("[{ \"f2\": 234}, { \"f2\": 345} ]")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
||||||
parse("{ \"outer\": { \"f1\": \"James\"}}")
|
parse("{ \"outer\": { \"f1\": \"James\"}}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
List.of(),
|
(FieldsSelector) (fieldName -> true),
|
||||||
parse("{ \"outer\": { \"f1\": \"v1\", \"f2\": \"v2\", \"inner\" : {\"if1\": \"iv1\"}}}"),
|
parse("{ \"outer\": { \"f1\": \"v1\", \"f2\": \"v2\", \"inner\" : {\"if1\": \"iv1\"}}}"),
|
||||||
parse("{}")
|
parse("{}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
List.of(),
|
(FieldsSelector) (fieldName -> true),
|
||||||
parse("[{ \"f1\": 123}, { \"f2\": \"1.2\"} ]"),
|
parse("[{ \"f1\": 123}, { \"f2\": \"1.2\"} ]"),
|
||||||
parse("[{}, {}]")
|
parse("[{}, {}]")
|
||||||
)
|
)
|
||||||
|
@ -66,7 +66,7 @@ class RemoveTest {
|
||||||
"null, null"
|
"null, null"
|
||||||
})
|
})
|
||||||
void testApplyToString(String original, String expected) {
|
void testApplyToString(String original, String expected) {
|
||||||
var policy = new Remove(List.of());
|
var policy = new Remove(fieldName -> true);
|
||||||
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
}
|
}
|
|
@ -15,35 +15,35 @@ import org.junit.jupiter.params.provider.MethodSource;
|
||||||
|
|
||||||
class ReplaceTest {
|
class ReplaceTest {
|
||||||
|
|
||||||
private static final List<String> TARGET_FIELDS = List.of("id", "name");
|
private static final FieldsSelector FIELDS_SELECTOR = fieldName -> List.of("id", "name").contains(fieldName);
|
||||||
private static final String REPLACEMENT_STRING = "***";
|
private static final String REPLACEMENT_STRING = "***";
|
||||||
|
|
||||||
@ParameterizedTest
|
@ParameterizedTest
|
||||||
@MethodSource
|
@MethodSource
|
||||||
void testApplyToJsonContainer(List<String> fields, ContainerNode<?> original, ContainerNode<?> expected) {
|
void testApplyToJsonContainer(FieldsSelector fieldsSelector, ContainerNode<?> original, ContainerNode<?> expected) {
|
||||||
var policy = new Replace(fields, REPLACEMENT_STRING);
|
var policy = new Replace(fieldsSelector, REPLACEMENT_STRING);
|
||||||
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
assertThat(policy.applyToJsonContainer(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static Stream<Arguments> testApplyToJsonContainer() {
|
private static Stream<Arguments> testApplyToJsonContainer() {
|
||||||
return Stream.of(
|
return Stream.of(
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
parse("{ \"id\": 123, \"name\": { \"first\": \"James\", \"surname\": \"Bond777!\"}}"),
|
||||||
parse("{ \"id\": \"***\", \"name\": { \"first\": \"***\", \"surname\": \"***\"}}")
|
parse("{ \"id\": \"***\", \"name\": { \"first\": \"***\", \"surname\": \"***\"}}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
parse("[{ \"id\": 123, \"f2\": 234}, { \"name\": \"1.2\", \"f2\": 345} ]"),
|
||||||
parse("[{ \"id\": \"***\", \"f2\": 234}, { \"name\": \"***\", \"f2\": 345} ]")
|
parse("[{ \"id\": \"***\", \"f2\": 234}, { \"name\": \"***\", \"f2\": 345} ]")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
TARGET_FIELDS,
|
FIELDS_SELECTOR,
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"Bond777!\"}}"),
|
||||||
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"***\"}}")
|
parse("{ \"outer\": { \"f1\": \"James\", \"name\": \"***\"}}")
|
||||||
),
|
),
|
||||||
Arguments.of(
|
Arguments.of(
|
||||||
List.of(),
|
(FieldsSelector) (fieldName -> true),
|
||||||
parse("{ \"outer\": { \"f1\": \"v1\", \"f2\": \"v2\", \"inner\" : {\"if1\": \"iv1\"}}}"),
|
parse("{ \"outer\": { \"f1\": \"v1\", \"f2\": \"v2\", \"inner\" : {\"if1\": \"iv1\"}}}"),
|
||||||
parse("{ \"outer\": { \"f1\": \"***\", \"f2\": \"***\", \"inner\" : {\"if1\": \"***\"}}}}")
|
parse("{ \"outer\": { \"f1\": \"***\", \"f2\": \"***\", \"inner\" : {\"if1\": \"***\"}}}}")
|
||||||
)
|
)
|
||||||
|
@ -62,7 +62,7 @@ class ReplaceTest {
|
||||||
"null, ***"
|
"null, ***"
|
||||||
})
|
})
|
||||||
void testApplyToString(String original, String expected) {
|
void testApplyToString(String original, String expected) {
|
||||||
var policy = new Replace(List.of(), REPLACEMENT_STRING);
|
var policy = new Replace(fieldName -> true, REPLACEMENT_STRING);
|
||||||
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
assertThat(policy.applyToString(original)).isEqualTo(expected);
|
||||||
}
|
}
|
||||||
}
|
}
|
|
@ -3632,7 +3632,9 @@ components:
|
||||||
type: array
|
type: array
|
||||||
items:
|
items:
|
||||||
type: string
|
type: string
|
||||||
pattern:
|
fieldsNamePattern:
|
||||||
|
type: string
|
||||||
|
maskingCharsReplacement:
|
||||||
type: array
|
type: array
|
||||||
items:
|
items:
|
||||||
type: string
|
type: string
|
||||||
|
|
|
@ -486,11 +486,7 @@ public class TopicsTest extends BaseTest {
|
||||||
topicDetails
|
topicDetails
|
||||||
.waitUntilScreenReady();
|
.waitUntilScreenReady();
|
||||||
TOPIC_LIST.add(topicToCopy);
|
TOPIC_LIST.add(topicToCopy);
|
||||||
SoftAssert softly = new SoftAssert();
|
Assert.assertTrue(topicDetails.isTopicHeaderVisible(topicToCopy.getName()), "isTopicHeaderVisible()");
|
||||||
softly.assertTrue(topicDetails.isAlertWithMessageVisible(SUCCESS, "Topic successfully created."),
|
|
||||||
"isAlertWithMessageVisible()");
|
|
||||||
softly.assertTrue(topicDetails.isTopicHeaderVisible(topicToCopy.getName()), "isTopicHeaderVisible()");
|
|
||||||
softly.assertAll();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@AfterClass(alwaysRun = true)
|
@AfterClass(alwaysRun = true)
|
||||||
|
|
|
@ -1,26 +1,41 @@
|
||||||
import React from 'react';
|
import React from 'react';
|
||||||
import { FullConnectorInfo } from 'generated-sources';
|
import {
|
||||||
|
Action,
|
||||||
|
ConnectorAction,
|
||||||
|
ConnectorState,
|
||||||
|
FullConnectorInfo,
|
||||||
|
ResourceType,
|
||||||
|
} from 'generated-sources';
|
||||||
import { CellContext } from '@tanstack/react-table';
|
import { CellContext } from '@tanstack/react-table';
|
||||||
import { ClusterNameRoute } from 'lib/paths';
|
import { ClusterNameRoute } from 'lib/paths';
|
||||||
import useAppParams from 'lib/hooks/useAppParams';
|
import useAppParams from 'lib/hooks/useAppParams';
|
||||||
import { Dropdown, DropdownItem } from 'components/common/Dropdown';
|
import { Dropdown, DropdownItem } from 'components/common/Dropdown';
|
||||||
import { useDeleteConnector } from 'lib/hooks/api/kafkaConnect';
|
import {
|
||||||
|
useDeleteConnector,
|
||||||
|
useUpdateConnectorState,
|
||||||
|
} from 'lib/hooks/api/kafkaConnect';
|
||||||
import { useConfirm } from 'lib/hooks/useConfirm';
|
import { useConfirm } from 'lib/hooks/useConfirm';
|
||||||
|
import { useIsMutating } from '@tanstack/react-query';
|
||||||
|
import { ActionDropdownItem } from 'components/common/ActionComponent';
|
||||||
|
|
||||||
const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
|
const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
|
||||||
row,
|
row,
|
||||||
}) => {
|
}) => {
|
||||||
const { connect, name } = row.original;
|
const { connect, name, status } = row.original;
|
||||||
|
|
||||||
const { clusterName } = useAppParams<ClusterNameRoute>();
|
const { clusterName } = useAppParams<ClusterNameRoute>();
|
||||||
|
const mutationsNumber = useIsMutating();
|
||||||
|
const isMutating = mutationsNumber > 0;
|
||||||
const confirm = useConfirm();
|
const confirm = useConfirm();
|
||||||
const deleteMutation = useDeleteConnector({
|
const deleteMutation = useDeleteConnector({
|
||||||
clusterName,
|
clusterName,
|
||||||
connectName: connect,
|
connectName: connect,
|
||||||
connectorName: name,
|
connectorName: name,
|
||||||
});
|
});
|
||||||
|
const stateMutation = useUpdateConnectorState({
|
||||||
|
clusterName,
|
||||||
|
connectName: connect,
|
||||||
|
connectorName: name,
|
||||||
|
});
|
||||||
const handleDelete = () => {
|
const handleDelete = () => {
|
||||||
confirm(
|
confirm(
|
||||||
<>
|
<>
|
||||||
|
@ -31,8 +46,66 @@ const ActionsCell: React.FC<CellContext<FullConnectorInfo, unknown>> = ({
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
// const stateMutation = useUpdateConnectorState(routerProps);
|
||||||
|
const resumeConnectorHandler = () =>
|
||||||
|
stateMutation.mutateAsync(ConnectorAction.RESUME);
|
||||||
|
const restartConnectorHandler = () =>
|
||||||
|
stateMutation.mutateAsync(ConnectorAction.RESTART);
|
||||||
|
|
||||||
|
const restartAllTasksHandler = () =>
|
||||||
|
stateMutation.mutateAsync(ConnectorAction.RESTART_ALL_TASKS);
|
||||||
|
|
||||||
|
const restartFailedTasksHandler = () =>
|
||||||
|
stateMutation.mutateAsync(ConnectorAction.RESTART_FAILED_TASKS);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Dropdown>
|
<Dropdown>
|
||||||
|
{status.state === ConnectorState.PAUSED && (
|
||||||
|
<ActionDropdownItem
|
||||||
|
onClick={resumeConnectorHandler}
|
||||||
|
disabled={isMutating}
|
||||||
|
permission={{
|
||||||
|
resource: ResourceType.CONNECT,
|
||||||
|
action: Action.EDIT,
|
||||||
|
value: name,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Resume
|
||||||
|
</ActionDropdownItem>
|
||||||
|
)}
|
||||||
|
<ActionDropdownItem
|
||||||
|
onClick={restartConnectorHandler}
|
||||||
|
disabled={isMutating}
|
||||||
|
permission={{
|
||||||
|
resource: ResourceType.CONNECT,
|
||||||
|
action: Action.EDIT,
|
||||||
|
value: name,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Restart Connector
|
||||||
|
</ActionDropdownItem>
|
||||||
|
<ActionDropdownItem
|
||||||
|
onClick={restartAllTasksHandler}
|
||||||
|
disabled={isMutating}
|
||||||
|
permission={{
|
||||||
|
resource: ResourceType.CONNECT,
|
||||||
|
action: Action.EDIT,
|
||||||
|
value: name,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Restart All Tasks
|
||||||
|
</ActionDropdownItem>
|
||||||
|
<ActionDropdownItem
|
||||||
|
onClick={restartFailedTasksHandler}
|
||||||
|
disabled={isMutating}
|
||||||
|
permission={{
|
||||||
|
resource: ResourceType.CONNECT,
|
||||||
|
action: Action.EDIT,
|
||||||
|
value: name,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Restart Failed Tasks
|
||||||
|
</ActionDropdownItem>
|
||||||
<DropdownItem onClick={handleDelete} danger>
|
<DropdownItem onClick={handleDelete} danger>
|
||||||
Remove Connector
|
Remove Connector
|
||||||
</DropdownItem>
|
</DropdownItem>
|
||||||
|
|
|
@ -9,7 +9,11 @@ import { screen, waitFor } from '@testing-library/react';
|
||||||
import userEvent from '@testing-library/user-event';
|
import userEvent from '@testing-library/user-event';
|
||||||
import { render, WithRoute } from 'lib/testHelpers';
|
import { render, WithRoute } from 'lib/testHelpers';
|
||||||
import { clusterConnectConnectorPath, clusterConnectorsPath } from 'lib/paths';
|
import { clusterConnectConnectorPath, clusterConnectorsPath } from 'lib/paths';
|
||||||
import { useConnectors, useDeleteConnector } from 'lib/hooks/api/kafkaConnect';
|
import {
|
||||||
|
useConnectors,
|
||||||
|
useDeleteConnector,
|
||||||
|
useUpdateConnectorState,
|
||||||
|
} from 'lib/hooks/api/kafkaConnect';
|
||||||
|
|
||||||
const mockedUsedNavigate = jest.fn();
|
const mockedUsedNavigate = jest.fn();
|
||||||
const mockDelete = jest.fn();
|
const mockDelete = jest.fn();
|
||||||
|
@ -22,6 +26,7 @@ jest.mock('react-router-dom', () => ({
|
||||||
jest.mock('lib/hooks/api/kafkaConnect', () => ({
|
jest.mock('lib/hooks/api/kafkaConnect', () => ({
|
||||||
useConnectors: jest.fn(),
|
useConnectors: jest.fn(),
|
||||||
useDeleteConnector: jest.fn(),
|
useDeleteConnector: jest.fn(),
|
||||||
|
useUpdateConnectorState: jest.fn(),
|
||||||
}));
|
}));
|
||||||
|
|
||||||
const clusterName = 'local';
|
const clusterName = 'local';
|
||||||
|
@ -42,6 +47,10 @@ describe('Connectors List', () => {
|
||||||
(useConnectors as jest.Mock).mockImplementation(() => ({
|
(useConnectors as jest.Mock).mockImplementation(() => ({
|
||||||
data: connectors,
|
data: connectors,
|
||||||
}));
|
}));
|
||||||
|
const restartConnector = jest.fn();
|
||||||
|
(useUpdateConnectorState as jest.Mock).mockImplementation(() => ({
|
||||||
|
mutateAsync: restartConnector,
|
||||||
|
}));
|
||||||
});
|
});
|
||||||
|
|
||||||
it('renders', async () => {
|
it('renders', async () => {
|
||||||
|
|
|
@ -1,4 +1,5 @@
|
||||||
import styled from 'styled-components';
|
import styled from 'styled-components';
|
||||||
|
import { Button } from 'components/common/Button/Button';
|
||||||
|
|
||||||
export const DiffWrapper = styled.div`
|
export const DiffWrapper = styled.div`
|
||||||
align-items: stretch;
|
align-items: stretch;
|
||||||
|
@ -81,3 +82,6 @@ export const DiffTile = styled.div`
|
||||||
export const DiffVersionsSelect = styled.div`
|
export const DiffVersionsSelect = styled.div`
|
||||||
width: 0.625em;
|
width: 0.625em;
|
||||||
`;
|
`;
|
||||||
|
export const BackButton = styled(Button)`
|
||||||
|
margin: 10px 9px;
|
||||||
|
`;
|
||||||
|
|
|
@ -20,6 +20,7 @@ import useAppParams from 'lib/hooks/useAppParams';
|
||||||
import PageHeading from 'components/common/PageHeading/PageHeading';
|
import PageHeading from 'components/common/PageHeading/PageHeading';
|
||||||
|
|
||||||
import * as S from './Diff.styled';
|
import * as S from './Diff.styled';
|
||||||
|
import { BackButton } from './Diff.styled';
|
||||||
|
|
||||||
export interface DiffProps {
|
export interface DiffProps {
|
||||||
versions: SchemaSubject[];
|
versions: SchemaSubject[];
|
||||||
|
@ -77,6 +78,13 @@ const Diff: React.FC<DiffProps> = ({ versions, areVersionsFetched }) => {
|
||||||
backText="Schema Registry"
|
backText="Schema Registry"
|
||||||
backTo={clusterSchemasPath(clusterName)}
|
backTo={clusterSchemasPath(clusterName)}
|
||||||
/>
|
/>
|
||||||
|
<BackButton
|
||||||
|
buttonType="secondary"
|
||||||
|
buttonSize="S"
|
||||||
|
onClick={() => navigate(-1)}
|
||||||
|
>
|
||||||
|
Back
|
||||||
|
</BackButton>
|
||||||
<S.Section>
|
<S.Section>
|
||||||
{areVersionsFetched ? (
|
{areVersionsFetched ? (
|
||||||
<S.DiffBox>
|
<S.DiffBox>
|
||||||
|
|
|
@ -3,6 +3,7 @@ import Diff, { DiffProps } from 'components/Schemas/Diff/Diff';
|
||||||
import { render, WithRoute } from 'lib/testHelpers';
|
import { render, WithRoute } from 'lib/testHelpers';
|
||||||
import { screen } from '@testing-library/react';
|
import { screen } from '@testing-library/react';
|
||||||
import { clusterSchemaComparePath } from 'lib/paths';
|
import { clusterSchemaComparePath } from 'lib/paths';
|
||||||
|
import userEvent from '@testing-library/user-event';
|
||||||
|
|
||||||
import { versions } from './fixtures';
|
import { versions } from './fixtures';
|
||||||
|
|
||||||
|
@ -142,4 +143,24 @@ describe('Diff', () => {
|
||||||
expect(select).toHaveTextContent(versions[0].version);
|
expect(select).toHaveTextContent(versions[0].version);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('Back button', () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
setupComponent({
|
||||||
|
areVersionsFetched: true,
|
||||||
|
versions,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it('back button is appear', () => {
|
||||||
|
const backButton = screen.getAllByRole('button', { name: 'Back' });
|
||||||
|
expect(backButton[0]).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('click on back button', () => {
|
||||||
|
const backButton = screen.getAllByRole('button', { name: 'Back' });
|
||||||
|
userEvent.click(backButton[0]);
|
||||||
|
expect(screen.queryByRole('Back')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
|
@ -142,6 +142,8 @@ const Message: React.FC<Props> = ({
|
||||||
timestampType={timestampType}
|
timestampType={timestampType}
|
||||||
keySize={keySize}
|
keySize={keySize}
|
||||||
contentSize={valueSize}
|
contentSize={valueSize}
|
||||||
|
keySerde={keySerde}
|
||||||
|
valueSerde={valueSerde}
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</>
|
</>
|
||||||
|
|
|
@ -3,7 +3,6 @@ import EditorViewer from 'components/common/EditorViewer/EditorViewer';
|
||||||
import BytesFormatted from 'components/common/BytesFormatted/BytesFormatted';
|
import BytesFormatted from 'components/common/BytesFormatted/BytesFormatted';
|
||||||
import { SchemaType, TopicMessageTimestampTypeEnum } from 'generated-sources';
|
import { SchemaType, TopicMessageTimestampTypeEnum } from 'generated-sources';
|
||||||
import { formatTimestamp } from 'lib/dateTimeHelpers';
|
import { formatTimestamp } from 'lib/dateTimeHelpers';
|
||||||
import { useSearchParams } from 'react-router-dom';
|
|
||||||
|
|
||||||
import * as S from './MessageContent.styled';
|
import * as S from './MessageContent.styled';
|
||||||
|
|
||||||
|
@ -17,6 +16,8 @@ export interface MessageContentProps {
|
||||||
timestampType?: TopicMessageTimestampTypeEnum;
|
timestampType?: TopicMessageTimestampTypeEnum;
|
||||||
keySize?: number;
|
keySize?: number;
|
||||||
contentSize?: number;
|
contentSize?: number;
|
||||||
|
keySerde?: string;
|
||||||
|
valueSerde?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
const MessageContent: React.FC<MessageContentProps> = ({
|
const MessageContent: React.FC<MessageContentProps> = ({
|
||||||
|
@ -27,12 +28,10 @@ const MessageContent: React.FC<MessageContentProps> = ({
|
||||||
timestampType,
|
timestampType,
|
||||||
keySize,
|
keySize,
|
||||||
contentSize,
|
contentSize,
|
||||||
|
keySerde,
|
||||||
|
valueSerde,
|
||||||
}) => {
|
}) => {
|
||||||
const [activeTab, setActiveTab] = React.useState<Tab>('content');
|
const [activeTab, setActiveTab] = React.useState<Tab>('content');
|
||||||
const [searchParams] = useSearchParams();
|
|
||||||
const keyFormat = searchParams.get('keySerde') || '';
|
|
||||||
const valueFormat = searchParams.get('valueSerde') || '';
|
|
||||||
|
|
||||||
const activeTabContent = () => {
|
const activeTabContent = () => {
|
||||||
switch (activeTab) {
|
switch (activeTab) {
|
||||||
case 'content':
|
case 'content':
|
||||||
|
@ -110,7 +109,7 @@ const MessageContent: React.FC<MessageContentProps> = ({
|
||||||
<S.Metadata>
|
<S.Metadata>
|
||||||
<S.MetadataLabel>Key Serde</S.MetadataLabel>
|
<S.MetadataLabel>Key Serde</S.MetadataLabel>
|
||||||
<span>
|
<span>
|
||||||
<S.MetadataValue>{keyFormat}</S.MetadataValue>
|
<S.MetadataValue>{keySerde}</S.MetadataValue>
|
||||||
<S.MetadataMeta>
|
<S.MetadataMeta>
|
||||||
Size: <BytesFormatted value={keySize} />
|
Size: <BytesFormatted value={keySize} />
|
||||||
</S.MetadataMeta>
|
</S.MetadataMeta>
|
||||||
|
@ -120,7 +119,7 @@ const MessageContent: React.FC<MessageContentProps> = ({
|
||||||
<S.Metadata>
|
<S.Metadata>
|
||||||
<S.MetadataLabel>Value Serde</S.MetadataLabel>
|
<S.MetadataLabel>Value Serde</S.MetadataLabel>
|
||||||
<span>
|
<span>
|
||||||
<S.MetadataValue>{valueFormat}</S.MetadataValue>
|
<S.MetadataValue>{valueSerde}</S.MetadataValue>
|
||||||
<S.MetadataMeta>
|
<S.MetadataMeta>
|
||||||
Size: <BytesFormatted value={contentSize} />
|
Size: <BytesFormatted value={contentSize} />
|
||||||
</S.MetadataMeta>
|
</S.MetadataMeta>
|
||||||
|
|
|
@ -20,6 +20,8 @@ const setupWrapper = (props?: Partial<MessageContentProps>) => {
|
||||||
headers={{ header: 'test' }}
|
headers={{ header: 'test' }}
|
||||||
timestamp={new Date(0)}
|
timestamp={new Date(0)}
|
||||||
timestampType={TopicMessageTimestampTypeEnum.CREATE_TIME}
|
timestampType={TopicMessageTimestampTypeEnum.CREATE_TIME}
|
||||||
|
keySerde="SchemaRegistry"
|
||||||
|
valueSerde="Avro"
|
||||||
{...props}
|
{...props}
|
||||||
/>
|
/>
|
||||||
</tbody>
|
</tbody>
|
||||||
|
@ -27,42 +29,20 @@ const setupWrapper = (props?: Partial<MessageContentProps>) => {
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
const proto =
|
|
||||||
'syntax = "proto3";\npackage com.provectus;\n\nmessage TestProtoRecord {\n string f1 = 1;\n int32 f2 = 2;\n}\n';
|
|
||||||
|
|
||||||
global.TextEncoder = TextEncoder;
|
global.TextEncoder = TextEncoder;
|
||||||
|
|
||||||
const searchParamsContentAVRO = new URLSearchParams({
|
|
||||||
keySerde: 'SchemaRegistry',
|
|
||||||
valueSerde: 'AVRO',
|
|
||||||
limit: '100',
|
|
||||||
});
|
|
||||||
|
|
||||||
const searchParamsContentJSON = new URLSearchParams({
|
|
||||||
keySerde: 'SchemaRegistry',
|
|
||||||
valueSerde: 'JSON',
|
|
||||||
limit: '100',
|
|
||||||
});
|
|
||||||
|
|
||||||
const searchParamsContentPROTOBUF = new URLSearchParams({
|
|
||||||
keySerde: 'SchemaRegistry',
|
|
||||||
valueSerde: 'PROTOBUF',
|
|
||||||
limit: '100',
|
|
||||||
});
|
|
||||||
describe('MessageContent screen', () => {
|
describe('MessageContent screen', () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
render(setupWrapper(), {
|
render(setupWrapper());
|
||||||
initialEntries: [`/messages?${searchParamsContentAVRO}`],
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('renders', () => {
|
describe('Checking keySerde and valueSerde', () => {
|
||||||
it('key format in document', () => {
|
it('keySerde in document', () => {
|
||||||
expect(screen.getByText('SchemaRegistry')).toBeInTheDocument();
|
expect(screen.getByText('SchemaRegistry')).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('content format in document', () => {
|
it('valueSerde in document', () => {
|
||||||
expect(screen.getByText('AVRO')).toBeInTheDocument();
|
expect(screen.getByText('Avro')).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
@ -98,42 +78,3 @@ describe('MessageContent screen', () => {
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('checking content type depend on message type', () => {
|
|
||||||
it('renders component with message having JSON type', () => {
|
|
||||||
render(
|
|
||||||
setupWrapper({
|
|
||||||
messageContent: '{"data": "test"}',
|
|
||||||
}),
|
|
||||||
{ initialEntries: [`/messages?${searchParamsContentJSON}`] }
|
|
||||||
);
|
|
||||||
expect(screen.getByText('JSON')).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
it('renders component with message having AVRO type', () => {
|
|
||||||
render(
|
|
||||||
setupWrapper({
|
|
||||||
messageContent: '{"data": "test"}',
|
|
||||||
}),
|
|
||||||
{ initialEntries: [`/messages?${searchParamsContentAVRO}`] }
|
|
||||||
);
|
|
||||||
expect(screen.getByText('AVRO')).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
it('renders component with message having PROTOBUF type', () => {
|
|
||||||
render(
|
|
||||||
setupWrapper({
|
|
||||||
messageContent: proto,
|
|
||||||
}),
|
|
||||||
{ initialEntries: [`/messages?${searchParamsContentPROTOBUF}`] }
|
|
||||||
);
|
|
||||||
expect(screen.getByText('PROTOBUF')).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
it('renders component with message having no type which is equal to having PROTOBUF type', () => {
|
|
||||||
render(
|
|
||||||
setupWrapper({
|
|
||||||
messageContent: '',
|
|
||||||
}),
|
|
||||||
{ initialEntries: [`/messages?${searchParamsContentPROTOBUF}`] }
|
|
||||||
);
|
|
||||||
expect(screen.getByText('PROTOBUF')).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
|
@ -8,15 +8,29 @@ export const Wrapper = styled.div`
|
||||||
export const Columns = styled.div`
|
export const Columns = styled.div`
|
||||||
margin: -0.75rem;
|
margin: -0.75rem;
|
||||||
margin-bottom: 0.75rem;
|
margin-bottom: 0.75rem;
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
padding: 0.75rem;
|
||||||
|
gap: 8px;
|
||||||
|
|
||||||
@media screen and (min-width: 769px) {
|
@media screen and (min-width: 769px) {
|
||||||
display: flex;
|
display: flex;
|
||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
|
export const Flex = styled.div`
|
||||||
export const Column = styled.div`
|
display: flex;
|
||||||
flex-basis: 0;
|
flex-direction: row;
|
||||||
flex-grow: 1;
|
gap: 8px;
|
||||||
flex-shrink: 1;
|
@media screen and (max-width: 1200px) {
|
||||||
padding: 0.75rem;
|
flex-direction: column;
|
||||||
|
}
|
||||||
|
`;
|
||||||
|
export const FlexItem = styled.div`
|
||||||
|
width: 18rem;
|
||||||
|
@media screen and (max-width: 1450px) {
|
||||||
|
width: 50%;
|
||||||
|
}
|
||||||
|
@media screen and (max-width: 1200px) {
|
||||||
|
width: 100%;
|
||||||
|
}
|
||||||
`;
|
`;
|
||||||
|
|
|
@ -4,6 +4,7 @@ import { RouteParamsClusterTopic } from 'lib/paths';
|
||||||
import { Button } from 'components/common/Button/Button';
|
import { Button } from 'components/common/Button/Button';
|
||||||
import Editor from 'components/common/Editor/Editor';
|
import Editor from 'components/common/Editor/Editor';
|
||||||
import Select, { SelectOption } from 'components/common/Select/Select';
|
import Select, { SelectOption } from 'components/common/Select/Select';
|
||||||
|
import Switch from 'components/common/Switch/Switch';
|
||||||
import useAppParams from 'lib/hooks/useAppParams';
|
import useAppParams from 'lib/hooks/useAppParams';
|
||||||
import { showAlert } from 'lib/errorHandling';
|
import { showAlert } from 'lib/errorHandling';
|
||||||
import { useSendMessage, useTopicDetails } from 'lib/hooks/api/topics';
|
import { useSendMessage, useTopicDetails } from 'lib/hooks/api/topics';
|
||||||
|
@ -26,9 +27,12 @@ interface FormType {
|
||||||
partition: number;
|
partition: number;
|
||||||
keySerde: string;
|
keySerde: string;
|
||||||
valueSerde: string;
|
valueSerde: string;
|
||||||
|
keepContents: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
const SendMessage: React.FC<{ closeSidebar: () => void }> = ({
|
||||||
|
closeSidebar,
|
||||||
|
}) => {
|
||||||
const { clusterName, topicName } = useAppParams<RouteParamsClusterTopic>();
|
const { clusterName, topicName } = useAppParams<RouteParamsClusterTopic>();
|
||||||
const { data: topic } = useTopicDetails({ clusterName, topicName });
|
const { data: topic } = useTopicDetails({ clusterName, topicName });
|
||||||
const { data: serdes = {} } = useSerdes({
|
const { data: serdes = {} } = useSerdes({
|
||||||
|
@ -47,11 +51,13 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
handleSubmit,
|
handleSubmit,
|
||||||
formState: { isSubmitting },
|
formState: { isSubmitting },
|
||||||
control,
|
control,
|
||||||
|
setValue,
|
||||||
} = useForm<FormType>({
|
} = useForm<FormType>({
|
||||||
mode: 'onChange',
|
mode: 'onChange',
|
||||||
defaultValues: {
|
defaultValues: {
|
||||||
...defaultValues,
|
...defaultValues,
|
||||||
partition: Number(partitionOptions[0].value),
|
partition: Number(partitionOptions[0].value),
|
||||||
|
keepContents: false,
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
@ -62,6 +68,7 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
content,
|
content,
|
||||||
headers,
|
headers,
|
||||||
partition,
|
partition,
|
||||||
|
keepContents,
|
||||||
}: FormType) => {
|
}: FormType) => {
|
||||||
let errors: string[] = [];
|
let errors: string[] = [];
|
||||||
|
|
||||||
|
@ -110,7 +117,11 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
keySerde,
|
keySerde,
|
||||||
valueSerde,
|
valueSerde,
|
||||||
});
|
});
|
||||||
onSubmit();
|
if (!keepContents) {
|
||||||
|
setValue('key', '');
|
||||||
|
setValue('content', '');
|
||||||
|
closeSidebar();
|
||||||
|
}
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
// do nothing
|
// do nothing
|
||||||
}
|
}
|
||||||
|
@ -120,7 +131,7 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
<S.Wrapper>
|
<S.Wrapper>
|
||||||
<form onSubmit={handleSubmit(submit)}>
|
<form onSubmit={handleSubmit(submit)}>
|
||||||
<S.Columns>
|
<S.Columns>
|
||||||
<S.Column>
|
<S.FlexItem>
|
||||||
<InputLabel>Partition</InputLabel>
|
<InputLabel>Partition</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -137,8 +148,9 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</S.FlexItem>
|
||||||
<S.Column>
|
<S.Flex>
|
||||||
|
<S.FlexItem>
|
||||||
<InputLabel>Key Serde</InputLabel>
|
<InputLabel>Key Serde</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -155,8 +167,8 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</S.FlexItem>
|
||||||
<S.Column>
|
<S.FlexItem>
|
||||||
<InputLabel>Value Serde</InputLabel>
|
<InputLabel>Value Serde</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -173,11 +185,21 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</S.FlexItem>
|
||||||
|
</S.Flex>
|
||||||
|
<div>
|
||||||
|
<Controller
|
||||||
|
control={control}
|
||||||
|
name="keepContents"
|
||||||
|
render={({ field: { name, onChange, value } }) => (
|
||||||
|
<Switch name={name} onChange={onChange} checked={value} />
|
||||||
|
)}
|
||||||
|
/>
|
||||||
|
<InputLabel>Keep contents</InputLabel>
|
||||||
|
</div>
|
||||||
</S.Columns>
|
</S.Columns>
|
||||||
|
|
||||||
<S.Columns>
|
<S.Columns>
|
||||||
<S.Column>
|
<div>
|
||||||
<InputLabel>Key</InputLabel>
|
<InputLabel>Key</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -191,8 +213,8 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</div>
|
||||||
<S.Column>
|
<div>
|
||||||
<InputLabel>Value</InputLabel>
|
<InputLabel>Value</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -206,10 +228,10 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</div>
|
||||||
</S.Columns>
|
</S.Columns>
|
||||||
<S.Columns>
|
<S.Columns>
|
||||||
<S.Column>
|
<div>
|
||||||
<InputLabel>Headers</InputLabel>
|
<InputLabel>Headers</InputLabel>
|
||||||
<Controller
|
<Controller
|
||||||
control={control}
|
control={control}
|
||||||
|
@ -224,7 +246,7 @@ const SendMessage: React.FC<{ onSubmit: () => void }> = ({ onSubmit }) => {
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</S.Column>
|
</div>
|
||||||
</S.Columns>
|
</S.Columns>
|
||||||
<Button
|
<Button
|
||||||
buttonSize="M"
|
buttonSize="M"
|
||||||
|
|
|
@ -49,7 +49,7 @@ const renderComponent = async () => {
|
||||||
const path = clusterTopicPath(clusterName, topicName);
|
const path = clusterTopicPath(clusterName, topicName);
|
||||||
await render(
|
await render(
|
||||||
<WithRoute path={clusterTopicPath()}>
|
<WithRoute path={clusterTopicPath()}>
|
||||||
<SendMessage onSubmit={mockOnSubmit} />
|
<SendMessage closeSidebar={mockOnSubmit} />
|
||||||
</WithRoute>,
|
</WithRoute>,
|
||||||
{ initialEntries: [path] }
|
{ initialEntries: [path] }
|
||||||
);
|
);
|
||||||
|
|
|
@ -59,7 +59,7 @@ const Topic: React.FC = () => {
|
||||||
|
|
||||||
const deleteTopicHandler = async () => {
|
const deleteTopicHandler = async () => {
|
||||||
await deleteTopic.mutateAsync(topicName);
|
await deleteTopic.mutateAsync(topicName);
|
||||||
navigate('../..');
|
navigate(clusterTopicsPath(clusterName));
|
||||||
};
|
};
|
||||||
|
|
||||||
React.useEffect(() => {
|
React.useEffect(() => {
|
||||||
|
@ -236,7 +236,7 @@ const Topic: React.FC = () => {
|
||||||
title="Produce Message"
|
title="Produce Message"
|
||||||
>
|
>
|
||||||
<Suspense fallback={<PageLoader />}>
|
<Suspense fallback={<PageLoader />}>
|
||||||
<SendMessage onSubmit={closeSidebar} />
|
<SendMessage closeSidebar={closeSidebar} />
|
||||||
</Suspense>
|
</Suspense>
|
||||||
</SlidingSidebar>
|
</SlidingSidebar>
|
||||||
</>
|
</>
|
||||||
|
|
|
@ -10,6 +10,7 @@ import {
|
||||||
clusterTopicMessagesPath,
|
clusterTopicMessagesPath,
|
||||||
clusterTopicPath,
|
clusterTopicPath,
|
||||||
clusterTopicSettingsPath,
|
clusterTopicSettingsPath,
|
||||||
|
clusterTopicsPath,
|
||||||
clusterTopicStatisticsPath,
|
clusterTopicStatisticsPath,
|
||||||
getNonExactPath,
|
getNonExactPath,
|
||||||
} from 'lib/paths';
|
} from 'lib/paths';
|
||||||
|
@ -179,7 +180,9 @@ describe('Details', () => {
|
||||||
name: 'Confirm',
|
name: 'Confirm',
|
||||||
});
|
});
|
||||||
await userEvent.click(submitDeleteButton);
|
await userEvent.click(submitDeleteButton);
|
||||||
expect(mockNavigate).toHaveBeenCalledWith('../..');
|
expect(mockNavigate).toHaveBeenCalledWith(
|
||||||
|
clusterTopicsPath(mockClusterName)
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('shows a confirmation popup on deleting topic messages', async () => {
|
it('shows a confirmation popup on deleting topic messages', async () => {
|
||||||
|
|
|
@ -1,52 +1,38 @@
|
||||||
import React from 'react';
|
import React from 'react';
|
||||||
import WarningIcon from 'components/common/Icons/WarningIcon';
|
import WarningIcon from 'components/common/Icons/WarningIcon';
|
||||||
import { gitCommitPath } from 'lib/paths';
|
import { gitCommitPath } from 'lib/paths';
|
||||||
import { useActuatorInfo } from 'lib/hooks/api/actuatorInfo';
|
|
||||||
import { BUILD_VERSION_PATTERN } from 'lib/constants';
|
|
||||||
import { useLatestVersion } from 'lib/hooks/api/latestVersion';
|
import { useLatestVersion } from 'lib/hooks/api/latestVersion';
|
||||||
import { formatTimestamp } from 'lib/dateTimeHelpers';
|
import { formatTimestamp } from 'lib/dateTimeHelpers';
|
||||||
|
|
||||||
import * as S from './Version.styled';
|
import * as S from './Version.styled';
|
||||||
import compareVersions from './compareVersions';
|
|
||||||
|
|
||||||
const Version: React.FC = () => {
|
const Version: React.FC = () => {
|
||||||
const { data: actuatorInfo = {} } = useActuatorInfo();
|
|
||||||
const { data: latestVersionInfo = {} } = useLatestVersion();
|
const { data: latestVersionInfo = {} } = useLatestVersion();
|
||||||
|
const { buildTime, commitId, isLatestRelease } = latestVersionInfo.build;
|
||||||
const tag = actuatorInfo?.build?.version;
|
const { versionTag } = latestVersionInfo?.latestRelease || '';
|
||||||
const commit = actuatorInfo?.git?.commit.id;
|
|
||||||
const { tag_name: latestTag } = latestVersionInfo;
|
|
||||||
|
|
||||||
const outdated = compareVersions(tag, latestTag);
|
|
||||||
|
|
||||||
const currentVersion = tag?.match(BUILD_VERSION_PATTERN)
|
|
||||||
? tag
|
|
||||||
: formatTimestamp(actuatorInfo?.build?.time);
|
|
||||||
|
|
||||||
if (!tag) return null;
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<S.Wrapper>
|
<S.Wrapper>
|
||||||
{!!outdated && (
|
{!isLatestRelease && (
|
||||||
<S.OutdatedWarning
|
<S.OutdatedWarning
|
||||||
title={`Your app version is outdated. Current latest version is ${latestTag}`}
|
title={`Your app version is outdated. Current latest version is ${versionTag}`}
|
||||||
>
|
>
|
||||||
<WarningIcon />
|
<WarningIcon />
|
||||||
</S.OutdatedWarning>
|
</S.OutdatedWarning>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{commit && (
|
{commitId && (
|
||||||
<div>
|
<div>
|
||||||
<S.CurrentCommitLink
|
<S.CurrentCommitLink
|
||||||
title="Current commit"
|
title="Current commit"
|
||||||
target="__blank"
|
target="__blank"
|
||||||
href={gitCommitPath(commit)}
|
href={gitCommitPath(commitId)}
|
||||||
>
|
>
|
||||||
{commit}
|
{commitId}
|
||||||
</S.CurrentCommitLink>
|
</S.CurrentCommitLink>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
<S.CurrentVersion>{currentVersion}</S.CurrentVersion>
|
<S.CurrentVersion>{formatTimestamp(buildTime)}</S.CurrentVersion>
|
||||||
</S.Wrapper>
|
</S.Wrapper>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
|
@ -2,87 +2,40 @@ import React from 'react';
|
||||||
import { screen } from '@testing-library/dom';
|
import { screen } from '@testing-library/dom';
|
||||||
import Version from 'components/Version/Version';
|
import Version from 'components/Version/Version';
|
||||||
import { render } from 'lib/testHelpers';
|
import { render } from 'lib/testHelpers';
|
||||||
import { formatTimestamp } from 'lib/dateTimeHelpers';
|
|
||||||
import { useActuatorInfo } from 'lib/hooks/api/actuatorInfo';
|
|
||||||
import { useLatestVersion } from 'lib/hooks/api/latestVersion';
|
import { useLatestVersion } from 'lib/hooks/api/latestVersion';
|
||||||
import { actuatorInfoPayload } from 'lib/fixtures/actuatorInfo';
|
import {
|
||||||
import { latestVersionPayload } from 'lib/fixtures/latestVersion';
|
deprecatedVersionPayload,
|
||||||
|
latestVersionPayload,
|
||||||
|
} from 'lib/fixtures/latestVersion';
|
||||||
|
|
||||||
jest.mock('lib/hooks/api/actuatorInfo', () => ({
|
|
||||||
useActuatorInfo: jest.fn(),
|
|
||||||
}));
|
|
||||||
jest.mock('lib/hooks/api/latestVersion', () => ({
|
jest.mock('lib/hooks/api/latestVersion', () => ({
|
||||||
useLatestVersion: jest.fn(),
|
useLatestVersion: jest.fn(),
|
||||||
}));
|
}));
|
||||||
|
|
||||||
describe('Version Component', () => {
|
describe('Version Component', () => {
|
||||||
const versionTag = 'v0.5.0';
|
const commitId = '96a577a';
|
||||||
const snapshotTag = 'test-SNAPSHOT';
|
|
||||||
const commitTag = 'befd3b328e2c9c7df57b0c5746561b2f7fee8813';
|
|
||||||
|
|
||||||
const actuatorVersionPayload = actuatorInfoPayload(versionTag);
|
|
||||||
const formattedTimestamp = formatTimestamp(actuatorVersionPayload.build.time);
|
|
||||||
|
|
||||||
|
describe('render latest version', () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
(useActuatorInfo as jest.Mock).mockImplementation(() => ({
|
|
||||||
data: actuatorVersionPayload,
|
|
||||||
}));
|
|
||||||
(useLatestVersion as jest.Mock).mockImplementation(() => ({
|
(useLatestVersion as jest.Mock).mockImplementation(() => ({
|
||||||
data: latestVersionPayload,
|
data: latestVersionPayload,
|
||||||
}));
|
}));
|
||||||
});
|
});
|
||||||
|
it('renders latest release version as current version', async () => {
|
||||||
|
render(<Version />);
|
||||||
|
expect(screen.getByText(commitId)).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
describe('tag does not exist', () => {
|
it('should not show warning icon if it is last release', async () => {
|
||||||
it('does not render component', async () => {
|
render(<Version />);
|
||||||
(useActuatorInfo as jest.Mock).mockImplementation(() => ({
|
expect(screen.queryByRole('img')).not.toBeInTheDocument();
|
||||||
data: null,
|
|
||||||
}));
|
|
||||||
const { container } = render(<Version />);
|
|
||||||
expect(container.firstChild).toBeEmptyDOMElement();
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('renders current version', () => {
|
it('show warning icon if it is not last release', async () => {
|
||||||
it('renders release build version as current version', async () => {
|
(useLatestVersion as jest.Mock).mockImplementation(() => ({
|
||||||
render(<Version />);
|
data: deprecatedVersionPayload,
|
||||||
expect(screen.getByText(versionTag)).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
it('renders formatted timestamp as current version when version is commit', async () => {
|
|
||||||
(useActuatorInfo as jest.Mock).mockImplementation(() => ({
|
|
||||||
data: actuatorInfoPayload(commitTag),
|
|
||||||
}));
|
}));
|
||||||
render(<Version />);
|
render(<Version />);
|
||||||
expect(screen.getByText(formattedTimestamp)).toBeInTheDocument();
|
expect(screen.getByRole('img')).toBeInTheDocument();
|
||||||
});
|
|
||||||
it('renders formatted timestamp as current version when version contains -SNAPSHOT', async () => {
|
|
||||||
(useActuatorInfo as jest.Mock).mockImplementation(() => ({
|
|
||||||
data: actuatorInfoPayload(snapshotTag),
|
|
||||||
}));
|
|
||||||
render(<Version />);
|
|
||||||
expect(screen.getByText(formattedTimestamp)).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('outdated build version', () => {
|
|
||||||
it('renders warning message', async () => {
|
|
||||||
(useActuatorInfo as jest.Mock).mockImplementation(() => ({
|
|
||||||
data: actuatorInfoPayload('v0.3.0'),
|
|
||||||
}));
|
|
||||||
render(<Version />);
|
|
||||||
expect(
|
|
||||||
screen.getByTitle(
|
|
||||||
`Your app version is outdated. Current latest version is ${latestVersionPayload.tag_name}`
|
|
||||||
)
|
|
||||||
).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('current commit id with link', () => {
|
|
||||||
it('renders', async () => {
|
|
||||||
render(<Version />);
|
|
||||||
expect(
|
|
||||||
screen.getByText(actuatorVersionPayload.git.commit.id)
|
|
||||||
).toBeInTheDocument();
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
|
@ -70,7 +70,7 @@ export const DropdownButton = styled.button`
|
||||||
`;
|
`;
|
||||||
|
|
||||||
export const DangerItem = styled.div`
|
export const DangerItem = styled.div`
|
||||||
color: ${({ theme: { dropdown } }) => dropdown.item.color.normal};
|
color: ${({ theme: { dropdown } }) => dropdown.item.color.danger};
|
||||||
`;
|
`;
|
||||||
|
|
||||||
export const DropdownItemHint = styled.div`
|
export const DropdownItemHint = styled.div`
|
||||||
|
|
|
@ -13,6 +13,7 @@ const WarningIcon: React.FC = () => {
|
||||||
return (
|
return (
|
||||||
<WarningIconContainer>
|
<WarningIconContainer>
|
||||||
<svg
|
<svg
|
||||||
|
role="img"
|
||||||
width="14"
|
width="14"
|
||||||
height="13"
|
height="13"
|
||||||
viewBox="0 0 14 13"
|
viewBox="0 0 14 13"
|
||||||
|
|
|
@ -6,7 +6,7 @@ export const Wrapper = styled.div<{ $open?: boolean }>(
|
||||||
position: fixed;
|
position: fixed;
|
||||||
top: ${theme.layout.navBarHeight};
|
top: ${theme.layout.navBarHeight};
|
||||||
bottom: 0;
|
bottom: 0;
|
||||||
width: 60vw;
|
width: 37vw;
|
||||||
right: calc(${$open ? '0px' : theme.layout.rightSidebarWidth} * -1);
|
right: calc(${$open ? '0px' : theme.layout.rightSidebarWidth} * -1);
|
||||||
box-shadow: -1px 0px 10px 0px rgba(0, 0, 0, 0.2);
|
box-shadow: -1px 0px 10px 0px rgba(0, 0, 0, 0.2);
|
||||||
transition: right 0.3s linear;
|
transition: right 0.3s linear;
|
||||||
|
|
|
@ -1,12 +0,0 @@
|
||||||
export const actuatorInfoPayload = (
|
|
||||||
version = 'befd3b328e2c9c7df57b0c5746561b2f7fee8813'
|
|
||||||
) => ({
|
|
||||||
git: { commit: { id: 'befd3b3' } },
|
|
||||||
build: {
|
|
||||||
artifact: 'kafka-ui-api',
|
|
||||||
name: 'kafka-ui-api',
|
|
||||||
time: '2022-09-15T09:52:21.753Z',
|
|
||||||
version,
|
|
||||||
group: 'com.provectus',
|
|
||||||
},
|
|
||||||
});
|
|
|
@ -1,3 +1,16 @@
|
||||||
export const latestVersionPayload = {
|
export const deprecatedVersionPayload = {
|
||||||
tag_name: 'v0.4.0',
|
build: {
|
||||||
|
buildTime: '2023-04-14T09:47:35.463Z',
|
||||||
|
commitId: '96a577a',
|
||||||
|
isLatestRelease: false,
|
||||||
|
version: '96a577a98c6069376c5d22ed49cffd3739f1bbdc',
|
||||||
|
},
|
||||||
|
};
|
||||||
|
export const latestVersionPayload = {
|
||||||
|
build: {
|
||||||
|
buildTime: '2023-04-14T09:47:35.463Z',
|
||||||
|
commitId: '96a577a',
|
||||||
|
isLatestRelease: true,
|
||||||
|
version: '96a577a98c6069376c5d22ed49cffd3739f1bbdc',
|
||||||
|
},
|
||||||
};
|
};
|
||||||
|
|
|
@ -1,17 +0,0 @@
|
||||||
import fetchMock from 'fetch-mock';
|
|
||||||
import * as hooks from 'lib/hooks/api/actuatorInfo';
|
|
||||||
import { expectQueryWorks, renderQueryHook } from 'lib/testHelpers';
|
|
||||||
import { actuatorInfoPayload } from 'lib/fixtures/actuatorInfo';
|
|
||||||
|
|
||||||
const actuatorInfoPath = '/actuator/info';
|
|
||||||
|
|
||||||
describe('Actuator info hooks', () => {
|
|
||||||
beforeEach(() => fetchMock.restore());
|
|
||||||
describe('useActuatorInfo', () => {
|
|
||||||
it('returns the correct data', async () => {
|
|
||||||
const mock = fetchMock.getOnce(actuatorInfoPath, actuatorInfoPayload());
|
|
||||||
const { result } = renderQueryHook(() => hooks.useActuatorInfo());
|
|
||||||
await expectQueryWorks(mock, result);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
|
|
@ -1,18 +1,16 @@
|
||||||
import fetchMock from 'fetch-mock';
|
import fetchMock from 'fetch-mock';
|
||||||
import { expectQueryWorks, renderQueryHook } from 'lib/testHelpers';
|
import { expectQueryWorks, renderQueryHook } from 'lib/testHelpers';
|
||||||
import * as hooks from 'lib/hooks/api/latestVersion';
|
|
||||||
import { GIT_REPO_LATEST_RELEASE_LINK } from 'lib/constants';
|
|
||||||
import { latestVersionPayload } from 'lib/fixtures/latestVersion';
|
import { latestVersionPayload } from 'lib/fixtures/latestVersion';
|
||||||
|
import { useLatestVersion } from 'lib/hooks/api/latestVersion';
|
||||||
|
|
||||||
|
const latestVersionPath = '/api/info';
|
||||||
|
|
||||||
describe('Latest version hooks', () => {
|
describe('Latest version hooks', () => {
|
||||||
beforeEach(() => fetchMock.restore());
|
beforeEach(() => fetchMock.restore());
|
||||||
describe('useLatestVersion', () => {
|
describe('useLatestVersion', () => {
|
||||||
it('returns the correct data', async () => {
|
it('returns the correct data', async () => {
|
||||||
const mock = fetchMock.getOnce(
|
const mock = fetchMock.getOnce(latestVersionPath, latestVersionPayload);
|
||||||
GIT_REPO_LATEST_RELEASE_LINK,
|
const { result } = renderQueryHook(() => useLatestVersion());
|
||||||
latestVersionPayload
|
|
||||||
);
|
|
||||||
const { result } = renderQueryHook(() => hooks.useLatestVersion());
|
|
||||||
await expectQueryWorks(mock, result);
|
await expectQueryWorks(mock, result);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
|
@ -1,19 +0,0 @@
|
||||||
import { useQuery } from '@tanstack/react-query';
|
|
||||||
import { BASE_PARAMS, QUERY_REFETCH_OFF_OPTIONS } from 'lib/constants';
|
|
||||||
|
|
||||||
const fetchActuatorInfo = async () => {
|
|
||||||
const data = await fetch(
|
|
||||||
`${BASE_PARAMS.basePath}/actuator/info`,
|
|
||||||
BASE_PARAMS
|
|
||||||
).then((res) => res.json());
|
|
||||||
|
|
||||||
return data;
|
|
||||||
};
|
|
||||||
|
|
||||||
export function useActuatorInfo() {
|
|
||||||
return useQuery(
|
|
||||||
['actuatorInfo'],
|
|
||||||
fetchActuatorInfo,
|
|
||||||
QUERY_REFETCH_OFF_OPTIONS
|
|
||||||
);
|
|
||||||
}
|
|
|
@ -76,7 +76,8 @@ export function useUpdateConnectorState(props: UseConnectorProps) {
|
||||||
return useMutation(
|
return useMutation(
|
||||||
(action: ConnectorAction) => api.updateConnectorState({ ...props, action }),
|
(action: ConnectorAction) => api.updateConnectorState({ ...props, action }),
|
||||||
{
|
{
|
||||||
onSuccess: () => client.invalidateQueries(connectorKey(props)),
|
onSuccess: () =>
|
||||||
|
client.invalidateQueries(['clusters', props.clusterName, 'connectors']),
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,21 +1,19 @@
|
||||||
import { useQuery } from '@tanstack/react-query';
|
import { useQuery } from '@tanstack/react-query';
|
||||||
import {
|
import { BASE_PARAMS, QUERY_REFETCH_OFF_OPTIONS } from 'lib/constants';
|
||||||
QUERY_REFETCH_OFF_OPTIONS,
|
|
||||||
GIT_REPO_LATEST_RELEASE_LINK,
|
|
||||||
} from 'lib/constants';
|
|
||||||
|
|
||||||
const fetchLatestVersion = async () => {
|
const fetchLatestVersionInfo = async () => {
|
||||||
const data = await fetch(GIT_REPO_LATEST_RELEASE_LINK).then((res) =>
|
const data = await fetch(
|
||||||
res.json()
|
`${BASE_PARAMS.basePath}/api/info`,
|
||||||
);
|
BASE_PARAMS
|
||||||
|
).then((res) => res.json());
|
||||||
|
|
||||||
return data;
|
return data;
|
||||||
};
|
};
|
||||||
|
|
||||||
export function useLatestVersion() {
|
export function useLatestVersion() {
|
||||||
return useQuery(
|
return useQuery(
|
||||||
['latestVersion'],
|
['versionInfo'],
|
||||||
fetchLatestVersion,
|
fetchLatestVersionInfo,
|
||||||
QUERY_REFETCH_OFF_OPTIONS
|
QUERY_REFETCH_OFF_OPTIONS
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
|
@ -122,9 +122,6 @@ export function useCreateTopicMutation(clusterName: ClusterName) {
|
||||||
}),
|
}),
|
||||||
{
|
{
|
||||||
onSuccess: () => {
|
onSuccess: () => {
|
||||||
showSuccessAlert({
|
|
||||||
message: `Topic successfully created.`,
|
|
||||||
});
|
|
||||||
client.invalidateQueries(topicKeys.all(clusterName));
|
client.invalidateQueries(topicKeys.all(clusterName));
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
1
pom.xml
1
pom.xml
|
@ -40,6 +40,7 @@
|
||||||
<kafka-ui-serde-api.version>1.0.0</kafka-ui-serde-api.version>
|
<kafka-ui-serde-api.version>1.0.0</kafka-ui-serde-api.version>
|
||||||
<odd-oddrn-generator.version>0.1.15</odd-oddrn-generator.version>
|
<odd-oddrn-generator.version>0.1.15</odd-oddrn-generator.version>
|
||||||
<odd-oddrn-client.version>0.1.23</odd-oddrn-client.version>
|
<odd-oddrn-client.version>0.1.23</odd-oddrn-client.version>
|
||||||
|
<org.json.version>20230227</org.json.version>
|
||||||
|
|
||||||
<!-- Test dependency versions -->
|
<!-- Test dependency versions -->
|
||||||
<junit.version>5.9.1</junit.version>
|
<junit.version>5.9.1</junit.version>
|
||||||
|
|
Loading…
Add table
Reference in a new issue