Forráskód Böngészése

Try catch block while returning object to pool was fixed

Roman Nedzvetskiy 5 éve
szülő
commit
d3857a7fcc

+ 5 - 7
kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/util/JmxClusterUtil.java

@@ -44,6 +44,11 @@ public class JmxClusterUtil {
             for (String attrName : attrNames) {
                 result.put(attrName, BigDecimal.valueOf((Double) msc.getAttribute(name, attrName)));
             }
+            try {
+                    pool.returnObject(jmxUrl, srv);
+                } catch(Exception e){
+                    log.error("Cannot return object to poll, {}", jmxUrl);
+                }
         } catch (MalformedURLException url) {
             log.error("Cannot create JmxServiceUrl from {}", jmxUrl);
             closeConnectionExceptionally(jmxUrl, srv);
@@ -62,13 +67,6 @@ public class JmxClusterUtil {
             log.error("Error while retrieving connection {} from pool", jmxUrl);
             closeConnectionExceptionally(jmxUrl, srv);
         }
-        if (srv != null) {
-            try {
-                pool.returnObject(jmxUrl, srv);
-            } catch(Exception e){
-                log.error("Cannot return object to poll, {}", jmxUrl);
-            }
-        }
         return result;
     }